[Debian-med-packaging] Bug#891943: r-cran-curl: autopkgtest regression in r-cran-curl 3.1-1

[Steve Langasek]

Package: r-cran-curl
Version: 3.1-1
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch autopkgtest

Hi Andreas,

With the upload of r-cran-curl 3.1-1, the package is now failing its
autopkgtests:

> test_check("curl")
This is libcurl version 7.58.0 with OpenSSL/1.0.2n 
Using test server: http://hb.opencpu.org 
-- 1. Error: echo large data (@test-echo.R#7)  ---------------------------------
there is no package called 'httpuv'
1: curl::curl_echo(handle = handle) at testthat/test-echo.R:7
2: httpuv::startServer
3: getExportedValue(pkg, name)
4: asNamespace(ns)
5: getNamespace(ns)
6: tryCatch(loadNamespace(name), error = function(e) stop(e))
7: tryCatchList(expr, classes, parentenv, handlers)
8: tryCatchOne(expr, names, parentenv, handlers[[1L]])
9: value[[3L]](cond)

== testthat results  ===========================================================

(https://ci.debian.net/packages/r/r-cran-curl/unstable/amd64/)

Adding the test dep on httpuv is straightforward, but then the test also
calls a module called webutils which doesn't appear to exist in the archive.

While the test failure is (unfortunately) not considered a blocker for
Debian testing, autopkgtest regressions are blockers for Ubuntu releases.  I
have therefore uploaded the attached patch to r-cran-curl in Ubuntu.  Please
consider including it in Debian as well.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru r-cran-curl-3.1/debian/patches/skip-new-failing-tests.patch r-cran-curl-3.1/debian/patches/skip-new-failing-tests.patch
--- r-cran-curl-3.1/debian/patches/skip-new-failing-tests.patch	2018-02-21 03:19:56.000000000 -0800
+++ r-cran-curl-3.1/debian/patches/skip-new-failing-tests.patch	2018-03-02 14:57:55.000000000 -0800
@@ -1,10 +1,13 @@
 Description: Some tests fails on ubuntu infrastructure, while others are probably
  broken by the curl libidn implementation.
  They are all new tests, and they fail differently in a local (or DoM) environment.
-Author: Gianfranco Costamagna <locutusofborg at debian.org>
-Last-Update: 2017-10-16
---- a/tests/testthat/test-blockopen.R
-+++ b/tests/testthat/test-blockopen.R
+Author: Gianfranco Costamagna <locutusofborg at debian.org>,
+	Steve Langasek <steve.langasek at ubuntu.com>
+Last-Update: 2018-03-02
+Index: r-cran-curl-3.1/tests/testthat/test-blockopen.R
+===================================================================
+--- r-cran-curl-3.1.orig/tests/testthat/test-blockopen.R
++++ r-cran-curl-3.1/tests/testthat/test-blockopen.R
 @@ -56,20 +56,20 @@
    close(con)
  
@@ -38,8 +41,10 @@
 +  #expect_error(read_text(con))
 +  #close(con)
  })
---- a/tests/testthat/test-idn.R
-+++ b/tests/testthat/test-idn.R
+Index: r-cran-curl-3.1/tests/testthat/test-idn.R
+===================================================================
+--- r-cran-curl-3.1.orig/tests/testthat/test-idn.R
++++ r-cran-curl-3.1/tests/testthat/test-idn.R
 @@ -1,8 +1,7 @@
  context("IDN")
  
@@ -50,3 +55,14 @@
  
    malmo <- "http://www.malm\u00F6.se"
    expect_is(curl::curl_fetch_memory(enc2utf8(malmo))$status_code, "integer")
+Index: r-cran-curl-3.1/tests/testthat/test-echo.R
+===================================================================
+--- r-cran-curl-3.1.orig/tests/testthat/test-echo.R
++++ r-cran-curl-3.1/tests/testthat/test-echo.R
+@@ -5,6 +5,4 @@
+   handle <- curl::new_handle()
+   curl::handle_setform(handle, data =  curl::form_data(bindata, "application/octet-stream"))
+   formdata <- curl::curl_echo(handle = handle)
+-  out <- webutils::parse_http(formdata$body, formdata$content_type)
+-  expect_identical(out$data$value, bindata)
+ })
diff -Nru r-cran-curl-3.1/debian/tests/control r-cran-curl-3.1/debian/tests/control
--- r-cran-curl-3.1/debian/tests/control	2018-02-21 03:19:56.000000000 -0800
+++ r-cran-curl-3.1/debian/tests/control	2018-03-02 14:49:04.000000000 -0800
@@ -1,3 +1,3 @@
 Tests: run-unit-test
-Depends: @, r-cran-testthat, r-cran-jsonlite
+Depends: @, r-cran-testthat, r-cran-jsonlite, r-cran-httpuv
 Restrictions: allow-stderr