[xml/sgml-pkgs] Bug#802971: libxslt: Type confusion may cause DoS

[Salvatore Bonaccorso]

Control: tags -1 + patch fixed-upstream

Hi,

Attached is debdiff to fix that, but haven't uploaded to a delayed
queue so far.

Regards,
Salvatore
-------------- next part --------------
diff -Nru libxslt-1.1.28/debian/changelog libxslt-1.1.28/debian/changelog
--- libxslt-1.1.28/debian/changelog	2013-08-01 08:15:10.000000000 +0200
+++ libxslt-1.1.28/debian/changelog	2015-10-30 08:47:49.000000000 +0100
@@ -1,3 +1,12 @@
+libxslt (1.1.28-2.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Add 0009-Fix-for-type-confusion-in-preprocessing-attributes.patch patch.
+    CVE-2015-7995: Type confusion in preprocessing attributes leading to
+    denial of service. (Closes: #802971)
+
+ -- Salvatore Bonaccorso <carnil at debian.org>  Fri, 30 Oct 2015 08:46:43 +0100
+
 libxslt (1.1.28-2) unstable; urgency=low
 
   * debian/patches/000[4-8].patch:
diff -Nru libxslt-1.1.28/debian/patches/0009-Fix-for-type-confusion-in-preprocessing-attributes.patch libxslt-1.1.28/debian/patches/0009-Fix-for-type-confusion-in-preprocessing-attributes.patch
--- libxslt-1.1.28/debian/patches/0009-Fix-for-type-confusion-in-preprocessing-attributes.patch	1970-01-01 01:00:00.000000000 +0100
+++ libxslt-1.1.28/debian/patches/0009-Fix-for-type-confusion-in-preprocessing-attributes.patch	2015-10-30 08:47:49.000000000 +0100
@@ -0,0 +1,29 @@
+From 7ca19df892ca22d9314e95d59ce2abdeff46b617 Mon Sep 17 00:00:00 2001
+From: Daniel Veillard <veillard at redhat.com>
+Date: Thu, 29 Oct 2015 19:33:23 +0800
+Subject: [PATCH] Fix for type confusion in preprocessing attributes
+
+CVE-2015-7995 http://www.openwall.com/lists/oss-security/2015/10/27/10
+We need to check that the parent node is an element before dereferencing
+its namespace
+---
+ libxslt/preproc.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/libxslt/preproc.c b/libxslt/preproc.c
+index 0eb80a0..7f69325 100644
+--- a/libxslt/preproc.c
++++ b/libxslt/preproc.c
+@@ -2249,7 +2249,8 @@ xsltStylePreCompute(xsltStylesheetPtr style, xmlNodePtr inst) {
+ 	} else if (IS_XSLT_NAME(inst, "attribute")) {
+ 	    xmlNodePtr parent = inst->parent;
+ 
+-	    if ((parent == NULL) || (parent->ns == NULL) ||
++	    if ((parent == NULL) ||
++	        (parent->type != XML_ELEMENT_NODE) || (parent->ns == NULL) ||
+ 		((parent->ns != inst->ns) &&
+ 		 (!xmlStrEqual(parent->ns->href, inst->ns->href))) ||
+ 		(!xmlStrEqual(parent->name, BAD_CAST "attribute-set"))) {
+-- 
+2.6.2
+
diff -Nru libxslt-1.1.28/debian/patches/series libxslt-1.1.28/debian/patches/series
--- libxslt-1.1.28/debian/patches/series	2013-08-01 07:55:42.000000000 +0200
+++ libxslt-1.1.28/debian/patches/series	2015-10-30 08:47:49.000000000 +0100
@@ -6,3 +6,4 @@
 0006-Initialize-pseudo-random-number-generator-with-curre.patch
 0007-EXSLT-function-str-replace-is-broken-as-is.patch
 0008-Fix-quoting-of-xlocale-test-program-in-configure.in.patch
+0009-Fix-for-type-confusion-in-preprocessing-attributes.patch