[kgb-maintainers] Bug#612922: Bug#612922: Check in debian/rules breaks rebuilds with version suffix

[gregor herrmann]

On Fri, 11 Feb 2011 16:29:27 +0100, Moritz Muehlenhoff wrote:

> I've tried to rebuild kgb-bot for Univention Corporate Server, a Debian
> derived distribution based on Debian stable (currently Lenny, our next
> release will be based on Squeeze).

Nice!
 
> Your check in debian/rules:
> 
> [ "$(PKG_VER)" = "$(MOD_VER)" ] \
>    || ( echo "Package version ($(PKG_VER)) doesn't match module version ($(MOD_VER))"; exit 1 )
> 
> breaks such builds. The same applies to security updates, which would
> be labeled 1.05-1+squeeze1 by the Security Team:

Yup, that's nasty.
 
> [ "Version: 1.05-1+squeeze1" = "1.05" ] \
>             || ( echo "Package version (Version: 1.05-1+squeeze1) doesn't match module version (1.05)"; exit 1 )
> Package version (Version: 1.05-1+squeeze1) doesn't match module version (1.05)

This also wouldn't work for a "usual" version like 1.05-1.

But the good news is:

kgb-bot (1.06-1) unstable; urgency=low
..
   + rules: fix determining package version

and from svn:

-PKG_VER := $(shell dpkg-parsechangelog | egrep '^Version:' | sed 's/^Version: \(.\+\)-[0-9]\+$$/\1/')
+PKG_VER := $(shell dpkg-parsechangelog | egrep '^Version:' | sed 's/^Version: \(.\+\)-[^-]\+$$/\1/')


So it should work since 1.06-1 (and does for me).

Could you please take a look too, before I close the bug with this
version?

> It's not obvious to me, why the check is needed, since all KGB packages
> come from the same source package, 

I guess the reason is that we are both upstream and packagers at the
same time, and the version for a new release needs to be changed in
three places -- and probably someone forgot that once in the past :)


Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    NP: Rod Stewart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/kgb-maintainers/attachments/20110211/9f2617ad/attachment.pgp>