[nut-Patches][313195] M ake snmp-ups driver wait for network

nut-patches at alioth.debian.org nut-patches at alioth.debian.org
Fri Mar 23 22:08:02 UTC 2012


Patches item #313195, was changed at 29/06/2011 15:21 by Arnaud Quette
You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=411544&aid=313195&group_id=30602

Status: Open
Priority: 3
Submitted By: Manuel Bouyer (bouyer-guest)
Assigned to: Nobody (None)
Summary: M ake snmp-ups driver wait for network 
Category: None
Group: None
>Resolution: Rejected


Initial Comment:
When starting the snmp-ups driver while the network is not yet fully up (for example because the network switch has not finished booting yet), it will exits after the snmp timeout. Although this could be fixed in startup scripts, I don't feel it's optimal, especially when you have several driver to start and want to use upsdrvctl. The attached patch makes snmp-ups loop in the init phase if it fails because of timeout. upsdrvctl will leave it run in backgroud after some time, allowing the boot to complete. Once the network if full up, snmp-ups will complete initialisation and upsd will connect automatically.

----------------------------------------------------------------------

>Comment By: Arnaud Quette (aquette)
Date: 23/03/2012 23:08

Message:
Hi Manuel,

this patch completely changes default driver init behavior.
this may cause undesired delay, and at least break compatibility.
moreover, there is a goto that could have been avoided!

thus, I reject this version.
please bring this topic on upsdev if you want to further discuss it, and find a possible solution.

----------------------------------------------------------------------

You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=411544&aid=313195&group_id=30602



More information about the NUT-tracker mailing list