[Nut-upsdev] Bug#501087: nut: support for a tripplite avr750u

Raphael Geissert atomo64 at gmail.com
Sat Oct 4 18:41:23 UTC 2008


2008/10/4 Arjen de Korte <nut+devel at de-korte.org>:
> Citeren Arnaud Quette <aquette.dev at gmail.com>:
>>
>> you missed to add an entry in drivers/tripplite-hid.c
>> ->tripplite_claim() for that ;-)
>
> And beware that you need to put it in the correct place as well. Some Tripp
> Lite HID devices (incorrectly) report battery voltage in decivolts so we
> need to apply a correction factor here. So there are basically two groups in
> this function. One that reports battery voltage in decivolts (productid
> 1003, 2005 and 2007) and one that reports battery voltage in volts
> (productid 3012, 4002, 4003). Before committing this change, we need to see
> the output of 'upsc' to know what it reports.

In the attached patch I've added it to the first group, as I'd expect
it to behave just like 1003 (the avr550u model).

I've also attached the output of upsc.

>
>> and an entry in the hotplug script for the sake of completion.
>
> Don't forget the udev and hal scripts either. We probably need to come up
> with some automation here, so that we have to put this in only one place and
> have these scripts generated automagically.

That would be much easier; in the attached patch I added the ups info
to hal, hotplug, udev, and drivers/tripplite-hid.c (btw, why isn't
that info stored in tripplite-hid.h?).

>
> Best regards, Arjen
> --
> Please keep list traffic on the list
>

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: avr750u.2.patch
Type: application/octet-stream
Size: 4140 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20081004/b2536a61/attachment-0002.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: upsc.stdout
Type: application/octet-stream
Size: 762 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20081004/b2536a61/attachment-0003.obj 


More information about the Nut-upsdev mailing list