[Pcsclite-cvs-commit] r3244 - /trunk/PCSC/src/winscard_clnt.c

rousseau at users.alioth.debian.org rousseau at users.alioth.debian.org
Fri Dec 19 10:03:06 UTC 2008


Author: rousseau
Date: Fri Dec 19 10:03:06 2008
New Revision: 3244

URL: http://svn.debian.org/wsvn/pcsclite/?sc=1&rev=3244
Log:
SCardGetAttrib(): avoid a possible memory leak (detected by the cppcheck
tool)

Modified:
    trunk/PCSC/src/winscard_clnt.c

Modified: trunk/PCSC/src/winscard_clnt.c
URL: http://svn.debian.org/wsvn/pcsclite/trunk/PCSC/src/winscard_clnt.c?rev=3244&op=diff
==============================================================================
--- trunk/PCSC/src/winscard_clnt.c (original)
+++ trunk/PCSC/src/winscard_clnt.c Fri Dec 19 10:03:06 2008
@@ -2620,13 +2620,13 @@
 
 	if (SCARD_AUTOALLOCATE == *pcbAttrLen)
 	{
+		if (NULL == pbAttr)
+			return SCARD_E_INVALID_PARAMETER;
+
 		*pcbAttrLen = MAX_BUFFER_SIZE;
 		buf = malloc(*pcbAttrLen);
 		if (NULL == buf)
 			return SCARD_E_NO_MEMORY;
-
-		if (NULL == pbAttr)
-			return SCARD_E_INVALID_PARAMETER;
 
 		*(unsigned char **)pbAttr = buf;
 	}




More information about the Pcsclite-cvs-commit mailing list