[Pcsclite-cvs-commit] r4334 - /trunk/PCSC/src/winscard_svc.c

[rousseau at users.alioth.debian.org]

Author: rousseau
Date: Tue Jul 21 14:26:19 2009
New Revision: 4334

URL: http://svn.debian.org/wsvn/pcsclite/?sc=1&rev=4334
Log:
MSGFunctionDemarshall(): correctly check for buffer overflow in case of
SCardControl()

Bug introduced in revision 4208 included in pcsc-lite 1.5.4

Modified:
    trunk/PCSC/src/winscard_svc.c

Modified: trunk/PCSC/src/winscard_svc.c
URL: http://svn.debian.org/wsvn/pcsclite/trunk/PCSC/src/winscard_svc.c?rev=4334&op=diff
==============================================================================
--- trunk/PCSC/src/winscard_svc.c (original)
+++ trunk/PCSC/src/winscard_svc.c Tue Jul 21 14:26:19 2009
@@ -443,7 +443,7 @@
 		if (rv != 0) return rv;
 
 		/* avoids buffer overflow */
-		if ((ctStr->dwBytesReturned > sizeof(ctStr->cbRecvLength))
+		if ((ctStr->cbRecvLength > sizeof(ctStr->pbRecvBuffer))
 			|| (ctStr->cbSendLength > sizeof(ctStr->pbSendBuffer)))
 		{
 			ctStr->rv = SCARD_E_INSUFFICIENT_BUFFER;