[Pkg-cryptsetup-devel] Bug#458944: cryptsetup: Slightly wrong LSB header in init.d script

[Petter Reinholdtsen]

Package:  cryptsetup
Version:  2:1.0.6~pre1-1
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

When testing dependency based boot sequencing, I discovered what I
believe is a minor bug in the init.d/cryptdisk script.  Because of its
current dependencies, it is inserted with the same sequence number as
cryptdisk-early, and ASCII sorting order make them start in the order
cryptdisk cryptdisk-early (or in parallel, if boot concurrency is
enabled).  This seemed wrong to me.  I checked the postinst, and with
the traditional boot sequencing they are inserted at different
sequence numbers.  This make me believe cryptdisk should depend on
cryptdisk-early.

This patch change this to be the case, and make sure the two scripts
are started in the order cryptdisk-early, cryptdisk, and stopped in
the opposite order even when dependency based boot sequencing is used.

diff -ur cryptsetup-1.0.6~pre1.orig/debian/cryptdisks.init cryptsetup-1.0.6~pre1/debian/cryptdisks.init
--- cryptsetup-1.0.6~pre1.orig/debian/cryptdisks.init   2008-01-03 20:45:47.000000000 +0100
+++ cryptsetup-1.0.6~pre1/debian/cryptdisks.init        2008-01-03 20:49:29.000000000 +0100
@@ -1,8 +1,8 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          cryptdisks
-# Required-Start:    checkroot
-# Required-Stop:     umountroot
+# Required-Start:    checkroot cryptdisk-early
+# Required-Stop:     umountroot cryptdisk-early
 # Should-Start:      udev devfsd raid2 mdadm lvm evms
 # Should-Stop:       udev devfsd raid2 mdadm lvm evms
 # Default-Start:     S

Happy hacking,
--
Petter Reinholdtsen