[Pkg-cups-devel] Bug#489554: Bug#489554: cups-pdf: bashism in /bin/sh script

[Martin-Éric Racine]

If you examine the upstream tarball more closely, you'll notice that
those sample scripts are not supported by upstream or by Debian.
Instead, they were contributed by third-parties and are included only
as a convenience to help users who need to configure cups-pdf for
non-default usage cases.

On 7/6/08, Raphael Geissert <atomo64 at gmail.com> wrote:
> Package: cups-pdf
>  Severity: important
>  Version: 2.4.8-2
>  User: debian-release at lists.debian.org
>  Usertags: goal-dash
>
>  Hello maintainer,
>
>  While performing an archive wide checkbashisms (from the 'devscripts' package)
>  check I've found your package containing one or more /bin/sh scripts making
>  use of bashisms.
>
>  checkbashisms' output:
>  > possible bashism in
>  > ./usr/share/doc/cups-pdf/examples/SELinux-HOWTO/update-module line 19
>  > (should be 'b = a'): if [ "x$SELINUXENABLED" == "x" ]; then
>  > possible bashism in
>  > ./usr/share/doc/cups-pdf/examples/SELinux-HOWTO/update-module line 25
>  > (should be 'b = a'): if [ x"$GETENFORCE" == "x" ]; then
>  > possible bashism in
>  > ./usr/share/doc/cups-pdf/examples/SELinux-HOWTO/update-module line 31
>  > (should be 'b = a'): if [ x"$GETSEBOOL" == "x" ]; then
>  > possible bashism in
>  > ./usr/share/doc/cups-pdf/examples/SELinux-HOWTO/update-module line 37
>  > (should be 'b = a'): if [ x"$CHECKMODULE" == "x" ]; then
>  > possible bashism in
>  > ./usr/share/doc/cups-pdf/examples/SELinux-HOWTO/update-module line 45
>  > (should be 'b = a'): if [ x"$SEMODULE_PACKAGE" == "x" ]; then
>  > possible bashism in
>  > ./usr/share/doc/cups-pdf/examples/SELinux-HOWTO/update-module line 51
>  > (should be 'b = a'): if [ x"$SEMODULE" == "x" ]; then
>  > possible bashism in
>  > ./usr/share/doc/cups-pdf/examples/SELinux-HOWTO/update-module line 71
>  > (should be 'b = a'): if [ "`$GETSEBOOL cupsd_disable_trans`" ==
>  > "cupsd_disable_trans --> on" ]; then
>
>  Not using bash (or a Debian Policy conformant shell interpreter which does
>  provide such an extra feature) as /bin/sh is likely to lead to errors or
>  unexpected behaviours.
>  Please be aware that although bash is currently the default /bin/sh there's a
>  release goal for Lenny to make dash the default /bin/sh[1].
>
>  If you want more information about dash as /bin/sh, you can read:
>  http://lists.debian.org/debian-release/2008/01/msg00189.html
>
>  For more information please refer to the Debian Policy section 10.4 supporting
>  this argument at:
>  http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts
>
>  Hints about how to fix bashisms:
>  Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
>  If not already fixed you can read:
>  https://wiki.ubuntu.com/DashAsBinSh
>
>  [1]http://release.debian.org/lenny/goals.txt
>
>  Thank you,
>  --
>  Atomo64 - Raphael
>
>  Please avoid sending me Word, PowerPoint or Excel attachments.
>  See http://www.gnu.org/philosophy/no-word-attachments.html
>
>
>
>  _______________________________________________
>  Pkg-cups-devel mailing list
>  Pkg-cups-devel at lists.alioth.debian.org
>  http://lists.alioth.debian.org/mailman/listinfo/pkg-cups-devel
>


-- 
Martin-Éric Racine
http://q-funk.iki.fi