[Pkg-dns-devel] Bug#840460: knot: FTBFS on kFreeBSD: be16toh et al. undeclared

[Aaron M. Ucko]

Source: knot
Version: 2.3.1-1
Severity: important
Justification: fails to build from source (but built successfully in the past)

Builds of knot 2.3.1 on kFreeBSD (not a release architecture,
admittedly) have been failing:

  In file included from knot/query/query.c:22:0:
  ./contrib/wire.h: In function 'wire_read_u16':
  ./contrib/wire.h:41:9: error: implicit declaration of function
  'be16toh' [-Werror=implicit-function-declaration]
    return be16toh(*(uint16_t *)pos);
           ^~~~~~~
  ./contrib/wire.h: In function 'wire_read_u32':
  ./contrib/wire.h:53:9: error: implicit declaration of function
  'be32toh' [-Werror=implicit-function-declaration]
    return be32toh(*(uint32_t *)pos);
           ^~~~~~~
  ./contrib/wire.h: In function 'wire_read_u48':
  ./contrib/wire.h:67:9: error: implicit declaration of function
  'be64toh' [-Werror=implicit-function-declaration]
    return be64toh(input) >> 8;
           ^~~~~~~
  ./contrib/wire.h: In function 'wire_write_u16':
  ./contrib/wire.h:92:21: error: implicit declaration of function
  'htobe16' [-Werror=implicit-function-declaration]
    *(uint16_t *)pos = htobe16(data);
                       ^~~~~~~
  ./contrib/wire.h: In function 'wire_write_u32':
  ./contrib/wire.h:105:21: error: implicit declaration of function
  'htobe32' [-Werror=implicit-function-declaration]
    *(uint32_t *)pos = htobe32(data);
                       ^~~~~~~
  ./contrib/wire.h: In function 'wire_write_u48':
  ./contrib/wire.h:118:21: error: implicit declaration of function
  'htobe64' [-Werror=implicit-function-declaration]
    uint64_t swapped = htobe64(data << 8);
                       ^~~~~~~

The problem appears to be that src/contrib/endian.h ignores this
architecture, rather than including system <endian.h>.  (The Hurd
build would presumably hit the same error if it weren't blocked
altogether by liblmdb-dev's unavailability there, per #815320.)

Could you please take a look?

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?amu@monk.mit.edu