[pkg-fso-maint] Status Update of SHR stuff

[Jonas Smedegaard]

On Sun, Nov 15, 2009 at 11:24:17PM +0100, Sebastian Reichel wrote:
>On Mon, Nov 16, 2009 at 12:26:18AM +0300, Nikita V. Youshchenko wrote:
>> > >  * libphone-utils
>>
>> Could you please add a postrm script that removes /etc/phone-utils.conf on
>> purge? Policy 10.7.3 :)
>
>oops, I forgot it won't be handeld automatically if I remove the
>file from the package list :) I just pushed a new version into the
>git repository.
>
>> Also, existing postinst code will always overwrite
>> entire /etc/phone-utils.conf, thus not preserving possible user changes to
>> that file outside of 4 variables supported by debconf. E.g. any comments
>> user could add there. This could be treated as a policy violation,
>> although I realize this may be a bit too pedantic :)
>
>I don't think any comments are needed in this file and there are no
>other variables for libphone-utils. Is this change really needed?
>Hacking support for such stuff will result in an ugly postinst file :(

I believe strongly in keeping config file handling very strict.

Attached is a proposed postinst which should preserve comments, 
reordered lines and other oddities, while not being too ugly, IMHO.


Kind regards,

  - Jonas

-- 
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: postinst.diff
Type: text/x-diff
Size: 1109 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20091116/57ebac47/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20091116/57ebac47/attachment.pgp>