[pkg-fso-maint] Bug#748209: Function declaration without parameter type list shadows stack underflow

[Michael Tautschnig]

Package: libphone-ui
Version: 1:0.0.1+git20110825-3
Usertags: goto-cc

During an analysis of all packages using our research compiler tool-chain (using
tools from the cbmc package) the following error was found:

The declaration of _fso_pim_dates in dbus.h

http://sources.debian.net/src/libphone-ui/1:0.0.1+git20110825-3/src/dbus.h?hl=35#L35

shadows the fact that _fso_pim_dates actually requires an argument:

http://sources.debian.net/src/libphone-ui/1:0.0.1+git20110825-3/src/dbus.c?hl=70#L70

Consequently the call here:

http://sources.debian.net/src/libphone-ui/1:0.0.1+git20110825-3/src/phoneui-utils.c?hl=399#L399

will cause a stack underflow and thus results in undefined behaviour (here this
might cause reading of an arbitrary g-object-path, which may result in memory
errors or even inappropriately accessing data).

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20140515/218eee26/attachment.sig>