Found fix for rrootage patch #9 (09_rrootage_make_highres_default.patch)

[Ivy Foster]

On 12 Dec 2015, at  5:44 pm +0100, Markus Koschany wrote:
> Hello Ivy,

Hello,

> Am 11.12.2015 um 21:31 schrieb Ivy Foster:

> > I discovered today why the patch
> > 09_rrootage_make_highres_default.patch doesn't apply: another patch (I
> > presume) changed a line near the actually patched line. The following
> > change allows the patch to apply successfully (and the next line of sed
> > updates the manual).

> Thank you very much for bringing this to our attention. The
> 09_rrootage_make_highres_default.patch was never applied because someone
> disabled the patch in the debian/patches/series file for unknown
> reasons.

I'm willing to bet that the fact it failed to apply was the reason (-: .

> I have rebased the patch according to your instructions.

Thanks.

> > P.S.: Any chance of someone with better C skills than my measly ones
> > patching this thing to drop its state into
> > ${XDG_DATA_HOME:-$HOME/.local/share}/rrootage/
> > instead of directly into $HOME?

> If you mean the ~/.rr.prf file, the path is defined in
> src/attractmanager.c. We could simply change the current value to
> /.local/share/rrootage/rr.prf which is indeed a better place. I will
> make the necessary changes with the next upload of rrootage.

Well, the reason I didn't do it myself is that $XDG_DATA_HOME is,
of course, a variable, so you have to do some fiddling to check
whether the user's set it, and if so respect it, and if not default to
~/.local/share. Hardcoding ~/.local/share messes things up when people
change the var. In shell or scheme or haskell, I know how to do that
stuff; my C's just not good enough for me to do it quickly and without
much consultation of manuals.

> It is better to file bug reports for such issues because they won't get
> lost which can sometimes happen if you send a message to our bug mailing
> list directly. Here is a short introduction about the bug tracking system. [...]
> You can also contact us at debian-devel-games at lists.debian.org which is
> mainly used for discussions about Debian and games.

Thanks, I'll keep that in mind. I appreciate your looking at this!

Cheers,
Ivy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20151212/e6568fb4/attachment.sig>