Bug#776540: game-data-packager: please add support for games working with gemrbd engine

[Markus Koschany]

Control: tags -1 patch pending

Am 08.10.2015 um 16:10 schrieb Alexandre Detiste:
> 2015-10-07 14:01 GMT+02:00 Markus Koschany <apo at gambaru.de>:
>>>
>>> It's important to specify the english archive first; this one will be considered the "original"
>>> version, and the other will have the ?lang prefix appended to files with the same
>>> name but different size/md5.
>>
>> I tried the exact same command with the German and English windows
>> installer and it works but some files from the English version also get
>> the ?en suffix which is probably unnecessary?
>>
>> make-template outputs for example:
>>         chitin.key
>>         chitin.key?en
>>
>> If the English version is always considered the "base" version only
>> chitin.key should suffice.
> 
> This happens because this English archive was likely unpacked without
> using then new "--collisions=rename" innoextract flag.
> You end up with two different files names "chitin.key" & "Chitin.key".

Hi,

ok I give up for now because I can't get it to work with more than one
language version. I have pushed baldurs-gate-1.yaml to git master which
supports the English Linux installer from gog.com.

The debug information from g-d-p are very sparse. I only see

INFO:game-data-packager.build:identifying app1/movies/MOVIECD1.BIF
INFO:game-data-packager.build:identifying app1/movies/MOVIECD4.BIF
INFO:game-data-packager.build:identifying app1/data/GUI.bif
INFO:game-data-packager.build:identifying app1/data/CHAANIM.bif
ERROR:game-data-packager.build:Unable to complete any packages.

That's it and then it fails. The --verbose flag doesn't add any extra
information.

Please correct me if I am wrong: At first I used

game-data-packager make-template setup_baldurs_gate_2.0.0.20.exe
setup_baldurs_gate_german_2.0.0.20.exe > bg_en_de.txt

this produces output like chitin.key?en. How can I use g-d-p with the
--collisions=rename option of innoextract?

When I manually unpack both windows installers with innoextract
--collisions=rename and then run make-template on both unpacked
directories, I get something which looks similar to your last e-mail
attachment but it is still not the same. I've pushed my bg_en_de.txt
file to the baldurs-gate branch, in case you want to have look at it.


This whole renaming is somehow crazy. What do you think about the
following design: just declare all files with size and hashsums per
package and enforce that the user passes a language option to
game-data-packager like

game-data-packager baldurs-gate-1 --lang de <path-to-game-data>


baldurs-gate-1.yaml

size_and_md5:
  lang: en
  baldurs-gate-original-saga-en-data:
  .
  .
  .
  all detected files from the English Linux Installer with size and
  hashsums

  lang: de
  baldurs-gate-original-saga-de-data:
  .
  .
  .
  all detected files from the German Linux Installer with size and
  hashsums


I would only have to trim the raw output from make-template, remove some
files and that's it. No renaming necessary. There will be duplicate
information regarding file names, sizes and hashsums but this design is
much less error prone and simpler to maintain, IMO.

Cheers,

Markus









-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20151010/01f0868d/attachment.sig>