Bug#1066697: pmars: FTBFS: xwindisp.c:1284:9: error: implicit declaration of function =?UTF-8?Q?=E2=80=98sighandler=E2=80=99; ?= did you mean ‘sa_handler’? [-Werror=implicit-function-declaration]

Lucas Nussbaum lucas at debian.org
Wed Mar 13 11:55:39 GMT 2024


Source: pmars
Version: 0.9.2-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
> Making pmars with compiler flags -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O -DEXT94 -DXWINGRAPHX -DPERMUTATE
> Compiling pmars.o
> Compiling asm.o
> Compiling eval.o
> Compiling disasm.o
> Compiling cdb.o
> Compiling sim.o
> Compiling pos.o
> Compiling clparse.o
> In file included from disasm.c:26:
> sim.h:92:12: warning: built-in function ‘round’ declared as non-function [-Wbuiltin-declaration-mismatch]
>    92 | extern int round;
>       |            ^~~~~
> In file included from cdb.c:30:
> sim.h:92:12: warning: built-in function ‘round’ declared as non-function [-Wbuiltin-declaration-mismatch]
>    92 | extern int round;
>       |            ^~~~~
> In file included from pos.c:24:
> sim.h:92:12: warning: built-in function ‘round’ declared as non-function [-Wbuiltin-declaration-mismatch]
>    92 | extern int round;
>       |            ^~~~~
> In file included from sim.c:29:
> sim.h:92:12: warning: built-in function ‘round’ declared as non-function [-Wbuiltin-declaration-mismatch]
>    92 | extern int round;
>       |            ^~~~~
> cdb.c: In function ‘subst_eval’:
> cdb.c:1550:23: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ [-Wformat=]
>  1550 |       sprintf(outs, "%d", (targetID == QUEUE || targetID == PSP ?
>       |                      ~^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                       |
>       |                       int
>       |                      %ld
>  1551 |                            0 : (targetID == WARRIOR ?
>       |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                              |
>       |                              long int
>  1552 |                                 W - warrior : progCnt)));
>       |                                 ~~~~~~~~~~~~~~~~~~~~~~~
> cdb.c:1558:21: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ [-Wformat=]
>  1558 |     sprintf(outs, "%d", (targetID == QUEUE || targetID == PSP ?
>       |                    ~^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                     |
>       |                     int
>       |                    %ld
>  1559 |                          0 : (targetID == WARRIOR ?
>       |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                            |
>       |                            long int
>  1560 |                               W - warrior : progCnt)));
>       |                               ~~~~~~~~~~~~~~~~~~~~~~~
> cdb.c:1563:21: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ [-Wformat=]
>  1563 |     sprintf(outs, "%d", (cycle + (warriorsLeft ? warriorsLeft : 1) - 1) /
>       |                    ~^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                     |                                                   |
>       |                     int                                                 long int
>       |                    %ld
>  1564 |             (warriorsLeft ? warriorsLeft : 1));
>       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> clparse.c: In function ‘next_input’:
> clparse.c:227:5: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   227 |     fscanf(filep, "%s", inputs);
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> clparse.c:234:9: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   234 |         fscanf(filep, "%[^\"]%*[\"]", inputs + i);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> clparse.c:237:7: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   237 |       fgets(inputs, 100, filep);
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~
> clparse.c:239:7: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   239 |       fscanf(filep, "%s", inputs);
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> Compiling global.o
> Compiling token.o
> In file included from sim.c:92:
> xwindisp.c: In function ‘xWin_display_cycle’:
> xwindisp.c:1284:9: error: implicit declaration of function ‘sighandler’; did you mean ‘sa_handler’? [-Werror=implicit-function-declaration]
>  1284 |         sighandler(0);                /* ??? debugState = STEP; *//* stepping =
>       |         ^~~~~~~~~~
>       |         sa_handler
> Compiling str_eng.o
> asm.c: In function ‘errprn’:
> asm.c:895:28: warning: ‘%s’ directive writing up to 255 bytes into a region of size 248 [-Wformat-overflow=]
>   895 |     sprintf(outs, "        %s\n", abuf);
>       |                            ^~     ~~~~
> In file included from /usr/include/stdio.h:906,
>                  from asm.c:41:
> In function ‘sprintf’,
>     inlined from ‘errprn’ at asm.c:895:5:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 10 and 265 bytes into a destination of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> asm.c: In function ‘errprn’:
> asm.c:866:32: warning: ‘%s’ directive writing up to 255 bytes into a region of size 248 [-Wformat-overflow=]
>   866 |         sprintf(outs, "        %s\n", abuf);
>       |                                ^~     ~~~~
> In function ‘sprintf’,
>     inlined from ‘errprn’ at asm.c:866:9:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 10 and 265 bytes into a destination of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> cdb.c: In function ‘load_macros’:
> cdb.c:2234:47: warning: ‘%s’ directive writing up to 255 bytes into a region of size 244 [-Wformat-overflow=]
>  2234 |         sprintf(buffer1 + j + 1, " echo Macro %s is too long (>= %d chars)~reset",
>       |                                               ^~
>  2235 |                 buffer1, MAXSTR);
>       |                 ~~~~~~~                        
> In file included from /usr/include/stdio.h:906,
>                  from global.h:29,
>                  from cdb.c:29:
> In function ‘sprintf’,
>     inlined from ‘load_macros’ at cdb.c:2234:9:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 46 and 301 bytes into a destination of size 256
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:57: sim.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/pmars_0.9.2-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.



More information about the Pkg-games-devel mailing list