Bug#275215:

[Emilio Jesús Gallego Arias]

	El mié, 15-12-2004 a las 13:25 +0100, Marc Dequènes escribió:
> tags 275215 - patch
> severity 275215 minor
> forwarded 275215 http://bugzilla.gnome.org/show_bug.cgi?id=108533
> thanks
> 
> 
> Coin
> 
> Emilio Jesús Gallego Arias <egallego@telefonica.net> writes:
> 
> > I've changed PREFERED_SIZE to 120 and now it works as spected, but this
> > is an upstream bug, so I'll foward it tomorrow.
> >
> > If anyone has an idea of how get the panel size from button-widget.c le=
t
> > me now and I'll make a patch.
> 
> Changing PREFERED_SIZE to 120 is nice for you, not everybody. So this
> patch does not patch anything and cannot be included.

Yes true, but looking at the code and testing gnome-panel for more than
one month I cannot see any adverse effect.

If I understand correctly, this is only the size for rendering the icon,
after the render the icon gets scaled to the rigth size, so It looks
fine. Logically if you render the icon at 48 and then scale it to 120 px
you will display it pixelized.

The logic for setting PREFERED_SIZe at 120 is that 120 is the maximum
width of a panel.

The correct fix should be get the rendering using the panel width, but
this will require some important modifications because button-widget is
not allowed to see the panel.

I fear this is a very minor bug and upstream won't take care of it for a
while (Maybe I'm wrong, I'll see if I can take a look at gnome-panel 2.9
source), so I you think it's not worth the trouble close the bug.

Thank you very much, regards,

Emilio