Bug#290309: marked as done (epiphany-extensions: FTBFS
(amd64/gcc-4.0): pointer targets in passing argument 1 of 'DashboardSendCluePacket'
differ in signedness)
Debian Bug Tracking System
owner@bugs.debian.org
Wed, 09 Mar 2005 01:48:06 -0800
Your message dated Wed, 09 Mar 2005 04:32:04 -0500
with message-id <E1D8xXw-0002Ew-00@newraff.debian.org>
and subject line Bug#290309: fixed in epiphany-extensions 1.4.5-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 13 Jan 2005 14:40:39 +0000
>From aj@andaco.de Thu Jan 13 06:40:39 2005
Return-path: <aj@andaco.de>
Received: from c173060.adsl.hansenet.de (localhost.localdomain) [213.39.173.60]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Cp69O-00077g-00; Thu, 13 Jan 2005 06:40:38 -0800
Received: from aj by localhost.localdomain with local (Exim 4.34)
id 1Cp69N-0001MU-7B; Thu, 13 Jan 2005 15:40:37 +0100
To: Debian Bug Tracking System <submit@bugs.debian.org>
From: Andreas Jochens <aj@andaco.de>
Subject: epiphany-extensions: FTBFS (amd64/gcc-4.0): pointer targets in passing argument 1 of 'DashboardSendCluePacket' differ in signedness
Message-Id: <E1Cp69N-0001MU-7B@localhost.localdomain>
Date: Thu, 13 Jan 2005 15:40:37 +0100
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: epiphany-extensions
Severity: normal
Tags: patch
When building 'epiphany-extensions' on amd64 with gcc-4.0,
I get the following error:
cc1: warnings being treated as errors
ephy-dashboard-extension.c: In function 'load_status_cb':
ephy-dashboard-extension.c:151: warning: pointer targets in passing argument 1 of 'DashboardSendCluePacket' differ in signedness
ephy-dashboard-extension.c:151: warning: pointer targets in passing argument 3 of 'DashboardSendCluePacket' differ in signedness
ephy-dashboard-extension.c:165: warning: pointer targets in passing argument 1 of 'DashboardSendCluePacket' differ in signedness
ephy-dashboard-extension.c:165: warning: pointer targets in passing argument 3 of 'DashboardSendCluePacket' differ in signedness
make[4]: *** [ephy-dashboard-extension.lo] Error 1
make[4]: Leaving directory `/epiphany-extensions-1.4.4/extensions/dashboard'
With the attached patch 'epiphany-extensions' can be compiled
on amd64 using gcc-4.0.
Regards
Andreas Jochens
diff -urN ../tmp-orig/epiphany-extensions-1.4.4/extensions/dashboard/dashboard-frontend-xmlwriter.c ./extensions/dashboard/dashboard-frontend-xmlwriter.c
--- ../tmp-orig/epiphany-extensions-1.4.4/extensions/dashboard/dashboard-frontend-xmlwriter.c 2004-09-26 18:22:39.000000000 +0200
+++ ./extensions/dashboard/dashboard-frontend-xmlwriter.c 2005-01-13 14:58:46.000000000 +0100
@@ -163,17 +163,17 @@
ret = xmlTextWriterStartDocument (writer, NULL, NULL, NULL);
if (ret < 0) goto error;
- ret = xmlTextWriterStartElement (writer, "CluePacket");
+ ret = xmlTextWriterStartElement (writer, (unsigned char*) "CluePacket");
if (ret < 0) goto error;
- ret = xmlTextWriterWriteElement (writer, "Frontend", frontend);
+ ret = xmlTextWriterWriteElement (writer, (unsigned char*) "Frontend", frontend);
if (ret < 0) goto error;
- ret = xmlTextWriterWriteElement (writer, "Context", context);
+ ret = xmlTextWriterWriteElement (writer, (unsigned char*) "Context", context);
if (ret < 0) goto error;
- ret = xmlTextWriterWriteElement (writer, "Focused",
- focused ? "true" : "false");
+ ret = xmlTextWriterWriteElement (writer, (unsigned char*) "Focused",
+ focused ? (unsigned char*) "true" : (unsigned char*) "false");
if (ret < 0) goto error;
error:
@@ -216,13 +216,13 @@
if (!writer)
return -1;
- ret = xmlTextWriterStartElement (writer, "Clue");
+ ret = xmlTextWriterStartElement (writer, (unsigned char*) "Clue");
if (ret < 0) return ret;
- ret = xmlTextWriterWriteAttribute (writer, "Type", type);
+ ret = xmlTextWriterWriteAttribute (writer, (unsigned char*) "Type", type);
if (ret < 0) return ret;
- ret = xmlTextWriterWriteFormatAttribute (writer, "Relevance", "%d", relevance);
+ ret = xmlTextWriterWriteFormatAttribute (writer, (unsigned char*) "Relevance", "%d", relevance);
if (ret < 0) return ret;
ret = xmlTextWriterWriteString (writer, text);
diff -urN ../tmp-orig/epiphany-extensions-1.4.4/extensions/dashboard/ephy-dashboard-extension.c ./extensions/dashboard/ephy-dashboard-extension.c
--- ../tmp-orig/epiphany-extensions-1.4.4/extensions/dashboard/ephy-dashboard-extension.c 2004-09-26 18:22:39.000000000 +0200
+++ ./extensions/dashboard/ephy-dashboard-extension.c 2005-01-13 14:52:56.000000000 +0100
@@ -142,9 +142,9 @@
g_object_unref (persist);
DashboardSendCluePacket (
- EPIPHANY_FRONTEND_IDENTIFIER,
+ (unsigned char*) EPIPHANY_FRONTEND_IDENTIFIER,
ephy_tab_get_visibility(tab), /* focused */
- location, /* context */
+ (unsigned char*) location, /* context */
location, "url", 10,
page_title, "title", 10,
content, "htmlblock", 10,
@@ -157,9 +157,9 @@
LOG ("Page not bookmarked, sending only location and title")
DashboardSendCluePacket (
- EPIPHANY_FRONTEND_IDENTIFIER,
+ (unsigned char*) EPIPHANY_FRONTEND_IDENTIFIER,
ephy_tab_get_visibility(tab), /* focused */
- location, /* context */
+ (unsigned char*) location, /* context */
location, "url", 10,
page_title, "title", 10,
NULL);
diff -urN ../tmp-orig/epiphany-extensions-1.4.4/extensions/error-viewer/sgml-validator.c ./extensions/error-viewer/sgml-validator.c
--- ../tmp-orig/epiphany-extensions-1.4.4/extensions/error-viewer/sgml-validator.c 2004-10-11 19:27:11.000000000 +0200
+++ ./extensions/error-viewer/sgml-validator.c 2005-01-13 14:59:29.000000000 +0100
@@ -328,7 +328,7 @@
{
const char *dest;
char *location;
- char *dest_utf8;
+ char *dest_utf8 = 0;
gboolean is_xml;
unsigned int num_errors = 0;
OpenSPThreadCBData *data;
diff -urN ../tmp-orig/epiphany-extensions-1.4.4/extensions/gestures/ephy-gestures-extension.c ./extensions/gestures/ephy-gestures-extension.c
--- ../tmp-orig/epiphany-extensions-1.4.4/extensions/gestures/ephy-gestures-extension.c 2004-09-26 18:22:39.000000000 +0200
+++ ./extensions/gestures/ephy-gestures-extension.c 2005-01-13 15:15:13.107628353 +0100
@@ -116,13 +116,13 @@
for (child = node->children; child != NULL; child = child->next)
{
- if (xmlStrEqual (child->name, "sequence"))
+ if (xmlStrEqual (child->name, (unsigned char*) "sequence"))
{
s = xmlNodeGetContent (child);
sequences = g_slist_prepend (sequences, s);
}
- else if (xmlStrEqual (child->name, "action"))
+ else if (xmlStrEqual (child->name, (unsigned char*) "action"))
{
if (action == NULL)
{
@@ -145,7 +145,7 @@
{
g_hash_table_insert (extension->priv->gestures,
g_strdup (l->data),
- g_strdup (action));
+ g_strdup ((char*)action));
xmlFree (l->data);
}
@@ -175,7 +175,7 @@
}
root = xmlDocGetRootElement (doc);
- if (root == NULL || strcmp (root->name, EPHY_GESTURES_XML_ROOT) != 0)
+ if (root == NULL || strcmp ((char*)root->name, EPHY_GESTURES_XML_ROOT) != 0)
{
g_warning ("Gestures definitions file %s has wrong format '%s'"
"(expected " EPHY_GESTURES_XML_ROOT ")\n",
@@ -183,8 +183,8 @@
goto out;
}
- tmp = xmlGetProp (root, "version");
- if (tmp == NULL || strcmp (tmp, EPHY_GESTURES_XML_VERSION) != 0)
+ tmp = xmlGetProp (root, (unsigned char*) "version");
+ if (tmp == NULL || strcmp ((char*) tmp, (char*) EPHY_GESTURES_XML_VERSION) != 0)
{
g_warning ("Gestures definitions file %s has wrong format version %s"
"(expected " EPHY_GESTURES_XML_VERSION ")\n",
@@ -194,7 +194,7 @@
for (child = root->children; child != NULL; child = child->next)
{
- if (xmlStrEqual (child->name, "gesture"))
+ if (xmlStrEqual (child->name, (unsigned char*) "gesture"))
{
load_one_gesture (extension, child);
}
diff -urN ../tmp-orig/epiphany-extensions-1.4.4/extensions/sidebar/ephy-sidebar-embed.c ./extensions/sidebar/ephy-sidebar-embed.c
--- ../tmp-orig/epiphany-extensions-1.4.4/extensions/sidebar/ephy-sidebar-embed.c 2004-09-28 13:03:21.000000000 +0200
+++ ./extensions/sidebar/ephy-sidebar-embed.c 2005-01-13 15:14:05.929596122 +0100
@@ -144,7 +144,7 @@
{
EphyEmbedEvent *event = (EphyEmbedEvent *) user_data;
- ephy_embed_event_get_coords (event, x, y);
+ ephy_embed_event_get_coords (event, (guint*) x, (guint*) y);
*push_in = TRUE;
}
diff -urN ../tmp-orig/epiphany-extensions-1.4.4/extensions/sidebar/ephy-sidebar-extension.c ./extensions/sidebar/ephy-sidebar-extension.c
--- ../tmp-orig/epiphany-extensions-1.4.4/extensions/sidebar/ephy-sidebar-extension.c 2004-09-28 12:58:37.000000000 +0200
+++ ./extensions/sidebar/ephy-sidebar-extension.c 2005-01-13 15:12:45.298159799 +0100
@@ -603,8 +603,8 @@
ephy_node_db_load_from_file (extension->priv->db,
extension->priv->xml_file,
- EPHY_SIDEBARS_XML_ROOT,
- EPHY_SIDEBARS_XML_VERSION);
+ (unsigned char*) EPHY_SIDEBARS_XML_ROOT,
+ (unsigned char*) EPHY_SIDEBARS_XML_VERSION);
if (ephy_node_get_n_children (extension->priv->state_parent))
{
@@ -634,9 +634,9 @@
ephy_node_db_write_to_xml_safe
(extension->priv->db,
- extension->priv->xml_file,
- EPHY_SIDEBARS_XML_ROOT,
- EPHY_SIDEBARS_XML_VERSION,
+ (unsigned char*) extension->priv->xml_file,
+ (unsigned char*) EPHY_SIDEBARS_XML_ROOT,
+ (unsigned char*) EPHY_SIDEBARS_XML_VERSION,
NULL,
extension->priv->sidebars, 0,
extension->priv->state_parent, 0,
---------------------------------------
Received: (at 290309-close) by bugs.debian.org; 9 Mar 2005 09:38:12 +0000
>From katie@ftp-master.debian.org Wed Mar 09 01:38:12 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D8xds-0000fX-00; Wed, 09 Mar 2005 01:38:12 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1D8xXw-0002Ew-00; Wed, 09 Mar 2005 04:32:04 -0500
From: Jordi Mallach <jordi@debian.org>
To: 290309-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#290309: fixed in epiphany-extensions 1.4.5-1
Message-Id: <E1D8xXw-0002Ew-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 09 Mar 2005 04:32:04 -0500
Delivered-To: 290309-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: epiphany-extensions
Source-Version: 1.4.5-1
We believe that the bug you reported is fixed in the latest version of
epiphany-extensions, which is due to be installed in the Debian FTP archive:
epiphany-extensions_1.4.5-1.diff.gz
to pool/main/e/epiphany-extensions/epiphany-extensions_1.4.5-1.diff.gz
epiphany-extensions_1.4.5-1.dsc
to pool/main/e/epiphany-extensions/epiphany-extensions_1.4.5-1.dsc
epiphany-extensions_1.4.5-1_i386.deb
to pool/main/e/epiphany-extensions/epiphany-extensions_1.4.5-1_i386.deb
epiphany-extensions_1.4.5.orig.tar.gz
to pool/main/e/epiphany-extensions/epiphany-extensions_1.4.5.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 290309@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jordi Mallach <jordi@debian.org> (supplier of updated epiphany-extensions package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 9 Mar 2005 02:28:01 +0100
Source: epiphany-extensions
Binary: epiphany-extensions
Architecture: source i386
Version: 1.4.5-1
Distribution: unstable
Urgency: low
Maintainer: Jordi Mallach <jordi@debian.org>
Changed-By: Jordi Mallach <jordi@debian.org>
Description:
epiphany-extensions - Extensions for Epiphany web browser
Closes: 290309
Changes:
epiphany-extensions (1.4.5-1) unstable; urgency=low
.
* The "London Calling" release.
* New upstream release.
* debian/patches/01_gcc40_signedness.patch: patch from Andreas Jochens,
with modifications by Christian Persch to fix compilation on amd64
using gcc-4.0 (closes: #290309).
Files:
016d9a5112181cf3602bd3076ede7ceb 1787 gnome optional epiphany-extensions_1.4.5-1.dsc
1b4ae8b31dfb33f8373da0f162c756ea 702349 gnome optional epiphany-extensions_1.4.5.orig.tar.gz
87cab795d75215cb30c365cccfad366d 25026 gnome optional epiphany-extensions_1.4.5-1.diff.gz
ba82e53c93613226e6e082ec3df0bd59 167046 gnome optional epiphany-extensions_1.4.5-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCLr31JYSUupF6Il4RAoE7AKCl1SHXca2yH4/8JkPI48/FKwhuuACgjSso
2gQN8CUb0Rq6vSTPnpVCjVY=
=hNo+
-----END PGP SIGNATURE-----