[Bug 452063] Does not retain volume level between videos

[totem (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=452063

  totem | Browser plugin | Ver: 2.18.x




------- Comment #5 from Christian Persch (IRC: chpe)  2007-08-15 22:53 UTC -------
(In reply to comment #4)
> (In reply to comment #3)
> > Does the function on the plugin side actually get called?
> > dbus_g_proxy_call_with_timeout invokes the method async when the programme
> > returns to the mainloop, and by that time we'll already have killed the
> > viewer...
> 
> It did in my (short) tests. I was hoping it was a sync method for which we'd
> keep a _short_ timeout. The downside being that it might hang if the program
> hangs for whatever reason, but it's only for a very short time.

Actually you're right, it's sync. I was looking at the wrong function in the
API docs. That explains that it's actually calling the remote method.

We really shouldn't be running a recursive mainloop from plugin code. I didn't
rewrite the whole plugin to be async for nothing :)

It will hang the programme for 1) a short time _per plugin_ (there may be many
many plugins on the page), 2) is a security hole (you don't push a null JS
context on the stack), and 3) will cause the weirdest crashes.

> It's either that or updating gconf each time the volume is changed. What do you
> think is best?

In that case, update the gconf key when the volume changes. 

Or alternatively, don't kill the viewer, and just invoke a "quit" method? (That
might fail however if the whole browser is quitting and thus we never enter the
mainloop again to send the method invocation.)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=452063.