Bug#490224: gnome-games: The default value for the name entry in the high scores is always empty
Morita Sho
morita-pub-en-debian at inz.sakura.ne.jp
Thu Jul 10 20:15:45 UTC 2008
Package: gnome-games
Version: 1:2.22.3-1
Severity: normal
Tags: patch
Hi,
The default value for the name entry in the high scores is always empty for me.
It seems that the problem is gnome games get the user name using g_get_real_name() function.
Unfortunately, g_get_real_name() returns empty string when the 5th field of passwd entry is empty.
gnome-games-2.22.3/libgames-support/games-score.c:
GamesScore *
games_score_new (void)
{
GamesScore *newscore;
newscore = g_slice_new0 (GamesScore);
newscore->time = time (NULL);
/* FIXME: We don't handle the "Unknown" case. */
newscore->name = g_strdup (g_get_real_name ()); <== will be empty when the 5th field of passwd entry is empty
return newscore;
}
It would be great if gnome games get the user name using g_get_user_name() when
g_get_real_name() returned empty string.
A patch is attached.
Regards,
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.25-2-686 (SMP w/1 CPU core)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages gnome-games depends on:
ii gnome-games-data 1:2.22.3-1 data files for the GNOME games
ii gnuchess 5.07-4.1 Plays a game of chess, either agai
ii guile-1.8-libs 1.8.5+1-1 Main Guile libraries
ii libatk1.0-0 1.22.0-1 The ATK accessibility toolkit
ii libc6 2.7-12 GNU C Library: Shared libraries
ii libcairo2 1.6.4-6 The Cairo 2D vector graphics libra
ii libgcc1 1:4.3.1-6 GCC support library
ii libgconf2-4 2.22.0-1 GNOME configuration database syste
ii libggz2 0.0.14.1-1 GGZ Gaming Zone: common utilities
ii libggzcore9 0.0.14.1-1 GGZ Gaming Zone: core client front
ii libggzmod4 0.0.14.1-1 GGZ Gaming Zone: game frontend lib
ii libglib2.0-0 2.16.4-1 The GLib library of C routines
ii libgnome2-0 2.20.1.1-1 The GNOME 2 library - runtime file
ii libgnomeui-0 2.20.1.1-1 The GNOME 2 libraries (User Interf
ii libgnomevfs2-0 1:2.22.0-4 GNOME Virtual File System (runtime
ii libgstreamer0.10-0 0.10.20-1 Core GStreamer libraries and eleme
ii libgtk2.0-0 2.12.11-1 The GTK+ graphical user interface
ii libpango1.0-0 1.20.5-1 Layout and rendering of internatio
ii librsvg2-2 2.22.2-2 SAX-based renderer library for SVG
ii librsvg2-common 2.22.2-2 SAX-based renderer library for SVG
ii libstdc++6 4.3.1-6 The GNU Standard C++ Library v3
ii libx11-6 2:1.1.4-2 X11 client-side library
ii libxml2 2.6.32.dfsg-2 GNOME XML library
ii python 2.5.2-1 An interactive high-level object-o
ii python-gnome2 2.22.0-1 Python bindings for the GNOME desk
ii python-gnome2-desktop 2.22.0-2 Python bindings for the GNOME desk
ii python-gtk2 2.12.1-6 Python bindings for the GTK+ widge
ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime
Versions of packages gnome-games recommends:
ii gnome-games-extra-data 2.22.0-1 games for the GNOME desktop (extra
pn python-gtkglext1 <none> (no description available)
pn python-opengl <none> (no description available)
-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnome-games-2.22.3_using-login-name-when-real-name-is-empty.patch
Type: text/x-c
Size: 726 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20080711/26477067/attachment.bin
More information about the pkg-gnome-maintainers
mailing list