Bug#684215: gnotravex: says score is in the top ten when it's not

[Julien Cristau]

Package: gnotravex
Version: 1:3.4.2-2
Severity: normal
Tags: patch

at the end of the game gnotravex either says your score is the best, or
you made the top ten.  Untested patch follows.

--- gnotravex/src/gnotravex.vala.orig	2012-08-07 23:15:40.000000000 +0200
+++ gnotravex/src/gnotravex.vala	2012-08-07 23:14:27.000000000 +0200
@@ -196,9 +196,15 @@
         var pos = highscores.add_time_score ((seconds / 60) * 1.0 + (seconds % 60) / 100.0);
 
         var scores_dialog = new GnomeGamesSupport.ScoresDialog (window, highscores, _("Tetravex Scores"));
+        var message = _("You didn't make the top ten, better luck next time.");
         scores_dialog.set_category_description (_("Size:"));
-        scores_dialog.set_hilight (pos);
-        scores_dialog.set_message ("<b>%s</b>\n\n%s".printf (_("Congratulations!"), pos == 1 ? _("Your score is the best!") : _("Your score has made the top ten.")));
+        if (pos > 0)
+            scores_dialog.set_hilight (pos);
+            if (pos == 1)
+                message = _("Your score is the best!");
+            else
+                message = _("Your score has made the top ten.");
+        scores_dialog.set_message ("<b>%s</b>\n\n%s".printf (_("Congratulations!"), message));
         scores_dialog.set_buttons (GnomeGamesSupport.ScoresButtons.QUIT_BUTTON | GnomeGamesSupport.ScoresButtons.NEW_GAME_BUTTON);
         if (scores_dialog.run () == Gtk.ResponseType.REJECT)
             window.destroy ();

Cheers,
Julien

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'unstable'), (500, 'stable'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gnotravex depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.12.1-2
ii  gnome-games-data                             1:3.4.2-2
ii  libc6                                        2.13-35
ii  libcairo2                                    1.12.2-2
ii  libglib2.0-0                                 2.32.3-1
ii  libgtk-3-0                                   3.4.2-2

gnotravex recommends no packages.

gnotravex suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20120807/0f70042b/attachment.pgp>