Bug#701648: Feedback on your update to seahorse 3.6.3 for experimental

[Andreas Henriksson]

Hello Thomas Bechtold!

Seems like my comments on IRC maybe didn't reach you so following up
with an email.

I've looked at your changes in the patch you sent to debian bug #701648
and committed them to pkg-gnome svn and uploaded a the new version
to experimental.

Some minor feedback:

you dropped three patches from debian/paches/series but forgot
to actually drop the patches themselves.

the changelog said you updated debian/control but you actually
updated debian/control.in and you didn't fakeroot debian/rules clean
to update debian/control ...

some of your comments in debian/control could have been been written
to explain WHY you changed something (rather then WHAT which is available
in the diff itself).

All of the above is pretty small details, but there's one last thing that's
more important....

Please always build in a clean build environment (ie. use cowbuilder)!

Your update failed to build because of a missing build-dependency on 
yelp-tools (which caused the macro in help/Makefile to not be replaces).

Thanks for your contribution! For the future you might want to apply
for commit access yourself! Talk to pochu, sjoerd or joss on irc!

-- 
Andreas Henriksson