Bug#780205: patch - fix crash with long one-line XML documents

Vlad Orlov monsta at inbox.ru
Tue Mar 10 14:21:31 UTC 2015


Source: gtksourceview2
Version: 2.10.5-2
Severity: important
Tags: jessie sid patch upstream
Control: forwarded -1 https://bugzilla.gnome.org/show_bug.cgi?id=607677
Control: affects -1 pluma


Steps to reproduce:

1. Open a long one-line XML document (e.g. [1]) with Pluma. Any other editor
   using gtksourceview2 will also fit I think.
2. Select a portion of text.
3. Press Backspace (or Delete) key.
4. Pluma crashes. The full backtrace is at [2].

If you're running Pluma from the command-line, you'll notice a warning:
GtkSourceView-CRITICAL **: Highlighting a single line took too much time, syntax highlighting will be disabled

That's the key. The library tries to invalidate the region when text is deleted
and the engine is disabled (i.e. syntax highlighting is off). This has been
reported upstream and fixed in [3], but the commit never made it to GTK+2
version of gtksourceview.

I've made a patch from that commit, it applies cleanly to the current version
of gtksourceview2 in Jessie and actually fixes the crash.

The debdiff is in the attachment.
Hope to see it accepted soon. Thanks in advance.


[1] http://pastebin.com/nNdYzFXE
[2] http://pastebin.com/YgDT0iKh
[3] https://git.gnome.org/browse/gtksourceview/commit/?id=abef41da8c541c814bf631f69c92e0c431c610ad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gsv-debdiff
Type: application/octet-stream
Size: 4045 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20150310/b7a7cd0c/attachment.obj>


More information about the pkg-gnome-maintainers mailing list