Bug#839122: Old GTK+ 3 Debian/Ubuntu patch causes Critical Warning every time a GtkComboBox is opened

[D. B.]

On Fri, Dec 9, 2016 at 8:40 PM, Michael Biebl <biebl at debian.org> wrote:

> Hi Daniel
>
>
> I see that you've been working with upstream, trying to resolve this.
> Thanks a lot for that.
> The latest stable release 3.22.5, contains your patches.
>
> What's unclear to me is whether your patches replace the above two
> patches and we can drop them now, or if we still need them (for
> Ubuntu/Unity).
> I've CCed William, from the Ubuntu side. Maybe you can confirm, that
> those patches are safe to drop now or if they are still needed.
>
> Regards,
> Michael
>
>
Hi Michael,

It took a while, but we got there in the end. :) I'm glad to have done my
bit to help, and to get William's fix into 3.22.

William's and my patches only resolve assertion failures, which were in
part revealed by the Debian patches to prevent offscreen grabs:

William's patch fixed an oversight in GtkCellRendererCombo, where the
trigger event was not passed and failed an upstream assertion. This was
forgotten for cherry-picking to 3.22, so I did that as part of merging my
patch from master. My patch was for a parallel issue: some dodgy ordering
of menu grab vs realise in GtkComboBox (with particular sets of properties)
- which caused an assertion in Debian patch 016 to fail.

So, if you want to prevent offscreen grabs, currently patches 016 and 017
seem to be still required. Near or identical patches are submitted
upstream, and reviewed quite positively, but they don't seem to have gone
any further than that. Maybe you'd like to request an update there?

https://bugzilla.gnome.org/show_bug.cgi?id=658563

That's the thread with a reviewed patch against offscreen grabs for both
widgets and devices, which AFAICT would cover both patches 016 and 017. It
might be worth asking for an update, now that it wouldn't generate errors
on Debian et al if merged.

Cheers!
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20161209/3b57d4dd/attachment-0001.html>