[pkg-go] RFS: golang-protobuf-extensions patch to disable failing test

Potter, Tim (HPE Linux Support) timothy.potter at hpe.com
Tue Apr 5 01:35:28 UTC 2016


On 5 Apr 2016, at 10:01 AM, Dmitry Smirnov <onlyjob at debian.org> wrote:
> 
> On Monday, 4 April 2016 11:10:51 PM AEST Potter, Tim (HPE Linux Support)
> wrote:
>> Hi again.  I've made a small patch to golang-protobuf-extensions to allow
>> it to be built under the version of Go currently in stretch.  According to
>> the github issue tracker it's a known problem with Go 1.5 and higher, but
>> has not been fixed at this stage.  I've even added a DEP3 header recording
>> this info.
> 
> Tim, removing file(s) using patches is unmaintainable and tend to break on
> slightest changes. I recommend adding file you want to remove to "debian/
> clien" with relevant comments from patch header. I hope it make sense.

Hi Dmitry.  I'm only removing one of the tests out of this file - about 40 lines
out of 320 so a bit over 10%.  I thought that would be OK.

What do you mean by "debian/clien"?  If there's a better way of removing
entire files (because that does happen occasionally, especially with tests)
I'm happy to do that in preference to a patch.


Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20160405/75800917/attachment.sig>


More information about the Pkg-go-maintainers mailing list