Bug#841408: otb: FTBFS: error with opencv 3.1

[Nobuhiro Iwamatsu]

Source: otb
Version: 5.6.1+dfsg-1
Severity: important
Justification: fails to build from source

Dear Maintainer,

I am scheduled to transition of opencv.
   https://release.debian.org/transitions/html/auto-opencv.html
This package is target to transition. I tested build with opencv 3.1.
As a result, FTBFS with opencv 3.1.

-----
[ 48%] Building CXX object
Modules/Learning/Supervised/src/CMakeFiles/OTBSupervised.dir/otbCvRTreesWrapper.cxx.o
cd /build/otb-5.6.1+dfsg/obj-x86_64-linux-gnu/Modules/Learning/Supervised/src
&& /usr/bin/c++   -DOTBSupervised_EXPORTS
-I/build/otb-5.6.1+dfsg/Modules/ThirdParty/Boost/src
-I/usr/include/gdal
-I/build/otb-5.6.1+dfsg/Modules/ThirdParty/ITK/include -isystem
/usr/include/ITK-4.10
-I/build/otb-5.6.1+dfsg/obj-x86_64-linux-gnu/Modules/Core/Common
-I/build/otb-5.6.1+dfsg/Modules/Core/Common/include
-I/build/otb-5.6.1+dfsg/Modules/Adapters/BoostAdapters/include
-I/usr/include/geotiff
-I/build/otb-5.6.1+dfsg/Modules/ThirdParty/OssimPlugins/src
-I/build/otb-5.6.1+dfsg/Modules/ThirdParty/OssimPlugins/src/ossim
-I/build/otb-5.6.1+dfsg/Modules/Adapters/OSSIMAdapters/include
-I/build/otb-5.6.1+dfsg/Modules/Core/ObjectList/include
-I/build/otb-5.6.1+dfsg/Modules/Core/Metadata/include
-I/build/otb-5.6.1+dfsg/Modules/Core/ImageBase/include -isystem
/usr/include/opencv
-I/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/include  -g -O2
-fdebug-prefix-map=/build/otb-5.6.1+dfsg=. -fPIE
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2   -Wall -Wcast-align -Wdisabled-optimization
-Wextra -Wformat=2 -Winvalid-pch -Wno-format-nonliteral
-Wpointer-arith -Wshadow -Wunused -Wwrite-strings -funit-at-a-time
-Wno-strict-overflow -Wno-deprecated -Wno-invalid-offsetof
-Woverloaded-virtual -Wstrict-null-sentinel   -O3 -DNDEBUG -fPIC   -o
CMakeFiles/OTBSupervised.dir/otbCvRTreesWrapper.cxx.o -c
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx
In file included from
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:18:0:
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/include/otbCvRTreesWrapper.h:33:1:
error: expected class-name before '{' token
 {
 ^
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/include/otbCvRTreesWrapper.h:37:3:
error: 'otb::CvRTreesWrapper::~CvRTreesWrapper()' marked 'override',
but does not override
   ~CvRTreesWrapper() ITK_OVERRIDE;
   ^
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:
In member function 'void otb::CvRTreesWrapper::get_votes(const
cv::Mat&, const cv::Mat&, otb::CvRTreesWrapper::VotesVectorType&)
const':
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:33:21:
error: 'nclasses' was not declared in this scope
   vote_count.resize(nclasses);
                     ^~~~~~~~
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:34:23:
error: 'ntrees' was not declared in this scope
   for( int k = 0; k < ntrees; k++ )
                       ^~~~~~
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:36:5:
error: 'CvDTreeNode' was not declared in this scope
     CvDTreeNode* predicted_node = trees[k]->predict( sample, missing );
     ^~~~~~~~~~~
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:36:18:
error: 'predicted_node' was not declared in this scope
     CvDTreeNode* predicted_node = trees[k]->predict( sample, missing );
                  ^~~~~~~~~~~~~~
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:36:35:
error: 'trees' was not declared in this scope
     CvDTreeNode* predicted_node = trees[k]->predict( sample, missing );
                                   ^~~~~
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:
In member function 'float otb::CvRTreesWrapper::predict_margin(const
cv::Mat&, const cv::Mat&) const':
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:47:6:
error: 'ntrees' was not declared in this scope
   if(ntrees == 0)
      ^~~~~~
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:56:66:
error: 'ntrees' was not declared in this scope
   float margin = static_cast<float>(classVotes[0]-classVotes[1])/ntrees;
                                                                  ^~~~~~
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:
In member function 'float
otb::CvRTreesWrapper::predict_confidence(const cv::Mat&, const
cv::Mat&) const':
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:64:6:
error: 'ntrees' was not declared in this scope
   if(ntrees == 0)
      ^~~~~~
/build/otb-5.6.1+dfsg/Modules/Learning/Supervised/src/otbCvRTreesWrapper.cxx:72:52:
error: 'ntrees' was not declared in this scope
   float confidence = static_cast<float>(max_votes)/ntrees;
                                                    ^~~~~~
Modules/Learning/Supervised/src/CMakeFiles/OTBSupervised.dir/build.make:89:
recipe for target
'Modules/Learning/Supervised/src/CMakeFiles/OTBSupervised.dir/otbCvRTreesWrapper.cxx.o'
failed
make[3]: *** [Modules/Learning/Supervised/src/CMakeFiles/OTBSupervised.dir/otbCvRTreesWrapper.cxx.o]
Error 1

-----

Could you check your package?

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6
-------------- next part --------------
A non-text attachment was scrubbed...
Name: otb_5.6.1+dfsg-1_amd64.build.bz2
Type: application/x-bzip2
Size: 32919 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-grass-devel/attachments/20161020/5f6d70fc/attachment-0001.bin>