[Pkg-iscsi-maintainers] Bug#836135: umountiscsi.sh indiscriminately umounts all LVM based filesystems when no iSCSI sessions are found.

[Frank Fegert]

Hello Christian,

sorry for the delayed reply!

On Wed, Aug 31, 2016 at 11:18:41PM +0200, Christian Seiler wrote:
> I haven't had time to test it yet (might even still have shell
> syntax errors), but I've come up with the following:
> 
> get_lvm_vgs() {
>         # handle the case where we didn't get passed any PVs
>         # at all
>         [ $# -gt 0 ] || return
>         # subshell for pwd change
>         (
>                 cd /dev
>                 $PVS --noheadings -o vg_name "$@" 2>/dev/null
>         )
> }
> 
> and later:
> 
> for _vg in $(get_lvm_vgs $iscsi_disks $iscsi_partitions $iscsi_multipath_disks $iscsi_multipath_partitions) $LVMGROUPS ; do
> 
> Will do some tests in the next couple of days and upload a
> fixed version.

Also not testet, this looks reasonable. 

> Ok, then I'll see to that. I'll have to talk to Ritesh (the other
> co-maintainer of open-iscsi) first, and probably want to clarify
> something with the backports ftp-masters, so it might take a couple
> of weeks until it's in, but if you want, I can notify you via email
> once I've created the corresponding packages, even if they are
> stuck in the NEW queue for a while.

Yes please, that would be great.

> As for "recent-ness" of backports: the rules for jessie-backports
> are that Stretch has to be tracked. Since open-iscsi with iscsiuio
> will migrate to Stretch tomorrow (barring a last-minute RC bug),
> that's going to be the lowest possible version that's going to
> land in backports. And until Stretch is released, jessie-backports
> would get all further improvements. (Though to be honest, I don't
> see that many major changes happening until Stretch; iscsiuio and
> the earlier rework of the startup logic were the big ones on my
> list, and those are done.)

Ok, can i instead ask to please add this upstream commit:
  https://github.com/open-iscsi/open-iscsi/commit/efdd487c70269749f03be8342c4fde8fd3b59f8a

as a patch to the stretch/jessie-backports package? It's a really
annoying bug that may or may not be triggered. For me it triggered
on Intel E5 v4 based systems, but wouldn't show up on Intel E5 v3
based systems :-(
 
> > and still having to tweak the multipath init script.
> 
> Could you be more specific here? What exactly do you need to do?
> I still have an item on my TODO list to take a look at multipath
> vs. iSCSI in Jessie (in Stretch it works), because there was a
> bug report on debian-user about it - I just didn't manage to do
> so yet. If you are using that and have already looked into it,
> it would be great, then I could probably try to also get that
> sorted. (No guarantees for 8.6 though, because that'll happen on
> Sep. 17th, so the time window is a bit short there.)

Sorry, i had a wrong memory of this - probably too many tests and
workarounds that in the end didn't quite work. The issue with multi-
path wasn't with the init script itself, but actually the one de-
scribed here:
  https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/1431650
  https://github.com/hreinecke/multipath-tools/commit/841977fc9c3432702c296d6239e4a54291a6007a

Once i added the above patch to a otherwise standard jessie multi-
path package, the issues on boot disappeared. This worked even
with the old version of activate-storage.sh script:
  https://github.com/frank-fegert/debian_open-iscsi/blob/master/debian/extra/activate-storage.sh

Thanks & best regards,

    Frank