[codenarc] 03/06: Merge tag 'upstream/0.23'

Emmanuel Bourg ebourg-guest at moszumanska.debian.org
Fri Nov 20 10:27:07 UTC 2015


This is an automated email from the git hooks/post-receive script.

ebourg-guest pushed a commit to branch master
in repository codenarc.

commit 4e46a2f4cd96d954a90268d5c78f4b4e53826638
Merge: 3a572b3 9e64f41
Author: Emmanuel Bourg <ebourg at apache.org>
Date:   Fri Nov 20 11:18:59 2015 +0100

    Merge tag 'upstream/0.23'
    
    Upstream version 0.23

 CHANGELOG.txt                                      | 1928 +++++++++-------
 README.txt                                         |    5 +-
 docs/SampleCodeNarcHtmlReport.html                 |    2 +-
 docs/codenarc-HtmlReportWriter.html                |  640 +++---
 docs/codenarc-TextReportWriter.html                |  652 +++---
 docs/codenarc-XmlReportWriter.html                 |  630 +++---
 docs/codenarc-ant-task.html                        |  717 +++---
 docs/codenarc-command-line.html                    |  687 +++---
 docs/codenarc-configuring-rules.html               |  739 +++---
 docs/codenarc-creating-rule.html                   |  648 +++---
 docs/codenarc-creating-ruleset.html                |  803 +++----
 docs/codenarc-developer-guide.html                 |  631 +++---
 docs/codenarc-enhanced-classpath-rules.html        |  258 +++
 docs/codenarc-opensource-projects.html             |  377 ----
 docs/codenarc-other-tools-frameworks.html          |  615 +++--
 docs/codenarc-roadmap.html                         |  609 +++--
 docs/codenarc-rule-index.html                      | 1339 ++++++-----
 docs/codenarc-rules-basic.html                     | 1067 +++++----
 docs/codenarc-rules-braces.html                    |  619 +++--
 docs/codenarc-rules-concurrency.html               |  888 ++++----
 docs/codenarc-rules-convention.html                |  710 +++---
 docs/codenarc-rules-design.html                    |  861 +++----
 docs/codenarc-rules-dry.html                       |  699 +++---
 docs/codenarc-rules-enhanced.html                  |  276 +++
 docs/codenarc-rules-exceptions.html                |  740 +++---
 docs/codenarc-rules-formatting.html                | 1022 ++++++---
 docs/codenarc-rules-generic.html                   |  887 ++++----
 docs/codenarc-rules-grails.html                    |  784 ++++---
 docs/codenarc-rules-groovyism.html                 |  837 ++++---
 docs/codenarc-rules-imports.html                   |  641 +++---
 docs/codenarc-rules-jdbc.html                      |  608 +++--
 docs/codenarc-rules-junit.html                     |  942 ++++----
 docs/codenarc-rules-logging.html                   |  652 +++---
 docs/codenarc-rules-naming.html                    |  975 ++++----
 docs/codenarc-rules-security.html                  |  672 +++---
 docs/codenarc-rules-serialization.html             |  631 +++---
 docs/codenarc-rules-size.html                      |  982 ++++----
 docs/codenarc-rules-unnecessary.html               | 1162 +++++-----
 docs/codenarc-rules-unused.html                    |  696 +++---
 docs/codenarc-run-as-a-test.html                   |  602 +++--
 docs/cpd.html                                      |  655 +++---
 docs/css/maven-base.css                            |  298 +--
 docs/css/maven-theme.css                           |  302 ++-
 docs/css/print.css                                 |   14 +-
 docs/images/forkme_right_red_aa0000.png            |  Bin 0 -> 7927 bytes
 docs/images/getit.png                              |  Bin 14382 -> 15064 bytes
 docs/index.html                                    |  719 +++---
 docs/license.html                                  | 1008 ++++-----
 docs/pmd.html                                      |  670 +++---
 docs/project-info.html                             |  610 +++--
 docs/project-reports.html                          |  656 +++---
 pom.xml                                            |  405 ++--
 samples/RunAntTask.bat                             |    4 -
 samples/RunCodeNarc-Java1.4.bat                    |   11 -
 samples/RunCodeNarc.bat                            |   11 -
 samples/RunSampleRuleSetAntTask.bat                |    5 -
 samples/build-sampleruleset.xml                    |   21 -
 samples/build.xml                                  |   22 -
 samples/rulesets/SampleRuleSet.xml                 |   25 -
 samples/rulesets/SampleRuleSet2.xml                |   33 -
 .../org/codenarc/sample/domain/OtherDomain.groovy  |    9 -
 .../org/codenarc/sample/domain/SampleDomain.groovy |   27 -
 samples/src/org/codenarc/sample/other/Other.groovy |    8 -
 .../codenarc/sample/service/CleanService.groovy    |    9 -
 .../org/codenarc/sample/service/NewService.groovy  |   23 -
 .../codenarc/sample/service/OtherService.groovy    |   29 -
 .../codenarc/sample/service/SampleService.groovy   |   34 -
 .../groovy/org/codenarc/AnalysisContext.groovy     |    2 +-
 src/main/groovy/org/codenarc/CodeNarc.groovy       |   13 +-
 src/main/groovy/org/codenarc/CodeNarcRunner.groovy |    3 +-
 ...alyzer.groovy => AbstractSourceAnalyzer.groovy} |   91 +-
 .../analyzer/DirectorySourceAnalyzer.groovy        |    6 +-
 .../analyzer/FilesystemSourceAnalyzer.groovy       |    6 +-
 .../org/codenarc/analyzer/SourceAnalyzer.groovy    |    2 +-
 .../codenarc/analyzer/StringSourceAnalyzer.groovy  |    4 +-
 .../groovy/org/codenarc/ant/CodeNarcTask.groovy    |    2 +-
 src/main/groovy/org/codenarc/ant/Report.groovy     |    2 +-
 .../groovy/org/codenarc/ant/ReportOption.groovy    |    2 +-
 .../codenarc/report/AbstractReportWriter.groovy    |    3 +-
 .../org/codenarc/report/HtmlReportWriter.groovy    |  703 +++---
 .../org/codenarc/report/IdeTextReportWriter.groovy |   40 +
 .../codenarc/report/InlineXmlReportWriter.groovy   |    1 -
 .../groovy/org/codenarc/report/ReportWriter.groovy |    2 +-
 .../org/codenarc/report/ReportWriterFactory.groovy |   13 +-
 .../org/codenarc/report/TextReportWriter.groovy    |   43 +-
 .../org/codenarc/report/XmlReportWriter.groovy     |   20 +-
 .../org/codenarc/results/DirectoryResults.groovy   |    7 +-
 .../groovy/org/codenarc/results/FileResults.groovy |   22 +-
 .../groovy/org/codenarc/results/Results.groovy     |    5 +-
 .../org/codenarc/results/VirtualResults.groovy     |    2 +-
 .../rule/AbstractConstructorCallAstVisitor.groovy  |    3 +-
 .../org/codenarc/rule/AbstractRuleTestCase.groovy  |   88 +-
 .../groovy/org/codenarc/rule/AstVisitor.groovy     |    2 +-
 .../codenarc/rule/ClassReferenceAstVisitor.groovy  |  316 +--
 .../codenarc/rule/FieldReferenceAstVisitor.groovy  |   12 +-
 .../codenarc/rule/InlineViolationsParser.groovy    |   65 +
 .../org/codenarc/rule/NullReturnTracker.groovy     |    3 +
 .../groovy/org/codenarc/rule/StubRule.groovy       |    4 +-
 src/main/groovy/org/codenarc/rule/Violation.groovy |    2 +-
 .../rule/basic/AbstractFinallyAstVisitor.groovy    |    2 +-
 .../rule/basic/AssertWithinFinallyBlockRule.groovy |    2 +-
 .../rule/basic/AssignmentInConditionalRule.groovy  |  152 +-
 .../rule/basic/BigDecimalInstantiationRule.groovy  |    2 +-
 .../codenarc/rule/basic/BrokenNullCheckRule.groovy |  235 +-
 .../rule/basic/ConstantAssertExpressionRule.groovy |    2 +-
 .../rule/basic/ConstantIfExpressionRule.groovy     |    2 +-
 .../basic/ConstantTernaryExpressionRule.groovy     |    2 +-
 .../org/codenarc/rule/basic/DeadCodeRule.groovy    |  123 +-
 .../codenarc/rule/basic/DoubleNegativeRule.groovy  |    1 -
 .../rule/basic/DuplicateSetValueRule.groovy        |    1 -
 .../codenarc/rule/basic/EmptyCatchBlockRule.groovy |    2 +-
 .../org/codenarc/rule/basic/EmptyClassRule.groovy  |   72 +
 .../codenarc/rule/basic/EmptyElseBlockRule.groovy  |    2 +-
 .../rule/basic/EmptyFinallyBlockRule.groovy        |    2 +-
 .../rule/basic/EmptyForStatementRule.groovy        |    2 +-
 .../rule/basic/EmptyIfStatementRule.groovy         |    2 +-
 .../org/codenarc/rule/basic/EmptyMethodRule.groovy |   91 +-
 .../rule/basic/EmptySwitchStatementRule.groovy     |    2 +-
 .../basic/EmptySynchronizedStatementRule.groovy    |    2 +-
 .../codenarc/rule/basic/EmptyTryBlockRule.groovy   |    2 +-
 .../rule/basic/EmptyWhileStatementRule.groovy      |    2 +-
 .../rule/basic/EqualsAndHashCodeRule.groovy        |    2 +-
 .../rule/basic/EqualsOverloadedRule.groovy         |  129 +-
 .../basic/HardCodedWindowsFileSeparatorRule.groovy |    2 +-
 .../basic/HardCodedWindowsRootDirectoryRule.groovy |    2 +-
 .../rule/basic/MultipleUnaryOperatorsRule.groovy   |   80 +
 .../rule/basic/ReturnFromFinallyRule.groovy        |    2 +-
 .../basic/ThrowExceptionFromFinallyRule.groovy     |    2 +-
 .../rule/braces/ElseBlockBracesRule.groovy         |    2 +-
 .../rule/braces/ForStatementBracesRule.groovy      |    2 +-
 .../rule/braces/IfStatementBracesRule.groovy       |    2 +-
 .../rule/braces/WhileStatementBracesRule.groovy    |    2 +-
 .../concurrency/DoubleCheckedLockingRule.groovy    |    1 -
 .../InconsistentPropertyLockingRule.groovy         |    2 +-
 .../InconsistentPropertySynchronizationRule.groovy |  264 +--
 .../concurrency/StaticCalendarFieldRule.groovy     |  117 +-
 .../rule/concurrency/StaticConnectionRule.groovy   |   92 +-
 .../concurrency/StaticDateFormatFieldRule.groovy   |  125 +-
 .../rule/concurrency/StaticMatcherFieldRule.groovy |   93 +-
 .../StaticSimpleDateFormatFieldRule.groovy         |  121 +-
 .../rule/concurrency/SynchronizedMethodRule.groovy |   93 +-
 .../SynchronizedOnReentrantLockRule.groovy         |   95 +-
 .../SynchronizedReadObjectMethodRule.groovy        |  168 +-
 .../ThisReferenceEscapesConstructorRule.groovy     |   86 +
 .../rule/concurrency/ThreadGroupRule.groovy        |    1 -
 .../ThreadLocalNotStaticFinalRule.groovy           |    3 +-
 .../rule/concurrency/ThreadYieldRule.groovy        |    1 -
 .../rule/concurrency/VolatileArrayFieldRule.groovy |   90 +-
 .../VolatileLongOrDoubleFieldRule.groovy           |    3 +-
 .../rule/convention/ConfusingTernaryRule.groovy    |    1 -
 .../rule/convention/CouldBeElvisRule.groovy        |  149 +-
 .../IfStatementCouldBeTernaryRule.groovy           |  102 +
 .../rule/convention/InvertedIfElseRule.groovy      |    2 +-
 .../LongLiteralWithLowerCaseLRule.groovy           |  108 +-
 .../org/codenarc/rule/convention/NoDefRule.groovy  |   48 +
 .../convention/ParameterReassignmentRule.groovy    |  160 +-
 .../rule/convention/TernaryCouldBeElvisRule.groovy |  126 +-
 .../AbstractClassWithPublicConstructorRule.groovy  |   97 +-
 .../AbstractClassWithoutAbstractMethodRule.groovy  |   93 +-
 .../design/BooleanMethodReturnsNullRule.groovy     |  215 +-
 .../rule/design/CloneWithoutCloneableRule.groovy   |   55 +
 .../rule/design/CloneableWithoutCloneRule.groovy   |    1 -
 .../rule/design/CloseWithoutCloseableRule.groovy   |   91 +-
 .../design/EmptyMethodInAbstractClassRule.groovy   |  132 +-
 .../FinalClassWithProtectedMemberRule.groovy       |  126 +-
 .../org/codenarc/rule/design/InstanceofRule.groovy |   59 +
 .../rule/design/LocaleSetDefaultRule.groovy        |   60 +
 .../codenarc/rule/design/NestedForLoopRule.groovy  |   51 +
 .../design/PrivateFieldCouldBeFinalRule.groovy     |   51 +-
 .../rule/design/PublicInstanceFieldRule.groovy     |   90 +-
 .../ReturnsNullInsteadOfEmptyArrayRule.groovy      |  202 +-
 .../ReturnsNullInsteadOfEmptyCollectionRule.groovy |  242 +-
 .../SimpleDateFormatMissingLocaleRule.groovy       |    2 +-
 .../rule/design/StatelessSingletonRule.groovy      |  153 +-
 .../rule/design/ToStringReturnsNullRule.groovy     |   71 +
 .../groovy/org/codenarc/rule/dry/DryUtil.groovy    |  288 +--
 .../codenarc/rule/dry/DuplicateListLiteral.groovy  |    2 +-
 .../rule/dry/DuplicateLiteralAstVisitor.groovy     |    2 +-
 .../codenarc/rule/dry/DuplicateMapLiteral.groovy   |    2 +-
 .../rule/dry/DuplicateNumberLiteralRule.groovy     |    2 +-
 .../rule/dry/DuplicateStringLiteralRule.groovy     |    4 +-
 .../rule/exceptions/CommonCatchAstVisitor.groovy   |    2 +-
 .../rule/exceptions/CommonThrowAstVisitor.groovy   |    2 +-
 .../exceptions/ExceptionExtendsErrorRule.groovy    |    1 -
 ...groovy => ExceptionExtendsThrowableRule.groovy} |   25 +-
 .../rule/exceptions/ExceptionNotThrownRule.groovy  |   60 +
 .../MissingNewInThrowStatementRule.groovy          |  136 +-
 .../exceptions/ReturnNullFromCatchBlockRule.groovy |   11 +-
 .../rule/exceptions/SwallowThreadDeathRule.groovy  |    1 -
 .../codenarc/rule/exceptions/ThrowErrorRule.groovy |    2 +-
 .../rule/exceptions/ThrowExceptionRule.groovy      |    2 +-
 .../ThrowNullPointerExceptionRule.groovy           |    2 +-
 .../exceptions/ThrowRuntimeExceptionRule.groovy    |    2 +-
 .../rule/exceptions/ThrowThrowableRule.groovy      |    2 +-
 ...bstractSingleSpaceAfterKeywordAstVisitor.groovy |   43 +
 .../AbstractSpaceAroundBraceAstVisitor.groovy      |   75 +
 .../formatting/BlankLineBeforePackageRule.groovy   |   45 +
 .../rule/formatting/BracesForClassRule.groovy      |   45 +-
 .../rule/formatting/BracesForForLoopRule.groovy    |  106 +-
 .../rule/formatting/BracesForIfElseRule.groovy     |  179 +-
 .../rule/formatting/BracesForMethodRule.groovy     |  133 +-
 .../formatting/BracesForTryCatchFinallyRule.groovy |  182 +-
 .../rule/formatting/ClassJavadocRule.groovy        |   22 +-
 ...ntOnOpeningLineOfMultipleLineClosureRule.groovy |   51 +
 .../formatting/ConsecutiveBlankLinesRule.groovy    |   48 +
 .../formatting/FileEndsWithoutNewlineRule.groovy   |   43 +
 .../codenarc/rule/formatting/LineLengthRule.groovy |   33 +-
 .../MissingBlankLineAfterImportsRule.groovy        |   43 +
 .../MissingBlankLineAfterPackageRule.groovy        |   41 +
 .../rule/formatting/SpaceAfterCatchRule.groovy     |   42 +
 .../formatting/SpaceAfterClosingBraceRule.groovy   |  136 ++
 .../rule/formatting/SpaceAfterCommaRule.groovy     |  133 ++
 .../rule/formatting/SpaceAfterForRule.groovy       |   41 +
 .../rule/formatting/SpaceAfterIfRule.groovy        |   41 +
 .../formatting/SpaceAfterOpeningBraceRule.groovy   |  124 +
 .../rule/formatting/SpaceAfterSemicolonRule.groovy |   70 +
 .../rule/formatting/SpaceAfterSwitchRule.groovy    |   42 +
 .../rule/formatting/SpaceAfterWhileRule.groovy     |   40 +
 .../formatting/SpaceAroundClosureArrowRule.groovy  |   44 +
 .../formatting/SpaceAroundMapEntryColonRule.groovy |   69 +
 .../rule/formatting/SpaceAroundOperatorRule.groovy |  190 ++
 .../formatting/SpaceBeforeClosingBraceRule.groovy  |  130 ++
 .../formatting/SpaceBeforeOpeningBraceRule.groovy  |  146 ++
 .../rule/formatting/TrailingWhitespaceRule.groovy} |   78 +-
 .../rule/generic/IllegalClassMemberRule.groovy     |  160 ++
 .../generic/IllegalPackageReferenceRule.groovy     |  329 ++-
 .../codenarc/rule/generic/IllegalRegexRule.groovy  |    2 +-
 ...dStringRule.groovy => IllegalStringRule.groovy} |   94 +-
 .../IllegalSubclassRule.groovy}                    |   35 +-
 .../codenarc/rule/generic/RequiredRegexRule.groovy |    2 +-
 .../rule/generic/RequiredStringRule.groovy         |    2 +-
 .../rule/generic/StatelessClassRule.groovy         |    5 +-
 .../rule/grails/GrailsDomainHasEqualsRule.groovy   |   92 +-
 .../rule/grails/GrailsDomainHasToStringRule.groovy |   94 +-
 .../GrailsDomainReservedSqlKeywordNameRule.groovy  |  166 ++
 .../GrailsDomainWithServiceReferenceRule.groovy}   |   88 +-
 .../grails/GrailsDuplicateConstraintRule.groovy    |   84 +
 .../rule/grails/GrailsDuplicateMappingRule.groovy  |   67 +
 .../rule/grails/GrailsMassAssignmentRule.groovy    |   71 +
 .../grails/GrailsPublicControllerMethodRule.groovy |  147 +-
 .../GrailsServletContextReferenceRule.groovy       |    6 +-
 .../rule/grails/GrailsSessionReferenceRule.groovy  |    6 +-
 .../rule/grails/GrailsStatelessServiceRule.groovy  |    3 +-
 .../org/codenarc/rule/grails/GrailsUtil.groovy     |    2 +-
 .../rule/groovyism/AssignCollectionSortRule.groovy |  124 +-
 .../groovyism/ConfusingMultipleReturnsRule.groovy  |   10 +-
 .../ExplicitArrayListInstantiationRule.groovy      |    2 +-
 .../groovyism/ExplicitCallToAndMethodRule.groovy   |    2 +-
 .../ExplicitCallToCompareToMethodRule.groovy       |    2 +-
 .../groovyism/ExplicitCallToDivMethodRule.groovy   |    2 +-
 .../ExplicitCallToEqualsMethodRule.groovy          |    2 +-
 .../groovyism/ExplicitCallToGetAtMethodRule.groovy |    2 +-
 .../ExplicitCallToLeftShiftMethodRule.groovy       |    2 +-
 .../ExplicitCallToMethodAstVisitor.groovy          |    3 +-
 .../groovyism/ExplicitCallToMinusMethodRule.groovy |    2 +-
 .../groovyism/ExplicitCallToModMethodRule.groovy   |    2 +-
 .../ExplicitCallToMultiplyMethodRule.groovy        |    2 +-
 .../groovyism/ExplicitCallToOrMethodRule.groovy    |    2 +-
 .../groovyism/ExplicitCallToPlusMethodRule.groovy  |    2 +-
 .../groovyism/ExplicitCallToPowerMethodRule.groovy |    2 +-
 .../ExplicitCallToRightShiftMethodRule.groovy      |    2 +-
 .../groovyism/ExplicitCallToXorMethodRule.groovy   |    2 +-
 .../ExplicitHashMapInstantiationRule.groovy        |    2 +-
 .../ExplicitHashSetInstantiationRule.groovy        |    6 +-
 .../ExplicitLinkedHashMapInstantiationRule.groovy  |    2 +-
 .../ExplicitLinkedListInstantiationRule.groovy     |    4 +-
 .../ExplicitStackInstantiationRule.groovy          |    2 +-
 .../ExplicitTreeSetInstantiationRule.groovy        |    2 +-
 .../ExplicitTypeInstantiationAstVisitor.groovy     |    2 +-
 .../GStringExpressionWithinStringRule.groovy       |  115 +
 .../GetterMethodCouldBePropertyRule.groovy         |    2 +-
 .../rule/groovyism/GroovyLangImmutableRule.groovy  |    1 -
 .../rule/groovyism/UseCollectNestedRule.groovy     |    2 +-
 .../rule/imports/DuplicateImportRule.groovy        |    2 +-
 .../rule/imports/ImportFromSamePackageRule.groovy  |    4 +-
 .../rule/imports/NoWildcardImportsRule.groovy}     |   77 +-
 .../imports/UnnecessaryGroovyImportRule.groovy     |    2 +-
 .../codenarc/rule/imports/UnusedImportRule.groovy  |  158 +-
 .../codenarc/rule/junit/CoupledTestCaseRule.groovy |   12 +-
 .../rule/junit/JUnitAssertAlwaysFailsRule.groovy   |   35 +-
 .../junit/JUnitAssertAlwaysSucceedsRule.groovy     |   19 +-
 ...JUnitAssertEqualsConstantActualValueRule.groovy |   99 +
 .../codenarc/rule/junit/JUnitLostTestRule.groovy   |   70 +
 ...etUpRule.groovy => JUnitPublicFieldRule.groovy} |   40 +-
 .../rule/junit/JUnitPublicNonTestMethodRule.groovy |  143 +-
 .../rule/junit/JUnitPublicPropertyRule.groovy      |   52 +
 .../rule/junit/JUnitSetUpCallsSuperRule.groovy     |    2 +-
 .../rule/junit/JUnitTearDownCallsSuperRule.groovy  |    2 +-
 .../junit/JUnitTestMethodWithoutAssertRule.groovy  |    2 +-
 .../rule/junit/JUnitUnnecessarySetUpRule.groovy    |    2 +-
 .../rule/junit/JUnitUnnecessaryTearDownRule.groovy |    2 +-
 .../JUnitUnnecessaryThrowsExceptionRule.groovy     |   60 +
 .../org/codenarc/rule/junit/JUnitUtil.groovy       |   52 +-
 .../rule/junit/SpockIgnoreRestUsedRule.groovy      |  114 +-
 .../UseAssertSameInsteadOfAssertTrueRule.groovy    |  102 +-
 .../UseAssertTrueInsteadOfAssertEqualsRule.groovy  |   10 +-
 .../logging/LoggerForDifferentClassRule.groovy     |    2 +-
 .../logging/LoggerWithWrongModifiersRule.groovy    |  147 +-
 .../rule/logging/PrintStackTraceRule.groovy        |   86 +-
 .../org/codenarc/rule/logging/PrintlnRule.groovy   |    2 +-
 .../rule/logging/SystemErrPrintRule.groovy         |    2 +-
 .../rule/logging/SystemOutPrintRule.groovy         |    2 +-
 .../rule/naming/AbstractClassNameRule.groovy       |    2 +-
 .../rule/naming/AbstractTypeNameAstVisitor.groovy  |    2 +-
 .../org/codenarc/rule/naming/ClassNameRule.groovy  |    2 +-
 .../rule/naming/ClassNameSameAsFilenameRule.groovy |   59 +
 .../rule/naming/ConfusingMethodNameRule.groovy     |    5 -
 .../org/codenarc/rule/naming/FieldNameRule.groovy  |  239 +-
 .../codenarc/rule/naming/InterfaceNameRule.groovy  |    2 +-
 .../org/codenarc/rule/naming/MethodNameRule.groovy |    2 +-
 .../naming/PackageNameMatchesFilePathRule.groovy   |   79 +
 .../codenarc/rule/naming/PackageNameRule.groovy    |    6 +-
 .../codenarc/rule/naming/ParameterNameRule.groovy  |    2 +-
 .../codenarc/rule/naming/PropertyNameRule.groovy   |  197 +-
 .../codenarc/rule/naming/VariableNameRule.groovy   |    2 +-
 .../rule/security/JavaIoPackageAccessRule.groovy   |    2 -
 ...NonFinalSubclassOfSensitiveInterfaceRule.groovy |  126 +-
 .../rule/security/PublicFinalizeMethodRule.groovy  |   87 +-
 .../security/UnsafeArrayDeclarationRule.groovy     |  108 +-
 .../security/UnsafeImplementationAsMapRule.groovy  |   65 +
 .../EnumCustomSerializationIgnoredRule.groovy      |   73 +
 .../SerialPersistentFieldsRule.groovy              |  105 +-
 .../rule/serialization/SerialVersionUIDRule.groovy |   13 +-
 ...zableClassMustDefineSerialVersionUIDRule.groovy |    1 -
 .../codenarc/rule/size/AbcComplexityRule.groovy    |   22 +-
 ...cComplexityRule.groovy => AbcMetricRule.groovy} |   47 +-
 .../size/AbstractMethodMetricAstVisitor.groovy     |   48 +-
 .../org/codenarc/rule/size/ClassSizeRule.groovy    |    5 +-
 .../org/codenarc/rule/size/CrapMetricRule.groovy   |   22 +-
 .../rule/size/CyclomaticComplexityRule.groovy      |   16 +-
 .../org/codenarc/rule/size/MethodSizeRule.groovy   |    2 +-
 .../codenarc/rule/size/NestedBlockDepthRule.groovy |    5 +-
 .../codenarc/rule/size/ParameterCountRule.groovy   |   66 +
 .../ConsecutiveLiteralAppendsRule.groovy           |    1 -
 .../UnnecessaryBooleanExpressionRule.groovy        |    2 +-
 .../UnnecessaryBooleanInstantiationRule.groovy     |    2 +-
 .../UnnecessaryCallForLastElementRule.groovy       |    1 -
 .../rule/unnecessary/UnnecessaryCastRule.groovy    |   58 +
 .../unnecessary/UnnecessaryCatchBlockRule.groovy   |    1 -
 .../unnecessary/UnnecessaryConstructorRule.groovy  |  149 +-
 .../UnnecessaryDefInFieldDeclarationRule.groovy    |    4 +
 .../UnnecessaryDefInMethodDeclarationRule.groovy   |  166 +-
 .../unnecessary/UnnecessaryDotClassRule.groovy     |   13 +-
 .../UnnecessaryElseStatementRule.groovy            |  182 +-
 .../UnnecessaryFinalOnPrivateMethodRule.groovy     |   87 +-
 .../rule/unnecessary/UnnecessaryGStringRule.groovy |    1 -
 .../rule/unnecessary/UnnecessaryGetterRule.groovy  |    1 -
 .../unnecessary/UnnecessaryIfStatementRule.groovy  |   38 +-
 .../rule/unnecessary/UnnecessaryModOneRule.groovy  |    1 -
 .../UnnecessaryPackageReferenceRule.groovy         |  325 ++-
 .../UnnecessarySafeNavigationOperatorRule.groovy   |   67 +
 .../unnecessary/UnnecessarySemicolonRule.groovy    |   22 +-
 .../UnnecessaryTernaryExpressionRule.groovy        |    2 +-
 .../unnecessary/UnnecessaryToStringRule.groovy     |   76 +
 .../UnnecessaryTransientModifierRule.groovy        |   91 +-
 .../codenarc/rule/unused/ReferenceCollector.groovy |    4 +-
 .../rule/unused/UnusedMethodParameterRule.groovy   |  151 +-
 .../unused/UnusedPrivateMethodParameterRule.groovy |  129 +-
 .../rule/unused/UnusedPrivateMethodRule.groovy     |  324 +--
 .../codenarc/rule/unused/UnusedVariableRule.groovy |  290 +--
 .../org/codenarc/ruleset/CompositeRuleSet.groovy   |    2 +-
 .../org/codenarc/ruleset/FilteredRuleSet.groovy    |    2 +-
 .../org/codenarc/ruleset/GroovyDslRuleSet.groovy   |    4 +-
 .../groovy/org/codenarc/ruleset/ListRuleSet.groovy |    2 +-
 .../ruleset/PropertiesFileRuleSetConfigurer.groovy |    2 +-
 .../groovy/org/codenarc/ruleset/RuleSet.groovy     |    2 +-
 .../org/codenarc/ruleset/RuleSetBuilder.groovy     |    2 +-
 .../groovy/org/codenarc/ruleset/RuleSetUtil.groovy |   10 +-
 .../groovy/org/codenarc/ruleset/RuleSets.groovy    |    1 +
 .../org/codenarc/ruleset/XmlFileRuleSet.groovy     |    2 +-
 .../org/codenarc/ruleset/XmlReaderRuleSet.groovy   |    9 +-
 .../org/codenarc/source/AbstractSourceCode.groovy  |   33 +-
 .../CustomCompilerPhaseSourceDecorator.groovy      |   66 +
 .../groovy/org/codenarc/source/SourceCode.groovy   |   14 +-
 .../org/codenarc/source/SourceCodeCriteria.groovy  |    3 +-
 .../groovy/org/codenarc/source/SourceFile.groovy   |    2 +-
 .../groovy/org/codenarc/source/SourceString.groovy |    2 +-
 .../org/codenarc/test/AbstractTestCase.groovy      |   68 +
 .../org/codenarc/test/InMemoryAppender.groovy      |    4 +-
 src/main/groovy/org/codenarc/test/TestUtil.groovy  |  156 ++
 .../groovy/org/codenarc/tool/GenerateAll.groovy    |    1 -
 .../tool/GenerateCodeNarcRulesProperties.groovy    |    3 +-
 .../org/codenarc/tool/GenerateRuleIndexPage.groovy |    4 +-
 .../codenarc/tool/GenerateRuleSetAllRules.groovy   |  113 +-
 .../tool/GenerateRuleSetAllRulesByCategory.groovy  |    5 +-
 .../groovy/org/codenarc/tool/GenerateUtil.groovy   |  101 +-
 .../groovy/org/codenarc/util/ImportUtil.groovy     |   13 +-
 .../groovy/org/codenarc/util/ModifiersUtil.groovy  |   97 +
 src/main/groovy/org/codenarc/util/PathUtil.groovy  |    3 +-
 .../groovy/org/codenarc/util/PropertyUtil.groovy   |    6 +-
 .../org/codenarc/util/WildcardPattern.groovy       |    4 +-
 .../org/codenarc/util/io/ClassPathResource.groovy  |    2 +-
 .../codenarc/util/io/DefaultResourceFactory.groovy |    2 +-
 .../groovy/org/codenarc/util/io/Resource.groovy    |    2 +-
 .../org/codenarc/util/io/ResourceFactory.groovy    |    2 +-
 .../groovy/org/codenarc/util/io/UrlResource.groovy |    2 +-
 .../codehaus/groovy/ast/expr/RegexExpression.java  |   66 -
 .../org/codenarc/ant/AntFileSetSourceAnalyzer.java |    4 +-
 .../java/org/codenarc/rule/AbstractAstVisitor.java |   48 +-
 .../org/codenarc/rule/AbstractAstVisitorRule.java  |  308 +--
 .../org/codenarc/rule/AbstractFieldVisitor.java    |    5 -
 .../rule/AbstractMethodCallExpressionVisitor.java  |    7 +-
 .../org/codenarc/rule/AbstractMethodVisitor.java   |    5 -
 src/main/java/org/codenarc/rule/AbstractRule.java  |   19 +
 .../codenarc/rule/ClassCodeVisitorSupportHack.java |  347 ---
 src/main/java/org/codenarc/rule/Rule.java          |    7 +
 src/main/java/org/codenarc/util/AstUtil.java       | 2362 ++++++++++----------
 .../resources/codenarc-base-messages.properties    | 1989 ++++++++--------
 src/main/resources/codenarc-base-rules.properties  |   59 +-
 .../resources/codenarc-rule-extrainfo.properties   |    6 +
 src/main/resources/codenarc-version.txt            |    2 +-
 src/main/resources/rulesets/basic.xml              |    2 +
 src/main/resources/rulesets/concurrency.xml        |    1 +
 src/main/resources/rulesets/convention.xml         |    2 +
 src/main/resources/rulesets/design.xml             |    6 +-
 src/main/resources/rulesets/enhanced.xml           |   17 +
 src/main/resources/rulesets/exceptions.xml         |   58 +-
 src/main/resources/rulesets/formatting.xml         |   56 +-
 src/main/resources/rulesets/generic.xml            |    4 +-
 src/main/resources/rulesets/grails.xml             |   14 +-
 src/main/resources/rulesets/groovyism.xml          |    1 +
 src/main/resources/rulesets/imports.xml            |    1 +
 src/main/resources/rulesets/junit.xml              |   64 +-
 src/main/resources/rulesets/naming.xml             |    4 +-
 src/main/resources/rulesets/serialization.xml      |    2 +-
 src/main/resources/rulesets/size.xml               |   36 +-
 src/main/resources/rulesets/unnecessary.xml        |   14 +-
 .../StarterRuleSet-AllRules.groovy.template        |    2 +-
 ...arterRuleSet-AllRulesByCategory.groovy.template |    2 +-
 .../templates/codenarc-rule-index.apt.template     |    9 +-
 src/site/apt/codenarc-HtmlReportWriter.apt         |   29 +-
 src/site/apt/codenarc-TextReportWriter.apt         |   50 +-
 src/site/apt/codenarc-ant-task.apt                 |   16 +-
 src/site/apt/codenarc-command-line.apt             |    3 +
 src/site/apt/codenarc-configuring-rules.apt        |    4 +-
 src/site/apt/codenarc-creating-rule.apt            |    2 +-
 src/site/apt/codenarc-enhanced-classpath-rules.apt |   58 +
 src/site/apt/codenarc-opensource-projects.apt      |   63 -
 src/site/apt/codenarc-other-tools-frameworks.apt   |   25 +-
 src/site/apt/codenarc-rule-index.apt               | 1078 ++++++---
 src/site/apt/codenarc-rules-basic.apt              |   27 +-
 src/site/apt/codenarc-rules-concurrency.apt        |   22 +
 src/site/apt/codenarc-rules-convention.apt         |   69 +-
 src/site/apt/codenarc-rules-design.apt             |  132 +-
 src/site/apt/codenarc-rules-enhanced.apt           |   74 +
 src/site/apt/codenarc-rules-exceptions.apt         |  396 ++--
 src/site/apt/codenarc-rules-formatting.apt         |  652 +++++-
 src/site/apt/codenarc-rules-generic.apt            |  183 +-
 src/site/apt/codenarc-rules-grails.apt             |  134 +-
 src/site/apt/codenarc-rules-groovyism.apt          |   19 +
 src/site/apt/codenarc-rules-imports.apt            |   20 +-
 src/site/apt/codenarc-rules-junit.apt              |  894 +++++---
 src/site/apt/codenarc-rules-logging.apt            |    3 +-
 src/site/apt/codenarc-rules-naming.apt             |  686 +++---
 src/site/apt/codenarc-rules-security.apt           |    3 +-
 src/site/apt/codenarc-rules-serialization.apt      |   39 +-
 src/site/apt/codenarc-rules-size.apt               |  154 +-
 src/site/apt/codenarc-rules-unnecessary.apt        | 2205 +++++++++---------
 src/site/apt/codenarc-rules-unused.apt             |   11 +
 src/site/apt/codenarc-run-as-a-test.apt            |    9 +-
 src/site/resources/SampleCodeNarcHtmlReport.html   |    2 +-
 src/site/resources/SampleCodeNarcTextReport.txt    |   38 +-
 src/site/resources/SampleCodeNarcXmlReport.xml     |    2 +-
 .../resources/StarterRuleSet-AllRules.groovy.txt   |  629 +++---
 .../StarterRuleSet-AllRulesByCategory.groovy.txt   |  631 +++---
 .../resources/images/forkme_right_red_aa0000.png   |  Bin 0 -> 7927 bytes
 src/site/resources/images/getit.png                |  Bin 14382 -> 15064 bytes
 src/site/site.xml                                  |   17 +-
 src/site/xdoc/index.xml                            |  220 +-
 .../groovy/org/codenarc/CodeNarcRunnerTest.groovy  |   28 +-
 src/test/groovy/org/codenarc/CodeNarcTest.groovy   |   66 +-
 .../analyzer/AbstractSourceAnalyzerTest.groovy     |   52 +
 .../analyzer/DirectorySourceAnalyzerTest.groovy    |   58 +-
 .../analyzer/FilesystemSourceAnalyzerTest.groovy   |   42 +-
 .../analyzer/SourceStringAnalyzerTest.groovy       |   17 +
 .../analyzer/StringSourceAnalyzerTest.groovy       |  164 +-
 .../analyzer/SuppressionAnalyzerTest.groovy        |  570 ++---
 .../ant/AntFileSetSourceAnalyzerTest.groovy        |   38 +-
 .../org/codenarc/ant/CodeNarcTaskAccessor.groovy   |    2 +-
 .../ant/CodeNarcTaskAllRuleSetsTest.groovy         |   11 +-
 .../org/codenarc/ant/CodeNarcTaskTest.groovy       |   40 +-
 .../ant/CodeNarcTask_CustomRuleSetTest.groovy      |   11 +-
 .../codenarc/ant/CodeNarc_AntBuilderTest.groovy    |   18 +-
 src/test/groovy/org/codenarc/ant/ReportTest.groovy |    4 +-
 .../report/AbstractReportWriterTest.groovy         |  492 ++--
 .../report/AbstractTextReportWriterTestCase.groovy |  190 ++
 .../codenarc/report/HtmlReportWriterTest.groovy    |  256 ++-
 .../codenarc/report/IdeTextReportWriterTest.groovy |   73 +
 .../report/InlineXmlReportWriterTest.groovy        |   28 +-
 .../codenarc/report/ReportWriterFactoryTest.groovy |   38 +-
 .../codenarc/report/TextReportWriterTest.groovy    |  127 +-
 .../org/codenarc/report/XmlReportWriterTest.groovy |   65 +-
 .../data/HtmlReportWriterTest.testWriteReport.html |  158 --
 ...t.testWriteReport_NoDescriptionsForRuleIds.html |  158 --
 ...ReportWriterTest.testWriteReport_Priority4.html |  158 --
 ...DescriptionsProvidedInCodeNarcMessagesFile.html |  158 --
 ...eport_RuleDescriptionsSetDirectlyOnTheRule.html |  158 --
 ...Test.testWriteReport_SetOutputFileAndTitle.html |  158 --
 .../codenarc/results/DirectoryResultsTest.groovy   |   35 +-
 .../org/codenarc/results/FileResultsTest.groovy    |   19 +-
 .../org/codenarc/results/VirtualResultsTest.groovy |  110 +-
 .../rule/AbstractAstVisitorRuleTest.groovy         |   44 +-
 .../codenarc/rule/AbstractAstVisitorTest.groovy    |   36 +-
 .../rule/AbstractClassReferenceRuleTestCase.groovy |  401 ++--
 .../org/codenarc/rule/AbstractRuleTest.groovy      |   54 +-
 .../org/codenarc/rule/ClassResolutionTest.groovy   |   77 +-
 .../{TestCountRule.groovy => FakeCountRule.groovy} |    6 +-
 .../{TestPathRule.groovy => FakePathRule.groovy}   |    4 +-
 .../rule/InlineViolationsParserTest.groovy         |  213 ++
 .../rule/{StubRule.groovy => MockRule.groovy}      |   86 +-
 .../basic/AssertWithinFinallyBlockRuleTest.groovy  |   10 +-
 .../basic/AssignmentInConditionalRuleTest.groovy   |  230 +-
 .../basic/BigDecimalInstantiationRuleTest.groovy   |   13 +-
 .../BitwiseOperatorInConditionalRuleTest.groovy    |  461 ++--
 .../rule/basic/BooleanGetBooleanRuleTest.groovy    |  106 +-
 .../rule/basic/BrokenNullCheckRuleTest.groovy      |  196 +-
 .../rule/basic/BrokenOddnessCheckRuleTest.groovy   |  136 +-
 .../rule/basic/ClassForNameRuleTest.groovy         |  114 +-
 .../basic/ComparisonOfTwoConstantsRuleTest.groovy  |  246 +-
 .../rule/basic/ComparisonWithSelfRuleTest.groovy   |  226 +-
 .../basic/ConstantAssertExpressionRuleTest.groovy  |   14 +-
 .../rule/basic/ConstantIfExpressionRuleTest.groovy |   12 +-
 .../basic/ConstantTernaryExpressionRuleTest.groovy |   12 +-
 .../ConstantTernaryExpressionRule_ElvisTest.groovy |   11 +-
 .../codenarc/rule/basic/DeadCodeRuleTest.groovy    |  240 +-
 .../rule/basic/DoubleNegativeRuleTest.groovy       |  110 +-
 .../basic/DuplicateCaseStatementRuleTest.groovy    |    5 +
 .../rule/basic/DuplicateMapKeyRuleTest.groovy      |  188 +-
 .../rule/basic/DuplicateSetValueRuleTest.groovy    |  170 +-
 .../rule/basic/EmptyCatchBlockRuleTest.groovy      |    7 +
 .../codenarc/rule/basic/EmptyClassRuleTest.groovy  |  172 ++
 .../rule/basic/EmptyElseBlockRuleTest.groovy       |    7 +-
 .../rule/basic/EmptyFinallyBlockRuleTest.groovy    |    7 +-
 .../rule/basic/EmptyForStatementRuleTest.groovy    |    8 +-
 .../rule/basic/EmptyIfStatementRuleTest.groovy     |    7 +-
 .../basic/EmptyInstanceInitializerRuleTest.groovy  |  112 +-
 .../codenarc/rule/basic/EmptyMethodRuleTest.groovy |  149 +-
 .../basic/EmptyStaticInitializerRuleTest.groovy    |  118 +-
 .../rule/basic/EmptySwitchStatementRuleTest.groovy |    6 +-
 .../EmptySynchronizedStatementRuleTest.groovy      |    7 +-
 .../rule/basic/EmptyTryBlockRuleTest.groovy        |    7 +-
 .../rule/basic/EmptyWhileStatementRuleTest.groovy  |    8 +-
 .../rule/basic/EqualsAndHashCodeRuleTest.groovy    |   10 +-
 .../rule/basic/EqualsOverloadedRuleTest.groovy     |  193 +-
 .../basic/ExplicitGarbageCollectionRuleTest.groovy |  173 +-
 .../basic/ForLoopShouldBeWhileLoopRuleTest.groovy  |  197 +-
 .../HardCodedWindowsFileSeparatorRuleTest.groovy   |  185 +-
 .../HardCodedWindowsRootDirectoryRuleTest.groovy   |  183 +-
 .../rule/basic/IntegerGetIntegerRuleTest.groovy    |  112 +-
 .../basic/MultipleUnaryOperatorsRuleTest.groovy    |   74 +
 .../basic/RandomDoubleCoercedToZeroRuleTest.groovy |  334 +--
 .../rule/basic/RemoveAllOnSelfRuleTest.groovy      |  141 +-
 .../basic/ReturnFromFinallyBlockRuleTest.groovy    |    7 +-
 .../ThrowExceptionFromFinallyBlockRuleTest.groovy  |    7 +-
 .../rule/braces/ElseBlockBracesRuleTest.groovy     |   10 +-
 .../rule/braces/ForStatementBracesRuleTest.groovy  |    7 +-
 .../rule/braces/IfStatementBracesRuleTest.groovy   |    7 +-
 .../braces/WhileStatementBracesRuleTest.groovy     |    7 +-
 .../rule/concurrency/BusyWaitRuleTest.groovy       |  182 +-
 .../DoubleCheckedLockingRuleTest.groovy            |  322 +--
 .../InconsistentPropertyLockingRuleTest.groovy     |  315 +--
 ...onsistentPropertySynchronizationRuleTest.groovy |  524 ++---
 .../NestedSynchronizationRuleTest.groovy           |   89 +-
 .../concurrency/StaticCalendarFieldRuleTest.groovy |  193 +-
 .../concurrency/StaticConnectionRuleTest.groovy    |  114 +-
 .../StaticDateFormatFieldRuleTest.groovy           |  237 +-
 .../concurrency/StaticMatcherFieldRuleTest.groovy  |  135 +-
 .../StaticSimpleDateFormatFieldRuleTest.groovy     |  199 +-
 .../concurrency/SynchronizedMethodRuleTest.groovy  |    4 +
 .../SynchronizedOnBoxedPrimitiveRuleTest.groovy    |  937 ++++----
 .../SynchronizedOnGetClassRuleTest.groovy          |  158 +-
 .../SynchronizedOnReentrantLockRuleTest.groovy     |  377 ++--
 .../SynchronizedOnStringRuleTest.groovy            |  369 +--
 .../concurrency/SynchronizedOnThisRuleTest.groovy  |    4 +
 .../SynchronizedReadObjectMethodRuleTest.groovy    |  179 +-
 .../SystemRunFinalizersOnExitRuleTest.groovy       |    6 +
 .../ThisReferenceEscapesConstructorRuleTest.groovy |   84 +
 .../rule/concurrency/ThreadGroupRuleTest.groovy    |  164 +-
 .../ThreadLocalNotStaticFinalRuleTest.groovy       |    6 +
 .../rule/concurrency/ThreadYieldRuleTest.groovy    |    6 +
 .../concurrency/UseOfNotifyMethodRuleTest.groovy   |  138 +-
 .../concurrency/VolatileArrayFieldRuleTest.groovy  |  235 +-
 .../VolatileLongOrDoubleFieldRuleTest.groovy       |    6 +
 .../WaitOutsideOfWhileLoopRuleTest.groovy          |  176 +-
 .../convention/ConfusingTernaryRuleTest.groovy     |  153 +-
 .../rule/convention/CouldBeElvisRuleTest.groovy    |  259 ++-
 .../HashtableIsObsoleteRule_HashtableTest.groovy   |   80 +-
 ...ableIsObsoleteRule_JavaUtilHashtableTest.groovy |   80 +-
 .../IfStatementCouldBeTernaryRuleTest.groovy       |  196 ++
 .../rule/convention/InvertedIfElseRuleTest.groovy  |  210 +-
 .../LongLiteralWithLowerCaseLRuleTest.groovy       |  127 +-
 .../codenarc/rule/convention/NoDefRuleTest.groovy  |   75 +
 .../ParameterReassignmentRuleTest.groovy           |  327 +--
 .../convention/TernaryCouldBeElvisRuleTest.groovy  |  183 +-
 .../VectorIsObsoleteRule_JavaUtilVectorTest.groovy |   80 +-
 .../VectorIsObsoleteRule_VectorTest.groovy         |   80 +-
 ...stractClassWithPublicConstructorRuleTest.groovy |  161 +-
 ...stractClassWithoutAbstractMethodRuleTest.groovy |  148 +-
 .../design/BooleanMethodReturnsNullRuleTest.groovy |  440 ++--
 .../BuilderMethodWithSideEffectsRuleTest.groovy    |  223 +-
 .../design/CloneWithoutCloneableRuleTest.groovy    |  113 +
 .../design/CloneableWithoutCloneRuleTest.groovy    |    9 +-
 .../design/CloseWithoutCloseableRuleTest.groovy    |  153 +-
 .../CompareToWithoutComparableRuleTest.groovy      |  163 +-
 .../design/ConstantsOnlyInterfaceRuleTest.groovy   |  153 +-
 .../EmptyMethodInAbstractClassRuleTest.groovy      |  216 +-
 .../FinalClassWithProtectedMemberRuleTest.groovy   |  194 +-
 .../design/ImplementationAsTypeRuleTest.groovy     |  365 +--
 .../codenarc/rule/design/InstanceofRuleTest.groovy |   99 +
 .../rule/design/LocaleSetDefaultRuleTest.groovy    |   77 +
 .../rule/design/NestedForLoopRuleTest.groovy       |  107 +
 .../design/PrivateFieldCouldBeFinalRuleTest.groovy |   96 +-
 .../rule/design/PublicInstanceFieldRuleTest.groovy |  150 +-
 .../ReturnsNullInsteadOfEmptyArrayRuleTest.groovy  |  411 ++--
 ...urnsNullInsteadOfEmptyCollectionRuleTest.groovy |  587 ++---
 .../SimpleDateFormatMissingLocaleRuleTest.groovy   |  150 +-
 .../rule/design/StatelessSingletonRuleTest.groovy  |  362 +--
 .../rule/design/ToStringReturnsNullRuleTest.groovy |  137 ++
 .../rule/dry/DuplicateListLiteralRuleTest.groovy   |  306 +--
 .../rule/dry/DuplicateMapLiteralRuleTest.groovy    |  442 ++--
 .../rule/dry/DuplicateNumberLiteralRuleTest.groovy |  448 ++--
 .../rule/dry/DuplicateStringLiteralRuleTest.groovy |  460 ++--
 ...chArrayIndexOutOfBoundsExceptionRuleTest.groovy |    7 +-
 .../rule/exceptions/CatchErrorRuleTest.groovy      |    7 +-
 .../rule/exceptions/CatchExceptionRuleTest.groovy  |    7 +-
 ...atchIllegalMonitorStateExceptionRuleTest.groovy |  131 +-
 .../CatchIndexOutOfBoundsExceptionRuleTest.groovy  |    7 +-
 .../CatchNullPointerExceptionRuleTest.groovy       |    7 +-
 .../CatchRuntimeExceptionRuleTest.groovy           |    7 +-
 .../rule/exceptions/CatchThrowableRuleTest.groovy  |    7 +-
 .../ConfusingClassNamedExceptionRuleTest.groovy    |  167 +-
 .../ExceptionExtendsErrorRuleTest.groovy           |  112 +-
 .../ExceptionExtendsThrowableRuleTest.groovy}      |   36 +-
 .../exceptions/ExceptionNotThrownRuleTest.groovy   |  105 +
 .../MissingNewInThrowStatementRuleTest.groovy      |  153 +-
 .../ReturnNullFromCatchBlockRuleTest.groovy        |  178 +-
 .../exceptions/SwallowThreadDeathRuleTest.groovy   |  218 +-
 .../rule/exceptions/ThrowErrorRuleTest.groovy      |    7 +-
 .../rule/exceptions/ThrowExceptionRuleTest.groovy  |    7 +-
 .../ThrowNullPointerExceptionRuleTest.groovy       |    7 +-
 .../ThrowRuntimeExceptionRuleTest.groovy           |    7 +-
 .../rule/exceptions/ThrowThrowableRuleTest.groovy  |    7 +-
 .../BlankLineBeforePackageRuleTest.groovy          |  113 +
 .../rule/formatting/BracesForClassRuleTest.groovy  |  305 ++-
 .../formatting/BracesForForLoopRuleTest.groovy     |  197 +-
 .../rule/formatting/BracesForIfElseRuleTest.groovy |  215 +-
 .../rule/formatting/BracesForMethodRuleTest.groovy |  461 ++--
 .../BracesForTryCatchFinallyRuleTest.groovy        |  148 +-
 .../rule/formatting/ClassJavadocRuleTest.groovy    |  212 +-
 ...OpeningLineOfMultipleLineClosureRuleTest.groovy |  122 +
 .../ConsecutiveBlankLinesRuleTest.groovy           |  108 +
 .../FileEndsWithoutNewlineRuleTest.groovy}         |   41 +-
 .../rule/formatting/LineLengthRuleTest.groovy      |  193 +-
 .../MissingBlankLineAfterImportsRuleTest.groovy    |   65 +
 .../MissingBlankLineAfterPackageRuleTest.groovy    |  136 ++
 .../rule/formatting/SpaceAfterCatchRuleTest.groovy |   62 +
 .../SpaceAfterClosingBraceRuleTest.groovy          |  289 +++
 .../rule/formatting/SpaceAfterCommaRuleTest.groovy |  293 +++
 .../rule/formatting/SpaceAfterForRuleTest.groovy   |   74 +
 .../rule/formatting/SpaceAfterIfRuleTest.groovy    |   87 +
 .../SpaceAfterOpeningBraceRuleTest.groovy          |  283 +++
 .../formatting/SpaceAfterSemicolonRuleTest.groovy  |  115 +
 .../formatting/SpaceAfterSwitchRuleTest.groovy     |   70 +
 .../rule/formatting/SpaceAfterWhileRuleTest.groovy |   76 +
 .../SpaceAroundClosureArrowRuleTest.groovy         |   84 +
 .../SpaceAroundMapEntryColonRuleTest.groovy        |  123 +
 .../formatting/SpaceAroundOperatorRuleTest.groovy  |  239 ++
 .../SpaceBeforeClosingBraceRuleTest.groovy         |  272 +++
 .../SpaceBeforeOpeningBraceRuleTest.groovy         |  263 +++
 .../formatting/TrailingWhitespaceRuleTest.groovy   |   91 +
 .../rule/generic/IllegalClassMemberRuleTest.groovy |  248 ++
 ...lassReferenceRule_MultipleClassNamesTest.groovy |   72 +-
 ...alClassReferenceRule_SingleClassNameTest.groovy |   90 +-
 ...assReferenceRule_WildcardsClassNamesTest.groovy |  131 +-
 .../generic/IllegalPackageReferenceRuleTest.groovy |  582 ++---
 .../rule/generic/IllegalRegexRuleTest.groovy       |   20 +-
 ...uleTest.groovy => IllegalStringRuleTest.groovy} |  136 +-
 .../rule/generic/IllegalSubclassRuleTest.groovy    |   84 +
 .../rule/generic/RequiredRegexRuleTest.groovy      |    9 +-
 .../rule/generic/RequiredStringRuleTest.groovy     |    8 +-
 .../rule/generic/StatelessClassRuleTest.groovy     |   28 +-
 .../grails/GrailsDomainHasEqualsRuleTest.groovy    |  162 +-
 .../grails/GrailsDomainHasToStringRuleTest.groovy  |  162 +-
 ...ailsDomainReservedSqlKeywordNameRuleTest.groovy |  159 ++
 ...GrailsDomainWithServiceReferenceRuleTest.groovy |   95 +
 .../GrailsDuplicateConstraintRuleTest.groovy       |  197 ++
 .../grails/GrailsDuplicateMappingRuleTest.groovy   |  174 ++
 .../grails/GrailsMassAssignmentRuleTest.groovy     |  135 ++
 .../GrailsPublicControllerMethodRuleTest.groovy    |   32 +-
 .../GrailsServletContextReferenceRuleTest.groovy   |   22 +-
 .../grails/GrailsSessionReferenceRuleTest.groovy   |   23 +-
 .../grails/GrailsStatelessServiceRuleTest.groovy   |   27 +-
 .../groovyism/AssignCollectionSortRuleTest.groovy  |  205 +-
 .../AssignCollectionUniqueRuleTest.groovy          |  154 +-
 .../ClosureAsLastMethodParameterRuleTest.groovy    |  448 ++--
 .../CollectAllIsDeprecatedRuleTest.groovy          |    4 +
 .../ConfusingMultipleReturnsRuleTest.groovy        |  151 +-
 .../ExplicitArrayListInstantiationRuleTest.groovy  |  167 +-
 .../ExplicitCallToAndMethodRuleTest.groovy         |  111 +-
 .../ExplicitCallToCompareToMethodRuleTest.groovy   |  122 +-
 .../ExplicitCallToDivMethodRuleTest.groovy         |  112 +-
 .../ExplicitCallToEqualsMethodRuleTest.groovy      |  117 +-
 .../ExplicitCallToGetAtMethodRuleTest.groovy       |  112 +-
 .../ExplicitCallToLeftShiftMethodRuleTest.groovy   |  112 +-
 .../ExplicitCallToMinusMethodRuleTest.groovy       |  113 +-
 .../ExplicitCallToModMethodRuleTest.groovy         |  113 +-
 .../ExplicitCallToMultiplyMethodRuleTest.groovy    |  115 +-
 .../ExplicitCallToOrMethodRuleTest.groovy          |  110 +-
 .../ExplicitCallToPlusMethodRuleTest.groovy        |  131 +-
 .../ExplicitCallToPowerMethodRuleTest.groovy       |  112 +-
 .../ExplicitCallToRightShiftMethodRuleTest.groovy  |  112 +-
 .../ExplicitCallToXorMethodRuleTest.groovy         |  112 +-
 .../ExplicitHashMapInstantiationRuleTest.groovy    |  167 +-
 .../ExplicitHashSetInstantiationRuleTest.groovy    |  168 +-
 ...plicitLinkedHashMapInstantiationRuleTest.groovy |  167 +-
 .../ExplicitLinkedListInstantiationRuleTest.groovy |  169 +-
 .../ExplicitStackInstantiationRuleTest.groovy      |  169 +-
 .../ExplicitTreeSetInstantiationRuleTest.groovy    |  170 +-
 .../rule/groovyism/GStringAsMapKeyRuleTest.groovy  |    6 +
 .../GStringExpressionWithinStringRuleTest.groovy   |  143 ++
 .../GetterMethodCouldBePropertyRuleTest.groovy     |  363 +--
 .../groovyism/GroovyLangImmutableRuleTest.groovy   |  201 +-
 .../rule/groovyism/UseCollectManyRuleTest.groovy   |    4 +
 .../rule/groovyism/UseCollectNestedRuleTest.groovy |    5 +
 .../rule/imports/DuplicateImportRuleTest.groovy    |   12 +-
 .../imports/ImportFromSamePackageRuleTest.groovy   |    9 +-
 .../imports/ImportFromSunPackagesRuleTest.groovy   |  135 +-
 .../imports/MisorderedStaticImportsRuleTest.groovy |  232 +-
 ...est.groovy => NoWildcardImportsRuleTest.groovy} |   48 +-
 .../imports/UnnecessaryGroovyImportRuleTest.groovy |   14 +
 .../rule/imports/UnusedImportRuleTest.groovy       |   25 +-
 .../jdbc/DirectConnectionManagementRuleTest.groovy |  112 +-
 .../jdbc/JdbcConnectionReferenceRuleTest.groovy    |   78 +-
 .../jdbc/JdbcResultSetReferenceRuleTest.groovy     |   78 +-
 ...ementReferenceRule_CallableStatementTest.groovy |   66 +-
 ...ementReferenceRule_PreparedStatementTest.groovy |   66 +-
 ...JdbcStatementReferenceRule_StatementTest.groovy |   99 +-
 .../codenarc/rule/junit/ChainedTestRuleTest.groovy |  194 +-
 .../rule/junit/CoupledTestCaseRuleTest.groovy      |  178 +-
 .../junit/JUnitAssertAlwaysFailsRuleTest.groovy    |  128 +-
 .../junit/JUnitAssertAlwaysSucceedsRuleTest.groovy |  154 +-
 ...tAssertEqualsConstantActualValueRuleTest.groovy |  115 +
 .../junit/JUnitFailWithoutMessageRuleTest.groovy   |  133 +-
 .../rule/junit/JUnitLostTestRuleTest.groovy        |  131 ++
 .../rule/junit/JUnitPublicFieldRuleTest.groovy     |  103 +
 .../junit/JUnitPublicNonTestMethodRuleTest.groovy  |  436 ++--
 .../rule/junit/JUnitPublicPropertyRuleTest.groovy  |   96 +
 .../rule/junit/JUnitSetUpCallsSuperRuleTest.groovy |   14 +-
 .../rule/junit/JUnitStyleAssertionsRuleTest.groovy |  435 ++--
 .../junit/JUnitTearDownCallsSuperRuleTest.groovy   |   14 +-
 .../JUnitTestMethodWithoutAssertRuleTest.groovy    |  353 +--
 .../junit/JUnitUnnecessarySetUpRuleTest.groovy     |   13 +-
 .../junit/JUnitUnnecessaryTearDownRuleTest.groovy  |   13 +-
 .../JUnitUnnecessaryThrowsExceptionRuleTest.groovy |  187 ++
 .../rule/junit/SpockIgnoreRestUsedRuleTest.groovy  |  284 ++-
 .../rule/junit/UnnecessaryFailRuleTest.groovy      |  325 +--
 ...eAssertEqualsInsteadOfAssertTrueRuleTest.groovy |  181 +-
 .../UseAssertFalseInsteadOfNegationRuleTest.groovy |  149 +-
 ...eAssertNullInsteadOfAssertEqualsRuleTest.groovy |  164 +-
 ...UseAssertSameInsteadOfAssertTrueRuleTest.groovy |  173 +-
 ...eAssertTrueInsteadOfAssertEqualsRuleTest.groovy |  309 +--
 .../UseAssertTrueInsteadOfNegationRuleTest.groovy  |  149 +-
 .../logging/LoggerForDifferentClassRuleTest.groovy |   28 +-
 .../LoggerWithWrongModifiersRuleTest.groovy        |  367 +--
 .../LoggingSwallowsStacktraceRuleTest.groovy       |  191 +-
 .../rule/logging/MultipleLoggersRuleTest.groovy    |  155 +-
 .../rule/logging/PrintStackTraceRuleTest.groovy    |   34 +-
 .../codenarc/rule/logging/PrintlnRuleTest.groovy   |   33 +-
 .../rule/logging/SystemErrPrintRuleTest.groovy     |   12 +-
 .../rule/logging/SystemOutPrintRuleTest.groovy     |   12 +-
 .../rule/naming/AbstractClassNameRuleTest.groovy   |   11 +-
 .../codenarc/rule/naming/ClassNameRuleTest.groovy  |   17 +-
 .../naming/ClassNameSameAsFilenameRuleTest.groovy  |  127 ++
 .../rule/naming/ConfusingMethodNameRuleTest.groovy |  404 ++--
 .../rule/naming/FactoryMethodNameRuleTest.groovy   |  250 ++-
 .../codenarc/rule/naming/FieldNameRuleTest.groovy  |   58 +-
 .../rule/naming/InterfaceNameRuleTest.groovy       |   11 +-
 .../codenarc/rule/naming/MethodNameRuleTest.groovy |   19 +-
 ...jectOverrideMisspelledMethodNameRuleTest.groovy |    7 +
 .../PackageNameMatchesFilePathRuleTest.groovy      |  201 ++
 .../rule/naming/PackageNameRuleTest.groovy         |   25 +-
 .../rule/naming/ParameterNameRuleTest.groovy       |   22 +-
 .../rule/naming/PropertyNameRuleTest.groovy        |   33 +-
 .../rule/naming/VariableNameRuleTest.groovy        |   30 +-
 .../security/FileCreateTempFileRuleTest.groovy     |  190 +-
 .../rule/security/InsecureRandomRuleTest.groovy    |  133 +-
 .../security/JavaIoPackageAccessRuleTest.groovy    |  212 +-
 .../security/NonFinalPublicFieldRuleTest.groovy    |  114 +-
 ...inalSubclassOfSensitiveInterfaceRuleTest.groovy |  293 +--
 .../rule/security/ObjectFinalizeRuleTest.groovy    |  186 +-
 .../security/PublicFinalizeMethodRuleTest.groovy   |  139 +-
 .../rule/security/SystemExitRuleTest.groovy        |  190 +-
 .../security/UnsafeArrayDeclarationRuleTest.groovy |  137 +-
 .../UnsafeImplementationAsMapRuleTest.groovy       |  104 +
 .../EnumCustomSerializationIgnoredRuleTest.groovy  |  106 +
 .../SerialPersistentFieldsRuleTest.groovy          |  235 +-
 .../serialization/SerialVersionUIDRuleTest.groovy  |   25 +-
 ...eClassMustDefineSerialVersionUIDRuleTest.groovy |  145 +-
 .../rule/size/AbcComplexityRuleTest.groovy         |   60 +-
 ...ityRuleTest.groovy => AbcMetricRuleTest.groovy} |  103 +-
 .../codenarc/rule/size/ClassSizeRuleTest.groovy    |   11 +-
 .../codenarc/rule/size/CrapMetricRuleTest.groovy   |  489 ++--
 .../rule/size/CyclomaticComplexityRuleTest.groovy  |  531 +++--
 .../rule/size/GMetricsSourceCodeAdapterTest.groovy |    5 +
 .../codenarc/rule/size/MethodCountRuleTest.groovy  |  143 +-
 .../codenarc/rule/size/MethodSizeRuleTest.groovy   |   25 +-
 .../rule/size/NestedBlockDepthRuleTest.groovy      |   23 +-
 .../rule/size/ParameterCountRuleTest.groovy        |  199 ++
 .../rule/unnecessary/AddEmptyStringRuleTest.groovy |  148 +-
 .../ConsecutiveLiteralAppendsRuleTest.groovy       |  148 +-
 .../ConsecutiveStringConcatenationRuleTest.groovy  |  203 +-
 ...necessaryBigDecimalInstantiationRuleTest.groovy |  189 +-
 ...necessaryBigIntegerInstantiationRuleTest.groovy |  108 +-
 .../UnnecessaryBooleanExpressionRuleTest.groovy    |   16 +-
 .../UnnecessaryBooleanInstantiationRuleTest.groovy |    9 +-
 .../UnnecessaryCallForLastElementRuleTest.groovy   |  194 +-
 .../UnnecessaryCallToSubstringRuleTest.groovy      |  106 +-
 .../unnecessary/UnnecessaryCastRuleTest.groovy     |   70 +
 .../UnnecessaryCatchBlockRuleTest.groovy           |  165 +-
 .../UnnecessaryCollectCallRuleTest.groovy          |  194 +-
 .../UnnecessaryCollectionCallRuleTest.groovy       |  162 +-
 .../UnnecessaryConstructorRuleTest.groovy          |  257 ++-
 ...UnnecessaryDefInFieldDeclarationRuleTest.groovy |  391 ++--
 ...nnecessaryDefInMethodDeclarationRuleTest.groovy |  437 ++--
 ...ecessaryDefInVariableDeclarationRuleTest.groovy |  444 ++--
 .../unnecessary/UnnecessaryDotClassRuleTest.groovy |  133 +-
 .../UnnecessaryDoubleInstantiationRuleTest.groovy  |  123 +-
 .../UnnecessaryElseStatementRuleTest.groovy        |  442 ++--
 .../UnnecessaryFinalOnPrivateMethodRuleTest.groovy |  108 +-
 .../UnnecessaryFloatInstantiationRuleTest.groovy   |  138 +-
 .../unnecessary/UnnecessaryGStringRuleTest.groovy  |  247 +-
 .../unnecessary/UnnecessaryGetterRuleTest.groovy   |  197 +-
 .../UnnecessaryIfStatementRuleTest.groovy          |   45 +-
 .../UnnecessaryInstanceOfCheckRuleTest.groovy      |  153 +-
 ...necessaryInstantiationToGetClassRuleTest.groovy |  131 +-
 .../UnnecessaryIntegerInstantiationRuleTest.groovy |  123 +-
 .../UnnecessaryLongInstantiationRuleTest.groovy    |  123 +-
 .../unnecessary/UnnecessaryModOneRuleTest.groovy   |  112 +-
 ...cessaryNullCheckBeforeInstanceOfRuleTest.groovy |  196 +-
 .../UnnecessaryNullCheckRuleTest.groovy            |  322 +--
 .../UnnecessaryObjectReferencesRuleTest.groovy     |  398 ++--
 .../UnnecessaryOverridingMethodRuleTest.groovy     |  173 +-
 .../UnnecessaryPackageReferenceRuleTest.groovy     |  554 ++---
 ...enthesesForMethodCallWithClosureRuleTest.groovy |  208 +-
 .../UnnecessaryPublicModifierRuleTest.groovy       |  265 +--
 .../UnnecessaryReturnKeywordRuleTest.groovy        |  163 +-
 ...nnecessarySafeNavigationOperatorRuleTest.groovy |  118 +
 .../UnnecessarySelfAssignmentRuleTest.groovy       |  159 +-
 .../UnnecessarySemicolonRuleTest.groovy            |  277 +--
 .../UnnecessaryStringInstantiationRuleTest.groovy  |    8 +-
 .../UnnecessarySubstringRuleTest.groovy            |  131 +-
 .../UnnecessaryTernaryExpressionRuleTest.groovy    |   17 +-
 .../unnecessary/UnnecessaryToStringRuleTest.groovy |  113 +
 .../UnnecessaryTransientModifierRuleTest.groovy    |  159 +-
 .../rule/unused/UnusedArrayRuleTest.groovy         |  165 +-
 .../unused/UnusedMethodParameterRuleTest.groovy    |  473 ++--
 .../rule/unused/UnusedObjectRuleTest.groovy        |  239 +-
 .../rule/unused/UnusedPrivateFieldRuleTest.groovy  |  834 +++----
 .../UnusedPrivateMethodParameterRuleTest.groovy    |   15 +-
 .../rule/unused/UnusedPrivateMethodRuleTest.groovy |   48 +-
 .../rule/unused/UnusedVariableRuleTest.groovy      |  103 +-
 .../PropertiesFileRuleRegistryTest.groovy          |    5 +-
 .../RuleRegistryInitializerTest.groovy             |    4 +-
 .../codenarc/ruleset/CompositeRuleSetTest.groovy   |   24 +-
 .../codenarc/ruleset/FilteredRuleSetTest.groovy    |   34 +-
 .../codenarc/ruleset/GroovyDslRuleSetTest.groovy   |   16 +-
 .../org/codenarc/ruleset/ListRuleSetTest.groovy    |   12 +-
 .../ruleset/LoadAllPredefinedRuleSetsTest.groovy   |   14 +-
 .../org/codenarc/ruleset/MovedRulesTest.groovy     |   11 +
 .../PropertiesFileRuleSetConfigurerTest.groovy     |   16 +-
 .../org/codenarc/ruleset/RuleSetBuilderTest.groovy |   46 +-
 .../org/codenarc/ruleset/RuleSetUtilTest.groovy    |   21 +-
 .../org/codenarc/ruleset/XmlFileRuleSetTest.groovy |   19 +-
 .../XmlReaderRuleSetSchemaValidationTest.groovy    |   23 +-
 .../codenarc/ruleset/XmlReaderRuleSetTest.groovy   |   38 +-
 .../CustomCompilerPhaseSourceDecoratorTest.groovy  |   59 +
 .../codenarc/source/SourceCodeCriteriaTest.groovy  |   28 +-
 .../org/codenarc/source/SourceFileTest.groovy      |   27 +-
 .../org/codenarc/source/SourceStringTest.groovy    |   50 +-
 .../org/codenarc/test/AbstractTestCase.groovy      |  140 --
 .../RunCodeNarcAgainstProjectSourceCodeTest.groovy |   14 +-
 .../org/codenarc/test/SiteDocumentationTest.groovy |  112 +-
 .../GenerateCodeNarcRulesPropertiesTest.groovy     |    4 +-
 .../codenarc/tool/GenerateRuleIndexPageTest.groovy |    7 +-
 .../GenerateRuleSetAllRulesByCategoryTest.groovy   |    8 +-
 .../tool/GenerateRuleSetAllRulesTest.groovy        |    5 +-
 .../tool/RunCodeNarcAgainstExternalProject.groovy  |   67 +
 .../codenarc/tool/RunCodeNarcAgainstGrails.groovy  |    2 +-
 .../groovy/org/codenarc/util/AstUtilTest.groovy    |   87 +-
 .../groovy/org/codenarc/util/ImportUtilTest.groovy |   13 +-
 .../org/codenarc/util/ModifiersUtilTest.groovy     |  145 ++
 .../groovy/org/codenarc/util/PathUtilTest.groovy   |    9 +-
 .../org/codenarc/util/PropertyUtilTest.groovy      |   40 +-
 .../org/codenarc/util/SourceCodeUtilTest.groovy    |  239 +-
 .../org/codenarc/util/WildcardPatternTest.groovy   |    9 +-
 .../codenarc/util/io/ClassPathResourceTest.groovy  |   16 +-
 .../util/io/DefaultResourceFactoryTest.groovy      |   15 +-
 .../org/codenarc/util/io/UrlResourceTest.groovy    |   15 +-
 src/test/java/Placeholder.txt                      |    0
 ...t => RunCodeNarcAgainstExternalProject.ruleset} |    4 +-
 .../RunCodeNarcAgainstProjectSourceCode.properties |   59 +-
 .../RunCodeNarcAgainstProjectSourceCode.ruleset    |   52 +-
 src/test/resources/SampleFile.groovy               |    2 +-
 src/test/resources/rule/ClassJavadocFail.txt       |  188 --
 src/test/resources/rule/ClassJavadocPass.txt       |  193 --
 src/test/resources/rulesets/CustomRuleSet.groovy   |    2 +-
 src/test/resources/rulesets/GroovyRuleSet1.groovy  |    2 +-
 src/test/resources/rulesets/RuleSet1.xml           |    2 +-
 src/test/resources/source/SourceFile1.groovy       |    2 +-
 src/test/resources/source/SourceFile2.groovy       |    2 +-
 .../resources/sourcewithdirs/SourceFile1.groovy    |    2 +-
 .../sourcewithdirs/subdir1/Subdir1File1.groovy     |    2 +-
 .../sourcewithdirs/subdir1/Subdir1File2.groovy     |    2 +-
 .../sourcewithdirs/subdir2/Subdir2File1.groovy     |    2 +-
 .../subdir2/subdir2a/Subdir2aFile1.groovy          |    2 +-
 915 files changed, 70218 insertions(+), 54349 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-java/codenarc.git



More information about the pkg-java-commits mailing list