[Git][java-team/ciftools-java][master] 2 commits: Skipping comparisons of gzipped files in the writeBinary test

[Pierre Gruet (@pgt)]

Pierre Gruet pushed to branch master at Debian Java Maintainers / ciftools-java


Commits:
879c193c by Pierre Gruet at 2022-11-10T08:59:40+01:00
Skipping comparisons of gzipped files in the writeBinary test

- - - - -
b69be863 by Pierre Gruet at 2022-11-10T08:59:53+01:00
Upload to unstable

- - - - -


3 changed files:

- debian/changelog
- debian/patches/series
- + debian/patches/switch_to_openjdk-17.patch


Changes:

=====================================
debian/changelog
=====================================
@@ -1,3 +1,10 @@
+ciftools-java (4.0.3-2) unstable; urgency=medium
+
+  * Skipping the comparison of gzipped files in test, after discussing the
+    issue upstream (Closes: #1012093)
+
+ -- Pierre Gruet <pgt at debian.org>  Thu, 10 Nov 2022 08:59:45 +0100
+
 ciftools-java (4.0.3-1) unstable; urgency=medium
 
   * New upstream version 4.0.3


=====================================
debian/patches/series
=====================================
@@ -1 +1,2 @@
 deactivate_tests_using_network.patch
+switch_to_openjdk-17.patch


=====================================
debian/patches/switch_to_openjdk-17.patch
=====================================
@@ -0,0 +1,28 @@
+Description: omitting the comparison of gzipped files as innocuous
+ discrepancies appeared when switching to OpenJDK17. Upstream will fix this in
+ an upcoming version.
+Author: Pierre Gruet <pgt at debian.org>
+Bug: https://github.com/rcsb/ciftools-java/issues/12
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012093
+Forwarded: https://github.com/rcsb/ciftools-java/issues/12
+Last-Update: 2022-11-10
+
+--- a/src/test/java/org/rcsb/cif/WriterTest.java
++++ b/src/test/java/org/rcsb/cif/WriterTest.java
+@@ -199,13 +199,13 @@
+         byte[] outputGzip = CifIO.writeBinary(binary, CifOptions.builder().gzip(true).build());
+ 
+         assertEquals(new String(original), new String(output), "failed for " + testCase);
+-        assertEquals(new String(originalGzip), new String(outputGzip), "failed (gzip) for " + testCase);
++        //assertEquals(new String(originalGzip), new String(outputGzip), "failed (gzip) for " + testCase);
+ 
+         // cannot match to David's bcif data as column types differ slightly
+         assertArrayEquals(original, output, "binary write output does not match snapshot of output - did the implementation change?" +
+                 " if so, update snapshot files in snapshot/");
+-        assertArrayEquals(originalGzip, outputGzip, "binary write output does not match snapshot of output - did the implementation change?" +
+-                " if so, update snapshot files in snapshot/");
++        /*assertArrayEquals(originalGzip, outputGzip, "binary write output does not match snapshot of output - did the implementation change?" +
++                " if so, update snapshot files in snapshot/");*/
+     }
+ 
+     @Test



View it on GitLab: https://salsa.debian.org/java-team/ciftools-java/-/compare/b1e8d7a47c54727893c88a0aad0ba1678832413f...b69be86389965aecd4e73385be2802acb970c3ed

-- 
View it on GitLab: https://salsa.debian.org/java-team/ciftools-java/-/compare/b1e8d7a47c54727893c88a0aad0ba1678832413f...b69be86389965aecd4e73385be2802acb970c3ed
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-java-commits/attachments/20221110/098a4118/attachment.htm>