Bug#552621: antlr3: Enable testsuite (and fix resulting failures)

Wed Oct 28 11:08:27 UTC 2009

On Tue, Oct 27, 2009 at 03:42:20PM +0100, Michael Terry wrote:
> Package: antlr3
> Version: 3.0.1+dfsg-4
> Severity: normal
> Tags: patch
> User: ubuntu-devel at lists.ubuntu.com
> Usertags: origin-ubuntu karmic ubuntu-patch
> 
> I was looking into enabling the testsuite in Ubuntu, and the attached diff will do so.  Thought you might be interested in doing the same.
> 
> However, running it, there were 14 failures.  Presumably those are upstream failures.
> 
> So obviously, this patch shouldn't be applied without also fixing those failures.  But ideally both would happen.  :)
> 
> -- System Information:
> Debian Release: squeeze/sid
>   APT prefers karmic-updates
>   APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic')
> Architecture: i386 (i686)
> 
> Kernel: Linux 2.6.31-14-generic (SMP w/2 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash

> diff -u antlr3-3.0.1+dfsg/debian/rules antlr3-3.0.1+dfsg/debian/rules
> [31m--- antlr3-3.0.1+dfsg/debian/rules[m
> [32m+++ antlr3-3.0.1+dfsg/debian/rules[m
> [34m@@ -13,7 +13,8 @@[m
>  
>  JAVA_HOME := /usr/lib/jvm/default-java
>  ANT_OPTS = -Dant.build.javac.source=1.4
> [31m-DEB_JARS := ant-antlr antlr junit[m
> [32m+DEB_JARS := ant-antlr antlr junit ant-junit ant-trax[m
> [32m+DEB_ANT_CHECK_TARGET = test[m
>  
>  build/antlr3::
>  	install -m 644 -D build/antlr.jar \

Thanks for this patch. The problem is that I'm currently working on a new
upstream version. Upstream changed from Ant to Maven as build system.
This makes your patch unusable. But the idea is generally good. I will
look into into enabling testsuite running in the new package too.

Cheers,
Michael