[Pkg-javascript-commits] [node-leveldown] 305/492: moar tests for empty iterator start/end

[Andrew Kelley]

This is an automated email from the git hooks/post-receive script.

andrewrk-guest pushed a commit to annotated tag rocksdb-0.10.1
in repository node-leveldown.

commit 6a030129de1957d3c26efaeed8d9dc6060659cf0
Author: Rod Vagg <rod at vagg.org>
Date:   Mon Apr 8 09:29:58 2013 +1000

    moar tests for empty iterator start/end
---
 test/iterator-test.js | 65 +++++++++++++++++++++++++++++----------------------
 1 file changed, 37 insertions(+), 28 deletions(-)

diff --git a/test/iterator-test.js b/test/iterator-test.js
index 99fd824..1a49c07 100644
--- a/test/iterator-test.js
+++ b/test/iterator-test.js
@@ -384,35 +384,44 @@ module.exports.iterator = function (leveldown) {
     })
   })
 
-  test('test iterator with start as empty buffer', function(t) {
-    collectEntries(db.iterator({ keyAsBuffer: false, valueAsBuffer: false, start: new Buffer(0)}), function (err, data) {
-      t.notOk(err, 'no error')
-      t.equal(data.length, 100, 'correct number of entries')
-      var expected = sourceData.map(transformSource)
-      t.deepEqual(data, expected)
-      t.end()
-    })
-  })
-
-  test('test iterator with end as empty string', function(t) {
-    collectEntries(db.iterator({ keyAsBuffer: false, valueAsBuffer: false, end: ''}), function (err, data) {
-      t.notOk(err, 'no error')
-      t.equal(data.length, 100, 'correct number of entries')
-      var expected = sourceData.map(transformSource)
-      t.deepEqual(data, expected)
-      t.end()
-    })
-  })
-
-  test('test iterator with end as empty string', function(t) {
-    collectEntries(db.iterator({ keyAsBuffer: false, valueAsBuffer: false, end: new Buffer(0)}), function (err, data) {
-      t.notOk(err, 'no error')
-      t.equal(data.length, 100, 'correct number of entries')
-      var expected = sourceData.map(transformSource)
-      t.deepEqual(data, expected)
-      t.end()
+  function testIteratorCollectsFullDatabase (name, iteratorOptions) {
+    iteratorOptions.keyAsBuffer   = false
+    iteratorOptions.valueAsBuffer = false
+    test(name, function (t) {
+      collectEntries(db.iterator(iteratorOptions), function (err, data) {
+        t.notOk(err, 'no error')
+        t.equal(data.length, 100, 'correct number of entries')
+        var expected = sourceData.map(transformSource)
+        t.deepEqual(data, expected)
+        t.end()
+      })
     })
-  })
+  }
+
+  testIteratorCollectsFullDatabase(
+      'test iterator with start as empty buffer'
+    , { start: new Buffer(0) }
+  )
+  testIteratorCollectsFullDatabase(
+      'test iterator with start as empty string'
+    , { start: '' }
+  )
+  testIteratorCollectsFullDatabase(
+      'test iterator with start as null'
+    , { start: null }
+  )
+  testIteratorCollectsFullDatabase(
+      'test iterator with end as empty buffer'
+    , { end: new Buffer(0) }
+  )
+  testIteratorCollectsFullDatabase(
+      'test iterator with end as empty string'
+    , { end: '' }
+  )
+  testIteratorCollectsFullDatabase(
+      'test iterator with end as null'
+    , { end: null }
+  )
 }
 
 module.exports.tearDown = function () {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/node-leveldown.git