[Pkg-javascript-devel] New jquery-lazyload version 1.8.0 - please review

[Emilien Klein]

Hi Marcelo,
Le 16 nov. 2012 15:42, "Marcelo Jorge Vieira" <metal at debian.org> a écrit :
>
> Hi Emilien,
>
> On Wed, 2012-10-31 at 15:49 +0100, Emilien Klein wrote:
> > 2012/10/29 Marcelo Jorge Vieira <metal at debian.org>:
> > > Hi Emilien,
> > >
> > > On Mon, 2012-10-29 at 15:53 +0100, Emilien Klein wrote:
> > >> Hi team,
> > >>
> > >> 2012/9/30 Emilien Klein <emilien+debian at klein.st>:
> > >> > Hi JS team,
> > >> >
> > >> > I've updated jquery-lazyload's git repo [0] with its latest version 1.8.0.
> > >> > It would be nice if one of you could review it, and if everything is
> > >> > OK, upload it.
> > >>
> > >> Could somebody have a look at this new version, and upload it?
> > >
> > > I will do it.
> >
> > Thanks Marcelo.
> >    +Emilien
>
> My review:

Thanks for your review.

> 1) Minified files:

Will do.
What is the best way to automate the repackaging? I've seen some
mentions of `debian/rules get-orig-source`, would you be able to point
me to some good example (I assume inside the js team we have some good
example of exactly this, removing minified files and repackaging)

> 1.1) source tarball: You must remove all minified files
>      (jquery.lazyload.min.js and jquery.scrollstop.min.js)
>      and repack the tarball.
>
> 1.2) changelog: Add suffix +dfsg to the upstream version number:
>      1.8.0+dfsg-1;
>
> 1.3) watch: Mangle the upstream version;
>
> 1.4) rules: Minify jquery.lazyload.js and jquery.scrollstop.js
>
>
> 2) README.Debian
>
> 2.1) I guess you forgot it:
>
>      <img class="lazy" src="img/grey.gif"
>      data-original="img/example.jpg"  width="640" heigh="480">

Good point

>
> 3) examples:
>
> 3.1) Would be interesting you install the examples

I thought about it when first packaging, but those example include
pictures (from the author?), which:
- increase the size of the package (upstream tarball is 1.6Mb,
repackaged without the images is 12,6 Kb): it feels unnecessary for
just a little js library to have "such a large" package downloaded
- licensing of these images is unclear : if we worry about having
minified js in the *source* package (which doesn't end in the binary
package, as the source files get minified by `debian/rules
override_dh_auto_build`), shouldn't we worry about those imaging
getting in the binary package?

I had contacted upstream about the licensing of these images, but
never got an answer and kind of dropped the pressure.

Question: would it make sense to include the examples *without* the
images? That way developers could still see the source code... If
going that route, I assume getting those images out of the source
tarball when repackaging would be OK, please advise.

Upstream has released a new version, I'll update the package to 1.8.1.

Thanks for your time,
    +Emilien