[Pkg-javascript-devel] node-iconv-2.1.0 done

[Matthew Pideil]

Le 05/05/2014 11:48, Jérémy Lal a écrit :
> Le lundi 05 mai 2014 à 10:52 +0200, Matthew Pideil a écrit :
>> Hi team,
>>
>> I've packaged node-iconv usefull for iconv-lite build.
>> Can you review it ?
>> It packages also https://www.gnu.org/software/libiconv/
>>
>> The files are on
>> https://alioth.debian.org/anonscm/git/pkg-javascript/node-iconv.git
> You forgot to push upstream branch.
The pristine-tar branch isn't enough ?
>
> This:
> lib/iconv.js              /usr/lib/nodejs/
> build/Release/iconv.node  /usr/lib/nodejs/iconv
>
> should better be:
> lib/iconv.js              /usr/lib/nodejs/iconv/
> build/Release/iconv.node  /usr/lib/nodejs/iconv/
>
> Also it'd be nice to include package.json, in which case you'd need to
> either:
>
> * install lib directory instead of lib/iconv.js
> * if not, fix the "main" path in package.json
> * or add debian/links with
>   usr/lib/nodejs/iconv/iconv.js usr/lib/nodejs/iconv/index.js
I don't understand what you suggest:
  How your first proposal will be understand without an index.js in
/usr/lib/nodejs/iconv/ ?
  Is the package.json file interpreted and if so by 'who' ?

> I'm in favor of the first choice.
>
> Thank you.
>
> Jérémy.

Thank you,

 Matthew