[Pkg-javascript-devel] Bug#740893: libjs-jquery-hotkeys: Incompatible ABI change

[Philipp Matthias Hahn]

Hello Ben,

On Sun, Apr 09, 2017 at 12:41:50PM +1000, Ben Finney wrote:
> So the <URL:https://github.com/jeresig/jquery.hotkeys> and the
> <URL:https://github.com/tzuryby/jquery.hotkeys> repositories have
> diverged, incompatibly. I didn't know that :-/
...
> I count 6 binary packages:
> 
> =====
> $ apt-cache rdepends libjs-jquery-hotkeys
> libjs-jquery-hotkeys
> Reverse Depends:
>   libghc-gitit-data
>   python3-pytest-cov
>   python-pytest-cov
>   python3-coverage
>   python-coverage
>   prometheus
> =====
> 
> The source packages are:
> 
> * gitit
> * python-coverage
> * python-pytest-cov
> * prometheus
> 
> Why are we getting different sets of packages that use
> ‘libjs-jquery-hotkeys’?

'python-pytest-cov' is a wrapper for 'py.test'; it uses
'python-coverage' internally and only the later one contains the JS
code.

> > Doing some source code `grep -n -r "[.]bind([\"']key"`:
> 
> When I use the pattern ‘[.]bind\(["']key’ for each of those source
> packages with <URL:https://codesearch.debian.net/>, I get a different
> set.
> 
> These queries show matches:
> 
> <URL:https://codesearch.debian.net/search?q=[.]bind\%28[%22%27]key+package%3Agitit>
> <URL:https://codesearch.debian.net/search?q=[.]bind\%28[%22%27]key+package%3Apython-coverage>
> <URL:https://codesearch.debian.net/search?q=[.]bind\%28[%22%27]key+package%3Aprometheus>
> 
> This does not:
> 
> <URL:https://codesearch.debian.net/search?q=[.]bind\%28[%22%27]key+package%3Apython-pytest-cov>
> 
> Does that mean ‘python-pytest-cov’ is not using the ‘jeresig’ API?

It only is a wrapper for 'pyhton-coverage', which is the real user.
(I did a `apt-get source python-pytest-cov`, which shows no direct
match, by it uses 'python-coverage' as a Build-Depends-Indep, so I
guesst it's pulled in that way.)

> Is there a better regex pattern to use to determine what API is used?
> 
> > So all of them use the "jeresig" API, but 'libjs-jquery-hotkeys'
> > packages the "tzuryby" API.
> 
> We get differing results, so I'd like to better understand before
> choosing how to resolve this.

<https://codesearch.debian.net/search?q=[.]bind[%28][%22%27]key+filetype%3Ajabascript&perpkg=1>
shows more users and even users of the 'tzuryby' API, but they don't
seem to use your package but use their own packaging or it is some other
'bind' function not related to 'jquery-hotkeys' at all.

I think you can concentrate on those packages in Debian, which directly
depends on your package and just ignore the other hits of '.bind("key'.

Philipp
-- 
Philipp Matthias Hahn <pmhahn at debian.org>
0xF50EFDCF8AD04B1A @ keyrings.debian.org