[Pkg-libburnia-devel] Bug#1013313: libisoburn: Add autopkgtest

[Thomas Schmitt]

Hi,

Dominique Dumont wrote:
> You may want to log this case which leads to a test failure

I understand that George Danchev considered the output of grep enough
of a message:

          grep -n -E "${LIST_KWD}" "${CLOG}"
          RET_GREP="$?"
          ok=0
          case ${RET_GREP} in
              0) # found
                 ;;

With two dummy failure lines appended to the test log the messages end by:

  ...
  run_all_auto: Trivial log examination: releng_generated_data/log.run_all_auto
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  254:Dummy SORRY
  255:Dummy FAIL
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ...

With a successful test run it looks like:

  ...
  run_all_auto: Trivial log examination: releng_generated_data/log.run_all_auto
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  run_all_auto: Log file looks clear.
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ...


I think it would be better to add a final message by:
----------------------------------------------------------
@@ -259,5 +269,13 @@ fi
  ls -lth "${GEN_DATA_DIR}" # | tee -a ${CLOG}

  # Fin
+ if test "$exit_value" = 0
+ then
+       echo "${SELF}: +++ Test run and its log look like success."
+ else
+       echo
+       echo "${SELF}: --- Test run detected some failures."
+       echo
+ fi
  exit $exit_value
----------------------------------------------------------


> https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst

Since you don't object i assume that you are ok with the proposed new file
  debian/tests/control


> An alternative is to run these tests in debian/rules so they are run at
> package build time.
> This assumes that these tests are reliable.

As upstream, i don't think that releng/run_all_auto should be run at
package build time. I run them locally before each upstream release.


Whatever:

The following tests are made by releng/run_all_auto :
  ./auto_cxx
    Exercises inclusion of xorriso/xorriso.h and libisoburn/libisoburn.h
    in C++ programs and linking of the libraries.
  ./auto_isocontent
    Tests whether xorriso is able to record and restore two families of
    hard links.
  ./auto_printsize
    Tests how long xorriso needs to compose a medium sized directory tree.
    If programs mkisofs and/or genisomage are available, then the same test
    is done with them.
See also
  https://sources.debian.org/src/libisoburn/1.5.4-2/releng/README/#L141

They cost about 10 seconds on a 3.5 GHz Xeon CPU.

Currently the only test at Debian package build-time is a run of

  xorriso/xorriso -no_rc -version -list_extras all

which is probably triggered as upstream makefile target "check-local".
(I fail to find the trigger of "make check" in ./debian.)
The reason for this run is mainly to get into the buildd logs a report
about the characteristics of the produced binary.


Have a nice day :)

Thomas