Bug#771797: liblldb-3.5: does not ship SONAME link /usr/lib/<triplet>/liblldb.so.1 -> liblldb-3.5.so.1

[Andreas Beckmann]

Control: tag -1 patch

On 2014-12-02 15:51, Sylvestre Ledru wrote:
> On 02/12/2014 06:13, Andreas Beckmann wrote:
>> Setting the severity to serious since this file was previously shipped
>> by at least one other package (lldb-3.3) but liblldb-3.5 misses
>> appropriate Breaks/Conflicts+Replaces. (#769113)
> Not sure I understand the severity. This is a different package from
> lldb-3.3.

lldb-3.3 shipped /usr/lib/x86_64-linux-gnu/liblldb.so.1

liblldb-3.5 should ship /usr/lib/x86_64-linux-gnu/liblldb.so.1
because it is the soname link expected by ldconfig (and created if missing)

two packages shipping the same file are not co-installable and need
breaks+repalces (and there seems to be nothing in place that ensures the
obsolete lldb-3.3 is gone when installing 3.5)

If there were other packages shipping liblldb.so.1, they should get
Breaks/Replaces, too. What about lldb-3.4 or liblldb-3.4?

Hmm,
* liblldb-3.4 ships a library with SONAME liblldb-3.4.so
* liblldb-3.5 ships a library with SOANME liblldb.so.1
* liblldb-3.6 ships a libarry with SONAME liblldb-3.6.so

Attached is an untested patch (just started compiling).

You may consider removing the Multi-Arch:same for a (Closes: #765591)
Since the package ships symlinks in /usr/lib/llvm* that point to
/usr/lib/<triplet>/, the package cannot be multi-arch co-installable.


Andreas
-------------- next part --------------
diff -Nru llvm-toolchain-3.5-3.5/debian/changelog llvm-toolchain-3.5-3.5/debian/changelog
--- llvm-toolchain-3.5-3.5/debian/changelog	2014-10-15 18:16:59.000000000 +0200
+++ llvm-toolchain-3.5-3.5/debian/changelog	2014-12-03 03:31:29.000000000 +0100
@@ -1,3 +1,12 @@
+llvm-toolchain-3.5 (1:3.5-7) UNRELEASED; urgency=medium
+
+  * liblldb-3.5: Ship SONAME link liblldb.so.1 -> liblldb-3.5.so.1
+    (Closes: #771797)
+  * liblldb-3.5: Breaks+Replaces: lldb-3.3 due to file conflict on
+    liblldb.so.1.  (Closes: #769113)
+
+ -- Andreas Beckmann <anbe at debian.org>  Wed, 03 Dec 2014 03:12:29 +0100
+
 llvm-toolchain-3.5 (1:3.5-6) unstable; urgency=medium
 
   * Ignore a test failing under i386.
diff -Nru llvm-toolchain-3.5-3.5/debian/control llvm-toolchain-3.5-3.5/debian/control
--- llvm-toolchain-3.5-3.5/debian/control	2014-10-04 17:35:18.000000000 +0200
+++ llvm-toolchain-3.5-3.5/debian/control	2014-12-03 03:19:40.000000000 +0100
@@ -401,8 +401,8 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}, libllvm3.5 (= ${binary:Version})
 Pre-Depends: ${misc:Pre-Depends}
 Section: libs
-Replaces: lldb-3.5 (<< 1:3.5~+rc4-2~)
-Breaks: lldb-3.5 (<< 1:3.5~+rc4-2~)
+Replaces: lldb-3.5 (<< 1:3.5~+rc4-2~), lldb-3.3
+Breaks: lldb-3.5 (<< 1:3.5~+rc4-2~), lldb-3.3
 Description: Next generation, high-performance debugger, library
  LLDB is a next generation, high-performance debugger. It is built as a set of
  reusable components which highly leverage existing libraries in the larger LLVM
diff -Nru llvm-toolchain-3.5-3.5/debian/liblldb-X.Y.links.in llvm-toolchain-3.5-3.5/debian/liblldb-X.Y.links.in
--- llvm-toolchain-3.5-3.5/debian/liblldb-X.Y.links.in	2014-09-01 21:11:16.000000000 +0200
+++ llvm-toolchain-3.5-3.5/debian/liblldb-X.Y.links.in	2014-12-03 03:14:56.000000000 +0100
@@ -1,5 +1,5 @@
 usr/lib/@DEB_HOST_MULTIARCH@/liblldb- at LLVM_VERSION@.so.1               usr/lib/@DEB_HOST_MULTIARCH@/liblldb- at LLVM_VERSION@.so
 usr/lib/@DEB_HOST_MULTIARCH@/liblldb- at LLVM_VERSION@.so.1               usr/lib/@DEB_HOST_MULTIARCH@/liblldb- at LLVM_VERSION@.so.1
+usr/lib/@DEB_HOST_MULTIARCH@/liblldb- at LLVM_VERSION@.so.1               usr/lib/@DEB_HOST_MULTIARCH@/liblldb.so.1
 usr/lib/@DEB_HOST_MULTIARCH@/liblldb- at LLVM_VERSION@.so         usr/lib/python2.7/dist-packages/lldb- at LLVM_VERSION@/_lldb.so
 usr/lib/@DEB_HOST_MULTIARCH@/liblldb- at LLVM_VERSION@.so.1       usr/lib/llvm- at LLVM_VERSION@/lib/liblldb.so.1
-