Bug#1025343: z3: Please link against -latomic for "riscv64" arch

[Manuel A. Fernandez Montecelo]

Control: tags -1 +pending

Hi again,

2023-01-15 23:30 Manuel A. Fernandez Montecelo:
>On Fri, 2 Dec 2022 at 22:45, Manuel A. Fernandez Montecelo
><mafm at debian.org> wrote:
>>
>> Source: z3
>> Version: 4.8.12-3
>> Severity: wishlist
>> Tags: ftbfs patch
>> User: debian-riscv at lists.debian.org
>> Usertags: riscv64
>> X-Debbugs-Cc: mafm at debian.org, debian-riscv at lists.debian.org
>>
>> Hi,
>>
>> The package needs to link against libatomic in this architecture, with the patch
>> attached or an equivalent.
>>
>> I built it successfully on local hardware.
>
>Gentle ping?
>
>It would be nice to have this patch applied so the package would build
>successfully in the case of binNMUs, or new revisions of the package
>that would fix other problems (e.g. future NMUs), etc.

I am preparing a NMU (debdiff attached, basically the same as in the
initial request), the reason being that riscv64 might be bootstrapped at
some point in the next months and z3 is an important package for that,
due to LLVM packages depending on it.

And I am planning to upload to delayed/5, because in the second deadline
of the freeze is very close and so to not get caught up in last-minute
queues.

The initial request was on Dec 2 with a ping on Jan 15, so I think that
it's reasonable to use this delay now.

But if there's any problem or concern, and want me to
speed-up/delay-longer/cancel the NMU, please speak up.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>
-------------- next part --------------
diff -Nru z3-4.8.12/debian/changelog z3-4.8.12/debian/changelog
--- z3-4.8.12/debian/changelog	2022-10-21 19:24:40.000000000 +0200
+++ z3-4.8.12/debian/changelog	2023-02-01 13:06:03.000000000 +0100
@@ -1,3 +1,10 @@
+z3 (4.8.12-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * riscv64: link against -latomic (Closes: #1025343)
+
+ -- Manuel A. Fernandez Montecelo <mafm at debian.org>  Wed, 01 Feb 2023 13:06:03 +0100
+
 z3 (4.8.12-3) unstable; urgency=medium
 
   * Do not use SSE2 unconditionally on i386
diff -Nru z3-4.8.12/debian/rules z3-4.8.12/debian/rules
--- z3-4.8.12/debian/rules	2022-10-21 15:51:13.000000000 +0200
+++ z3-4.8.12/debian/rules	2023-02-01 13:04:59.000000000 +0100
@@ -6,6 +6,10 @@
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 export DEB_CXXFLAGS_MAINT_APPEND = -fPIC -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3
 
+ifeq ($(DEB_HOST_ARCH),riscv64)
+export DEB_LDFLAGS_MAINT_APPEND = -Wl,--no-as-needed -Wl,-latomic -Wl,--as-needed
+endif
+
 DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
 
 ifneq (,$(shell dh_listpackages -a | grep libz3-jni))