pd-zexy review (was Re: [SCM] pd-zexy/master: preserve autom4te.cache)

[IOhannes m zmoelnig]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2011-09-29 18:36, Jonas Smedegaard wrote:
> 
> Debian Policy requires documenting in changelog all packaging changes 
> that affect the final installation at the user end - i.e. no need to 
> document spelling changes to comments in build scripts, or to document 
> changes that got rolled back again or superceded by later changes.
> 
> So in this case, you are supposed to document that you added this 
> build-dependency.  Yes, CDBS added it automagically for you, but it does 
> not mess with changelog for you: that's your responsibility.
> 
> autotools-dev is used to pull in up-to-date config.* files at build 
> time.

thanks for this info.
documentation is probably cdbs's greatest showstopper...

> You committed changes to copyright and copyright_hints together.

i did.
i usually try to avoid that, but sometimes it happens...

> A license shortname must be a single word. "MIT/X11 (BSD like)" is not a 
> single word.

i couldn't actually see this from DEP5 description, but nevertheless it
makes sense.
the name was suggested by licensecheck.

> Also, Public Domain is not a real license nor an ownership, so (in my 
> understanding) should only be listed when the sole "license" for a work.

well, given that FSF added a notice that their amendments are
"public-domain", should we simply ignore this?
(i'm fine with that too)

> 
> Also, I recommend wrapping at 72 chars (not important, just nitpicking).

applied.

> 
> Also, a trailing space has crept in at "Files: ./configure " (not 
> important, just nitpicking).

applied.
(i like nitpicking as it is usually easy to fix)

> 
> I therefore suggest using Expat~X as license shortname, and move the 
> last paragraph up as part of the file listing, like this:
> 
> Files: install-sh
> Copyright: 1994, X Consortium
> License: Expat~X with X exception
>  Except as contained in this notice, the name of the X Consortium shall 
>  not be used in advertising or otherwise to promote the sale, use or 
>  other dealings in this Software without prior written authorization 
>  from the X Consortium.

applied.

> config.guess, config.sub and some other files do not exactly use GPL-2+ 
> as licensing, but adds an Autoconf exception.

hopefully fixed.

fgmasdr
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6EsFcACgkQkX2Xpv6ydvTkjACfQPwACqIOPwrm907CwClgXoTZ
PwkAnRHtaBuvz6DC/ihe3EVmmuk0Oo7F
=ZnLz
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3636 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20110929/26fb4908/attachment.bin>