Please review my package

[IOhannes m zmoelnig]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2012-07-05 11:52, IOhannes m zmoelnig wrote:
> On 2012-07-05 10:47, wbrana wrote:
> 
> - you have "Debian Multimedia Maintainers" set as the maintainer. 
> p-m-m has a few rules, on how packaging is done.
> 
> e.g., all the pacakging in a git repository hosted at
> git.debian.org (you need to become team member, if you want to use
> that infrastructure)

obviously i rephrased this paragraph and (the little that is left of
my english) syntax went missing...
anyhow:the d-m-m team uses "git" to do the packaging. you should
consider doing the same.

> 
> - please use a machine-parseable debian/copyright, using DEP-5 [2]
> format
> 

and of course the debian/copyright as it is lacks all the necessary
information.
what is the license of the upstream package? (the fact that there is a
COPYING files in the upstream code is _not_ enough; you must make the
licenseS (there might be more) explicit in debian/copyright)
who are the upstream copyright holders?
you claim copyright for yourself, but nobody knows which files are
covered by your copyright.
the first file i inspected a bit closer ("./gch.py") is "Copyright
2006 Tim Blechmann", who afaik is not you.
"./ebuild" is "Copyright 1999-2012 Gentoo Foundation" which is not you
either.

if you have contact with upstream, you might convince them to add
proper copyright information in all the source files.

fgamsr
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/1Zw4ACgkQkX2Xpv6ydvQNngCgxsoHwmoNEBXyO9BW2AqDp2Zm
xawAniMjMG2qcgxPBjnCSRqh9IQxb8an
=3r0i
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2320 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120705/63d01a3f/attachment.bin>