Pyliblo - python3-liblo

[Sebastian Ramacher]

Hi Jaromir,

On 2013-08-25 21:14:12, Jaromír Mikeš wrote:
> I am introducing python3-liblo package in pyliblo.
> Would be great if someone can review package before I will upload I am
> doing this first time.

Here are some remarks. In debian/control:

| Package: python-liblo
| Section: python
| Architecture: any
| Depends:
|  ${misc:Depends},
|  ${python:Depends},
|  ${shlibs:Depends}
| Breaks:
|  ${python:Breaks}

${python:Breaks} is obsolete and dh_python2 does not generate it anymore.

| XB-Python-Version: ${python:Versions}

XB-Python-Version is deprecated.

| Package: python3-liblo
| Section: python
| Architecture: any
| Depends:
|  ${misc:Depends},
|  ${python3:Depends},
|  ${shlibs:Depends}
| Breaks:
|  ${python3:Breaks}
| XB-Python-Version: ${python:Versions}

Again, ${python3:Breaks} is not generated and XB-Python-Version is
deprecated.

| Package: pyliblo-utils
| Section: utils
| Architecture: all
| Depends:
|  python-liblo,
|  ${misc:Depends},
|  ${python3:Depends}

According to shebangs of /usr/bin/{send,dump}_osc, these a scripts for
Python 2, so this should be ${python:Depends} instead.

| XB-Python-Version: ${python:Versions}

See above.

In debian/rules:
| %:
|   dh $@ --with python2,python3
|
| build-python%:
|   python$* setup.py build
|
| override_dh_auto_build: $(PYTHON3:%=build-python%)
|   dh_auto_build

Instead of the overrides, you can use the pybuild build system to
build/install. It's available from dh-python.

Python packages can also be checked with lintian4python in addition to
lintian.

Regards
-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20130825/a1c3b76f/attachment.sig>