Bug#703732: faad fails to gaplessly decode itunes, nero, fraunhofer aac

[Fabian Greffrath]

Am Sonntag, den 24.03.2013, 22:59 +0000 schrieb Julian Hughes:
> The relevant patch seems to be:
> http://www.rockbox.org/tracker/task/12185
> though I'm not knowledgeable enough to determine if this patches
> libfaad itself, rockbox's own code, or both.  Anyway I hope it is
> useful. 

This commit refers to the frontend code and does not touch libfaad
itself.

> It refers to rockbox/apps/codecs/aac.c but that's an old version
> (for their release 3.9.1)and in current Rockbox the relevant file is
> rockbox/lib/rbcodec/codecs/aac.c

I see, the libfaad source copy has also been moved around in the source
tree. However, digging through its history in the old location, I cannot
find a single commit refering to gapless playback:

http://git.rockbox.org/?p=rockbox.git;a=history;f=apps/codecs/libfaad;hb=a0009907de7a0107d49040d8a180f140e2eff299

In the new location the code has not been changed since its initial move
there on 2012-04-25:

http://git.rockbox.org/?p=rockbox.git;a=history;f=lib/rbcodec/codecs/libfaad;hb=HEAD

> I'm also sure it's an upstream issue because every faad/libfaad
> tool/app is defective in this respect unless it has been patched
> downstream. I emailed info at audiocoding.com as I couldn't find any
> upstream bugtracker or similar.  I don't expect to receive a reply but
> who knows?

I am not that sure anymore. It seems that the library is fine to play
gapless and that its the frontends that need to get patched in order to
cope with this. But this is only a guess, we are still lacking a patch
against libfaad to confirm this...

 - Fabian