Bug#793937: [RFR] templates://libdvd-pkg/{templates}

Christian PERRIER bubulle at debian.org
Wed Aug 12 06:49:40 UTC 2015 

Please find, for review, the debconf templates and packages descriptions for the libdvd-pkg source package.

This review will last from Wednesday, August 12, 2015 to Saturday, August 22, 2015.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- libdvd-pkg.old/debian/templates	2015-07-29 08:18:35.980914897 +0200
+++ libdvd-pkg/debian/templates	2015-08-08 08:24:38.242456340 +0200
@@ -2,7 +2,7 @@
 Type: note
 _Description:
  This package downloads the ${PKGG} source files from videolan.org,
- compile them and install the binary deb package(s)
+ compiles them and installs the binary deb package(s)
  [${PKGG_ALL}].
  .
  Please remember to run "sudo dpkg-reconfigure ${PKGI}"

Spelling error fix


@@ -16,7 +16,7 @@
 Type: boolean
 Default: true
 _Description: Proceed with downloading and compiling ${PKGG}${VER}?
- The installation process is therefore about to download the source files
+ The installation process is about to download the source files
  from videolan.org, compile them, and install the binary deb package(s)
  [${PKGG_ALL}].
  .

I feel like the "therefore" is useless here....


@@ -38,7 +38,7 @@
 Template: libdvd-pkg/post-invoke_hook-install
 Type: boolean
 Default: true
-_Description: Install APT post-invoke hook?
+_Description: Install APT post-invoke hook for libdvd-pkg?
  If activated, the APT post-invoke hook takes care of future automatic
  upgrades of guest package(s) on host package upgrade. When an update
  is available, the hook will attempt to download and build the package(s),

If the question comes in the middle of a bunch of other questions it
might be good for users to know that this is about libdvd-pkg


@@ -50,7 +50,7 @@
 Template: libdvd-pkg/post-invoke_hook-remove
 Type: boolean
 Default: false
-_Description: Remove APT post-invoke hook?
+_Description: Remove APT post-invoke hook for libdvd-pkg?
  If activated, the APT post-invoke hook takes care of future automatic
  upgrades of guest package(s) on host package upgrade. When an update
  is available, the hook will attempt to download and build the package(s),

Ditto

--- libdvd-pkg.old/debian/control	2015-07-29 08:18:35.980914897 +0200
+++ libdvd-pkg/debian/control	2015-08-08 08:25:18.210847421 +0200
@@ -18,5 +18,5 @@
 Suggests: ${guest:Suggests}
 Description: download and install software necessary to play video DVDs
  This package fetches, compiles from source code and installs library
- packages that are necessary to play all video DVDs with media
- player of your choice (like VLC, SMplayer, Totem, etc.).
+ packages that are necessary to play all video DVDs with any media
+ player (such as VLC, SMplayer, Totem, etc.).

avoid "of your choice"....

-- 


-------------- next part --------------
Template: libdvd-pkg/first-install
Type: note
_Description:
 This package downloads the ${PKGG} source files from videolan.org,
 compiles them and installs the binary deb package(s)
 [${PKGG_ALL}].
 .
 Please remember to run "sudo dpkg-reconfigure ${PKGI}"
 to build and install guest package(s) for the first time.

Template: libdvd-pkg/title_b-i
Type: title
_Description: Build and install ${PKGG}${VER}

Template: libdvd-pkg/build
Type: boolean
Default: true
_Description: Proceed with downloading and compiling ${PKGG}${VER}?
 The installation process is about to download the source files
 from videolan.org, compile them, and install the binary deb package(s)
 [${PKGG_ALL}].
 .
 Please confirm whether you wish this to happen.

Template: libdvd-pkg/title_u
Type: title
_Description: Upgrades available for guest package(s)

Template: libdvd-pkg/upgrade
Type: note
_Description:
 An update to guest package(s) [${PKGG_ALL}] version ${VER} is available
 but automatic upgrade is disabled.
 .
 Please remember to run "sudo dpkg-reconfigure ${PKGI}" to build and
 install guest package(s) or consider installing the APT post-invoke hook.

Template: libdvd-pkg/post-invoke_hook-install
Type: boolean
Default: true
_Description: Install APT post-invoke hook for libdvd-pkg?
 If activated, the APT post-invoke hook takes care of future automatic
 upgrades of guest package(s) on host package upgrade. When an update
 is available, the hook will attempt to download and build the package(s),
 and (if "apt-get check" reports no errors) install them with "dpkg -i".
 .
 Alternatively, guest package(s) can be built by manual invocation of
 "dpkg-reconfigure ${PKGI}".

Template: libdvd-pkg/post-invoke_hook-remove
Type: boolean
Default: false
_Description: Remove APT post-invoke hook for libdvd-pkg?
 If activated, the APT post-invoke hook takes care of future automatic
 upgrades of guest package(s) on host package upgrade. When an update
 is available, the hook will attempt to download and build the package(s),
 and (if "apt-get check" reports no errors) install them with "dpkg -i".
 .
 Alternatively, guest package(s) can be built by manual invocation of
 "dpkg-reconfigure ${PKGI}".
-------------- next part --------------
--- libdvd-pkg.old/debian/templates	2015-07-29 08:18:35.980914897 +0200
+++ libdvd-pkg/debian/templates	2015-08-08 08:24:38.242456340 +0200
@@ -2,7 +2,7 @@
 Type: note
 _Description:
  This package downloads the ${PKGG} source files from videolan.org,
- compile them and install the binary deb package(s)
+ compiles them and installs the binary deb package(s)
  [${PKGG_ALL}].
  .
  Please remember to run "sudo dpkg-reconfigure ${PKGI}"
@@ -16,7 +16,7 @@
 Type: boolean
 Default: true
 _Description: Proceed with downloading and compiling ${PKGG}${VER}?
- The installation process is therefore about to download the source files
+ The installation process is about to download the source files
  from videolan.org, compile them, and install the binary deb package(s)
  [${PKGG_ALL}].
  .
@@ -38,7 +38,7 @@
 Template: libdvd-pkg/post-invoke_hook-install
 Type: boolean
 Default: true
-_Description: Install APT post-invoke hook?
+_Description: Install APT post-invoke hook for libdvd-pkg?
  If activated, the APT post-invoke hook takes care of future automatic
  upgrades of guest package(s) on host package upgrade. When an update
  is available, the hook will attempt to download and build the package(s),
@@ -50,7 +50,7 @@
 Template: libdvd-pkg/post-invoke_hook-remove
 Type: boolean
 Default: false
-_Description: Remove APT post-invoke hook?
+_Description: Remove APT post-invoke hook for libdvd-pkg?
  If activated, the APT post-invoke hook takes care of future automatic
  upgrades of guest package(s) on host package upgrade. When an update
  is available, the hook will attempt to download and build the package(s),
--- libdvd-pkg.old/debian/control	2015-07-29 08:18:35.980914897 +0200
+++ libdvd-pkg/debian/control	2015-08-08 08:25:18.210847421 +0200
@@ -18,5 +18,5 @@
 Suggests: ${guest:Suggests}
 Description: download and install software necessary to play video DVDs
  This package fetches, compiles from source code and installs library
- packages that are necessary to play all video DVDs with media
- player of your choice (like VLC, SMplayer, Totem, etc.).
+ packages that are necessary to play all video DVDs with any media
+ player (such as VLC, SMplayer, Totem, etc.).
-------------- next part --------------
Source: libdvd-pkg
Section: contrib/utils
Priority: optional
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers at lists.alioth.debian.org>
Uploaders: Dmitry Smirnov <onlyjob at debian.org>
Standards-Version: 3.9.6
Build-Depends: debhelper (>= 9)
Vcs-Browser: http://anonscm.debian.org/cgit/pkg-multimedia/libdvd-pkg.git
Vcs-Git: git://anonscm.debian.org/pkg-multimedia/libdvd-pkg.git

Package: libdvd-pkg
Architecture: all
Provides: ${guest:Provides}
Depends: ${misc:Depends} ,build-essential
        ,wget | devscripts
        ,${guest:Build-Depends}
Recommends: ${guest:Recommends} ,libcap2-bin
Suggests: ${guest:Suggests}
Description: download and install software necessary to play video DVDs
 This package fetches, compiles from source code and installs library
 packages that are necessary to play all video DVDs with any media
 player (such as VLC, SMplayer, Totem, etc.).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20150812/d5035ddc/attachment.sig>

More information about the pkg-multimedia-maintainers mailing list