qxgedit review

[James Cowgill]

Hi,

On Sun, 2015-05-31 at 19:55 +0200, Ross Gammon wrote:
> On 05/14/2015 01:50 AM, Jaromír Mikeš wrote:
> > Hello,
> > 
> > qxgedit is almost ready.
> > I'm having this two warnings which I am not able currently fix ;(
> > 
> > I: qxgedit: hardening-no-fortify-functions usr/bin/qxgedit

configure.ac messes the flags up a bit (uses CFLAGS for C++ files,
modifies CPPFLAGS but never uses it).

Adding this to debian/rules will fix it, but upstream should sort their
configure script out:

export DEB_CFLAGS_MAINT_APPEND := $(shell dpkg-buildflags --get CPPFLAGS)

> > W: qxgedit: hardening-no-relro
> > usr/lib/x86_64-linux-gnu/qt4/plugins/styles/libskulpturestyle.so

Add this to skulpture/skulpture.pri.in (copied from src/src.pri.in).

# Extra optimization flags
QMAKE_CXXFLAGS += @ac_cflags@
QMAKE_LFLAGS += @ac_ldflags@

James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20150531/306f278f/attachment.sig>