[Pkg-opencl-devel] intel/compute-runtime (Neo)

[Andreas Beckmann]

On 2018-07-24 14:06, Jacek Danecki wrote:
> We'd prefer intel-opencl-icd name. Binary releases on github contain all libraries in one package, but we're working on
> splitting it to separate packages. If you're interested in how we plan to package Neo components, you can look at:
> - ppa: https://launchpad.net/~jdanecki/+archive/ubuntu/intel-opencl
> - copr: https://copr.fedorainfracloud.org/coprs/arturh
> These are still experimental packages, as content will change when IGC starts to use system llvm without any patches.

A short review on the Ubuntu packages ... *only reading* the source,
didn't try to build anything.

intel-opencl
============

- We probably want the binary package to be called intel-opencl-icd to
match all the others. (don't rename the source package)
- intel-opencl-icd should Provides: opencl-icd (and maybe opencl-X.Y-icd
for some X, Y), check *.opencl-icd
- do you (plan to) support i386 as well or only amd64?
- the Makefile uses strip (you could use a variable STRIP?=strip in the
Makefile and override this to STRIP=true in debian/rules) - leave the
stripping to dh_strip, which will build -dbgsym packages
- put only the library name without path into intel.icd
- run_build: only use the -jN argument for make if you are not being
called from within make (e.g. when called from debian/rules)
- 'make clean': misses neo gmmlib
- debian/copyright: use a standalone License: MIT paragraph instead of
duplicating the license, consider using "Expat" instead of "MIT" (since
the latter is ambiguous)
- there should be no need for debian/*.dirs if the install targets do
mkdir -p target-dir before installing stuff there
- do your shared libraries have a SOVERSION ?
  (and if you answer "No": Why not?)

intel-igc
=========
- Makefile uses strip
- 'make clean' misses igc llvm_patches llvm_source
- see comments for intel-opencl

intel-opencl-clang
==================
- I assume this package will go away sooner or later

Andreas