[Pkg-openssl-devel] Bug#363516: something obvious

Christian Perrier bubulle at debian.org
Tue May 20 05:15:09 UTC 2008


Quoting Jean-Yves Lefort (jylefort at brutele.be):
> The ssleay_rand_add() change was fairly idiotic. Even with no
> understanding of that function, it is strikingly obvious that after
> commenting out this statement:
> 
> 	MD_Update(&m,buf,j);
> 
> the only remaining use of the buf parameter is:
> 
> 	buf=(const char *)buf + j;
> 
> That is, the buf parameter becomes unused. This is a clear indication
> that the person who made the change had no idea of what he was doing.


What is the value added by your comment, apart from rude to the
package maintainer?

(Kurt, count me in for a beer with you at Debconf, just to confirm what
you already know: not all people who speak French are morons)



-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-openssl-devel/attachments/20080520/8196d386/attachment.pgp 


More information about the Pkg-openssl-devel mailing list