[Pkg-owncloud-commits] [owncloud-client] 161/211: Csync tests: Fix broken tests.

Sandro Knauß hefee-guest at moszumanska.debian.org
Sat Oct 25 09:10:40 UTC 2014


This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit ba86988101afa9f4f471582cab4b1e4acfbcab82
Author: Christian Kamm <kamm at incasoftware.de>
Date:   Wed Oct 22 11:50:11 2014 +0200

    Csync tests: Fix broken tests.
    
    It is no longer ok to call csync_statedb_load() on a non-existant
    database since it opens readonly only.
---
 csync/tests/csync_tests/check_csync_statedb_load.c  | 7 +++++++
 csync/tests/csync_tests/check_csync_statedb_query.c | 6 ++++++
 csync/tests/csync_tests/check_csync_update.c        | 9 +++++++++
 3 files changed, 22 insertions(+)

diff --git a/csync/tests/csync_tests/check_csync_statedb_load.c b/csync/tests/csync_tests/check_csync_statedb_load.c
index a3d0e7f..7bc148d 100644
--- a/csync/tests/csync_tests/check_csync_statedb_load.c
+++ b/csync/tests/csync_tests/check_csync_statedb_load.c
@@ -42,6 +42,13 @@ static void setup(void **state) {
 
     csync->statedb.file = c_strdup( TESTDB );
     *state = csync;
+
+    sqlite3 *db = NULL;
+    rc = sqlite3_open_v2(TESTDB, &db, SQLITE_OPEN_CREATE | SQLITE_OPEN_READWRITE, NULL);
+    assert_int_equal(rc, SQLITE_OK);
+
+    rc = sqlite3_close_v2(db);
+    assert_int_equal(rc, SQLITE_OK);
 }
 
 static void teardown(void **state) {
diff --git a/csync/tests/csync_tests/check_csync_statedb_query.c b/csync/tests/csync_tests/check_csync_statedb_query.c
index 66f6e04..91dd90a 100644
--- a/csync/tests/csync_tests/check_csync_statedb_query.c
+++ b/csync/tests/csync_tests/check_csync_statedb_query.c
@@ -47,6 +47,12 @@ static void setup(void **state)
     rc = csync_init(csync);
     assert_int_equal(rc, 0);
 
+    sqlite3 *db = NULL;
+    rc = sqlite3_open_v2(TESTDB, &db, SQLITE_OPEN_CREATE | SQLITE_OPEN_READWRITE, NULL);
+    assert_int_equal(rc, SQLITE_OK);
+    rc = sqlite3_close_v2(db);
+    assert_int_equal(rc, SQLITE_OK);
+
     rc = csync_statedb_load(csync, TESTDB, &csync->statedb.db);
     assert_int_equal(rc, 0);
 
diff --git a/csync/tests/csync_tests/check_csync_update.c b/csync/tests/csync_tests/check_csync_update.c
index 2b76911..e3845dc 100644
--- a/csync/tests/csync_tests/check_csync_update.c
+++ b/csync/tests/csync_tests/check_csync_update.c
@@ -124,9 +124,18 @@ static void setup_ftw(void **state)
     assert_int_equal(rc, 0);
     rc = csync_init(csync);
     assert_int_equal(rc, 0);
+
+    sqlite3 *db = NULL;
+    rc = sqlite3_open_v2(TESTDB, &db, SQLITE_OPEN_CREATE | SQLITE_OPEN_READWRITE, NULL);
+    assert_int_equal(rc, SQLITE_OK);
+    statedb_create_metadata_table(db);
+    rc = sqlite3_close_v2(db);
+    assert_int_equal(rc, SQLITE_OK);
+
     rc = csync_statedb_load(csync, TESTDB, &csync->statedb.db);
     assert_int_equal(rc, 0);
 
+    csync->statedb.file = c_strdup( TESTDB );
     *state = csync;
 }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git



More information about the Pkg-owncloud-commits mailing list