[Pkg-pascal-devel] Bug#1065447: unneeded libreoffice Build-Depends (libreoffice, ure-java, default-jre), -writer and -calc are enough

[Rene Engelhard]

Source: winff
Severity: normal

Hi,

I just noticed winff - thanks to your bug report :):

I see

winff (1.6.2+dfsg-2) unstable; urgency=medium

   * Temporary home directory to run soffice (Closes: #759980)
   * Build dependencies (for javaldx)
   * Escape Dollar signs in file names (Closes: #1053373)

  -- Peter Blackman <peter at pblackman.plus.com>  Thu, 05 Oct 2023 
10:00:00 +0100

in the changelog and chekced. Because that looked extremely fishy. It is.

Build-Depends-Indep:
  libreoffice,
  ure-java,
  default-jre,

What for?

a) The javaldx warning is harmless unless you do run Java stuff. Which 
you don't if you convert stuff to pdf. You can just ignore this and you 
don't need to depend on Java stuff (which is not available on all archs)[1]

b) I don't believe you need libreoffice-base etc which gets pulled in by 
the libreoffice *metapackage*.

rene at frodo:~/winff-1.6.3+dfsg/winff/docs$ ls *.od?
WinFF.ca.odt  WinFF.es_AR.odg  WinFF.nl.odt
WinFF.en.odt  WinFF.fr.odt     WinFF.pt_BR.odt

So you just need libreoffice-writer and libreoffice-draw. Tried in a 
local build with libreoffice-writer and -draw 4:24.2.1-3.

(Actually libreoffice-writer-nogui and libreoffice-draw-nogui would 
suffice but the fix for #1058653 is blocked by t64 transition. So let's
ignore that for now.)

Patch:

diff -Nru winff-1.6.3+dfsg/debian/changelog 
winff-1.6.3+dfsg/debian/changelog
--- winff-1.6.3+dfsg/debian/changelog	2024-02-19 14:00:00.000000000 +0100
+++ winff-1.6.3+dfsg/debian/changelog	2024-03-04 21:50:28.000000000 +0100
@@ -1,3 +1,10 @@
+winff (1.6.3+dfsg-1.1) UNRELEASED; urgency=medium
+
+  * only build-depend on needed libreoffice-draw, libreoffice-writer;
+    remove extraneous libreoffice, ure-java, default-jre
+
+ -- Rene Engelhard <rene at debian.org>  Mon, 04 Mar 2024 20:50:28 +0000
+
  winff (1.6.3+dfsg-1) unstable; urgency=medium

    * New Upstream release (Closes: #1053373) (Closes: #1061586)
diff -Nru winff-1.6.3+dfsg/debian/control winff-1.6.3+dfsg/debian/control
--- winff-1.6.3+dfsg/debian/control	2023-10-04 22:29:34.000000000 +0200
+++ winff-1.6.3+dfsg/debian/control	2024-03-04 21:50:28.000000000 +0100
@@ -10,9 +10,8 @@
   lcl,
   lcl-qt5,
  Build-Depends-Indep:
- libreoffice,
- ure-java,
- default-jre,
+ libreoffice-draw,
+ libreoffice-writer,
  Standards-Version: 4.6.2
  Rules-Requires-Root: no
  Vcs-Browser: https://salsa.debian.org/pascal-team/winff

Regards,

Rene

[1] _all is Built on amd64 anyways, but still.