Bug#695274: libparse-debian-packages-perl: Problem parsing stanzas with more than 1 multiline entry

[Damyan Ivanov]

-=| gregor herrmann, 28.02.2014 15:46:45 +0100 |=-
> On Tue, 18 Feb 2014 09:24:57 +0100, Simon Kainz wrote:
> 
> > I worked up a patch to hopefully fix this issue.
> > 
> > Now each multiline entry is added to it's respective key by appending
> > a line break and the following multiline entries.
> 
> I looked into this issue now (finally, sorry).
> 
> It seems that
> - Parse::Debian::Packages breaks on all multi-line entries,
>   not just the first one
>   (tested with random packages, which have a multiline Tag: field
>   and nothing else)
> - Parse::Debian::Packages assumes a body, probably the description,
>   wich doesn't exist anymore in the Packages file
> 
> So this look quite broken :/
> 
> 
> I've now adjusted your patch a bit (replaced tabs with whitespace,
> removed debug output) and tested it with several packages.
> 
> The patch is committed to the package's git repo:
> http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/libparse-debian-packages-perl.git
> 
> I'd like to have some more review to see if this is the best way to
> fix it, and if there are some cases where this might cause problems.
> (E.g. I'm no sure when the description was dropped from the Packages
> file.)

The patch looks fine to be for the purpose of fixing multi-line 
parsing.

I am not sure how a missing Description could cause problems. 
Description is just another, field, right?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20140228/2cca5caf/attachment.sig>