Bug#741000: Syntax errors with perl 5.18

[Damyan Ivanov]

Package: libical-parser-html-perl
Version: 1.07-1
Severity: grave
Tags: upstream patch

Forwarding the report by Lorenz Wenner 
(http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/2014-March/074225.html):

----------------------------------------------------
just wanted to let you know that today i fixed my 
/usr/share/perl5/iCal/Parser/HTML.pm 
from debian package libical-parser-html-perl.
In line 64 (routine sheet_args) there was

foreach my $t qw(week month year) {

which gave a syntax error on my system (jessie), whereas

foreach my $t (qw(week month year)) {
---------------------------------------------------

This is a syntax error with perl 5.18 and your fix addresses it.

Curious why t isn't cought by the test suite. Oh, the test suite fails
indeed:

--------------------------------------------------
Test Summary Report
-------------------
t/00load.t (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
t/01parse.t (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=2, Tests=2,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.32 cusr  0.02 csys =  0.36 CPU)
Result: FAIL
Failed 2/2 test programs. 1/2 subtests failed.
--------------------------------------------------

However, the package build succeeds, so it seems the test failures are simply 
ignored:

--- debian/rules ---
# FIXME: Make regression tests strict when no longer failing
DEB_PERL_CHECK_FLAGS += || true
--------------------

OUCH!

I think the test suite needs fixing, not just ignoring.


-- dam