Bug#807613: libtest-expect-perl: nondeterministic FTBFS: t/simple.t failure

[Niko Tyni]

Package: libtest-expect-perl
Version: 0.33-1
Severity: normal
Tags: patch
Forwarded: https://rt.cpan.org/Public/Bug/Display.html?id=110276

This package sometimes fails t/simple.t test 10 with

#   Failed test 'expect'
#   at lib/Test/Expect.pm line 86.
#          got: 'ping
# pong'
#     expected: 'pong'
# Looks like you failed 1 test of 18.

I can reproduce this locally by loading the host with other I/O and the
running the test in a loop. It looks like it's normally reading out the
'pong' response from the previous 'expect_send' test (rather than its
own) that never gets drained. However, sometimes stderr from careless
argument handling in the 'read' script intervenes:

 read: Can't open world: No such file or directory at ./read line 11.

The attached two patches should fix it, already forwarded upstream at
 https://rt.cpan.org/Public/Bug/Display.html?id=110276

-- 
Niko Tyni   ntyni at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-testscripts-not-to-treat-their-argument-as-a-fil.patch
Type: text/x-diff
Size: 1019 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20151210/5a458ec8/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Read-out-the-buffer-after-expect_send.patch
Type: text/x-diff
Size: 1083 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20151210/5a458ec8/attachment-0001.patch>