Bug#854859: Pending fixes for bugs in the lemonldap-ng package

[Xavier]

On 12/02/2017 14:51, gregor herrmann wrote:
> On Sun, 12 Feb 2017 13:15:49 +0100, Xavier wrote:
> 
>>> You probably want to create debian/lemonldap-ng-doc.maintscript (and drop
>>> debian/lemonldap-ng-doc.preinst), with the following content:
>>>
>>> symlink_to_dir /usr/share/doc/lemonldap-ng-doc/pages/documentation/current 1.3 1.9.7-3~
>>>
>>> (based solely on the commit diff, I didn't look further into your package)
>>>
>>
>> Thanks, it's ok now with:
>>
>> dir_to_symlink
>> /usr/share/doc/lemonldap-ng-doc/pages/documentation/current 1.3 1.4.6
>> lemonldap-ng-doc
> 
> I think this is wrong, and Andreas' proposal looks right to me:
> 1) The switch is from a symlink to a dir
> 2) The version where this is _handled_ is now, i.e. 1.9.7-3~
> 3) The package name is not needed (but shouldn't hurt)
> 
> 
> Now some testing would be good but my piuparts-fu is not good enough
> to test this uprade between a package in the archive and a locally
> built package ... So I tried manually in a jessie chroot, installed
> lemonldap-ng-doc, and then upgraded to 1.9.7-2 from the archive / 1.9.7-3
> with Xavier's version / 1.9.7-3 with Andreas' version, but all three
> end up like this (that's from the 3rd one):
> 
> # dpkg -i /home/gregoa/src/git-pkg-perl/meta/packages/build-area/lemonldap-ng-doc_1.9.7-3_all.deb
> (Reading database ... 11584 files and directories currently installed.)
> Preparing to unpack .../lemonldap-ng-doc_1.9.7-3_all.deb ...
> Unpacking lemonldap-ng-doc (1.9.7-3) over (1.3.3-1) ...
> dpkg: warning: unable to delete old directory '/usr/share/doc/lemonldap-ng-doc/pages/documentation/1.3/applications': Directory not empty
> dpkg: warning: unable to delete old directory '/usr/share/doc/lemonldap-ng-doc/pages/documentation/1.3': Directory not empty
> Setting up lemonldap-ng-doc (1.9.7-3) ...
> 
> # ls -la /usr/share/doc/lemonldap-ng-doc/pages/documentation/current                             
> lrwxrwxrwx 1 root root 3 Oct 15  2014 /usr/share/doc/lemonldap-ng-doc/pages/documentation/current -> 1.3
> 
> *headscratch*
> 
> Oh, there are no traces of the maintscript stuff in
> lemonldap-ng-doc_1.9.7-3_all.deb!
> 
> *looking carefully*
> 
> debian/lemonldap-ng-doc.mainscript --> main_T_script
> 
> Yeah, this looks much better. Scripts in the deb, no warnings, and
> /usr/share/doc/lemonldap-ng-doc/pages/documentation/current is a
> directory.
> 
> Pushed to git, waiting with an upload for a test/sanity check of you
> guys.

Oups, thank you very much ! Works fine now